liferay-npm-build-tools-common - npm Package Compare versions

Comparing version 2.0.0-rc.1 to 2.0.0-rc.2

lib/__tests__/modules.test.js

@@ -42,2 +42,3 @@ 'use strict';
 	expect(mod.isExternalDependency('a-module')).toBe(true);
+	expect(mod.isExternalDependency('fs')).toBe(true);
 
@@ -47,3 +48,2 @@ expect(mod.isExternalDependency('./a-module')).toBe(false);
 	expect(mod.isExternalDependency('/a-module')).toBe(false);
-	expect(mod.isExternalDependency('fs')).toBe(false);
 });
@@ -50,0 +50,0 @@

lib/modules.js

@@ -53,3 +53,3 @@ 'use strict';
 function isExternalDependency(modulePath) {
-	return !isLocalModule(modulePath) && !isReservedDependency(modulePath) && !isNodeCoreModule(modulePath);
+	return !isLocalModule(modulePath) && !isReservedDependency(modulePath);
 }
@@ -56,0 +56,0 @@

package.json

 {
 	"name": "liferay-npm-build-tools-common",
-	"version": "2.0.0-rc.1",
+	"version": "2.0.0-rc.2",
 	"description": "Utility library for Liferay NPM Build Tools.",
@@ -5,0 +5,0 @@ "scripts": {

src/__tests__/modules.test.js

@@ -36,2 +36,3 @@ import * as mod from '../modules';
 	expect(mod.isExternalDependency('a-module')).toBe(true);
+	expect(mod.isExternalDependency('fs')).toBe(true);
 
@@ -41,3 +42,2 @@ expect(mod.isExternalDependency('./a-module')).toBe(false);
 	expect(mod.isExternalDependency('/a-module')).toBe(false);
-	expect(mod.isExternalDependency('fs')).toBe(false);
 });
@@ -44,0 +44,0 @@

src/modules.js

@@ -80,7 +80,3 @@ // List of built-in Node.js v7.10.0 modules.
 export function isExternalDependency(modulePath) {
-	return (
-		!isLocalModule(modulePath) &&
-		!isReservedDependency(modulePath) &&
-		!isNodeCoreModule(modulePath)
-	);
+	return !isLocalModule(modulePath) && !isReservedDependency(modulePath);
 }
@@ -87,0 +83,0 @@

No alert changes

Worsened metrics

Total package byte prevSize

117027

decreased by-0.14%

Lines of code

1870

decreased by-0.21%

No dependency changes