liferay-npm-build-tools-common - npm Package Compare versions

Comparing version 2.28.0 to 2.28.1

lib/project/jar.js

@@ -106,3 +106,3 @@ "use strict";
         // TODO: deprecated 'auto-deploy-portlet', remove for the next major version
-        dot_prop_1.default.get(npmbundlerrc, 'create-jar.auto-deploy-portlet', true));
+        dot_prop_1.default.get(npmbundlerrc, 'create-jar.auto-deploy-portlet', !!this._project.pkgJson['portlet']));
     }
@@ -109,0 +109,0 @@ get supported() {

package.json

@@ -7,3 +7,3 @@ {
 		"escape-string-regexp": "^2.0.0",
-		"liferay-npm-bundler-preset-standard": "2.28.0",
+		"liferay-npm-bundler-preset-standard": "2.28.1",
 		"merge": "^2.1.1",
@@ -26,4 +26,4 @@ "properties": "^1.2.1",
 	},
-	"version": "2.28.0",
-	"gitHead": "c511aeac6b153a560c83c0a0f8bee50efaa5a6a3"
+	"version": "2.28.1",
+	"gitHead": "a874061729d3beb023b02f120862b758d731a5d7"
 }

src/project/__tests__/index.test.js

@@ -172,7 +172,20 @@ /**
 describe('project.jar.requireJsExtender', () => {
-	it('returns true when create-jar config present and features/js-extender missing', () => {
+	it('returns false when features/js-extender missing and no portlet in package.json', () => {
 		const project = new Project(
-			path.join(__dirname, '__fixtures__', 'project', 'create-jar-empty')
+			path.join(__dirname, '__fixtures__', 'project', 'empty')
 		);
 
+		expect(project.jar.requireJsExtender).toBe(false);
+	});
+
+	it('returns true when features/js-extender missing and there is portlet in package.json', () => {
+		const project = new Project(
+			path.join(
+				__dirname,
+				'__fixtures__',
+				'project',
+				'empty-with-portlet'
+			)
+		);
+
 		expect(project.jar.requireJsExtender).toBe(true);
@@ -179,0 +192,0 @@ });

src/project/jar.ts

@@ -162,3 +162,7 @@ /**
 
-			prop.get(npmbundlerrc, 'create-jar.auto-deploy-portlet', true)
+			prop.get(
+				npmbundlerrc,
+				'create-jar.auto-deploy-portlet',
+				!!this._project.pkgJson['portlet']
+			)
 		);
@@ -165,0 +169,0 @@ }

No alert changes

Improved metrics

Total package byte prevSize

316674

increased by0.24%

Number of package files

228

increased by0.44%

Lines of code

9746

increased by0.15%

Dependency changes

• + Addedbabel-plugin-add-module-metadata@2.28.1(transitive)

• + Addedbabel-plugin-alias-modules@2.28.1(transitive)

• + Addedbabel-plugin-name-amd-modules@2.28.1(transitive)

• + Addedbabel-plugin-namespace-amd-define@2.28.1(transitive)

• + Addedbabel-plugin-namespace-modules@2.28.1(transitive)

• + Addedbabel-plugin-normalize-requires@2.28.1(transitive)

• + Addedbabel-plugin-wrap-modules-amd@2.28.1(transitive)

• + Addedbabel-preset-liferay-standard@2.28.1(transitive)

• + Addedliferay-npm-bundler-plugin-exclude-imports@2.28.1(transitive)

• + Addedliferay-npm-bundler-plugin-inject-imports-dependencies@2.28.1(transitive)

• + Addedliferay-npm-bundler-plugin-inject-peer-dependencies@2.28.1(transitive)

• + Addedliferay-npm-bundler-plugin-namespace-packages@2.28.1(transitive)

• + Addedliferay-npm-bundler-plugin-replace-browser-modules@2.28.1(transitive)

• + Addedliferay-npm-bundler-plugin-resolve-linked-dependencies@2.28.1(transitive)

• + Addedliferay-npm-bundler-preset-standard@2.28.1(transitive)

• - Removedbabel-plugin-add-module-metadata@2.28.0(transitive)

• - Removedbabel-plugin-alias-modules@2.28.0(transitive)

• - Removedbabel-plugin-name-amd-modules@2.28.0(transitive)

• - Removedbabel-plugin-namespace-amd-define@2.28.0(transitive)

• - Removedbabel-plugin-namespace-modules@2.28.0(transitive)

• - Removedbabel-plugin-normalize-requires@2.28.0(transitive)

• - Removedbabel-plugin-wrap-modules-amd@2.28.0(transitive)

• - Removedbabel-preset-liferay-standard@2.28.0(transitive)

• - Removedliferay-npm-bundler-plugin-exclude-imports@2.28.0(transitive)

• - Removedliferay-npm-bundler-plugin-inject-imports-dependencies@2.28.0(transitive)

• - Removedliferay-npm-bundler-plugin-inject-peer-dependencies@2.28.0(transitive)

• - Removedliferay-npm-bundler-plugin-namespace-packages@2.28.0(transitive)

• - Removedliferay-npm-bundler-plugin-replace-browser-modules@2.28.0(transitive)

• - Removedliferay-npm-bundler-plugin-resolve-linked-dependencies@2.28.0(transitive)

• - Removedliferay-npm-bundler-preset-standard@2.28.0(transitive)

• Updatedliferay-npm-bundler-preset-standard@2.28.1