link-check - npm Package Compare versions

Comparing version 4.5.3 to 4.5.4

CHANGELOG.md

 # Changes
 
+## Version 4.5.4
+
+* #35 fix encode by adding decode first
+
 ## Version 4.5.3
@@ -4,0 +8,0 @@

lib/proto/http.js

@@ -30,3 +30,4 @@ "use strict";
         const options = {
-            uri: encodeURI(link),
+            // Decoding and encoding is required to prevent encoding already encoded URLs
+            uri: encodeURI(decodeURI(link)),
             headers: {
@@ -33,0 +34,0 @@ // override 'User-Agent' (some sites return `401` when the user-agent isn't a web browser)

package.json

 {
   "name": "link-check",
-  "version": "4.5.3",
+  "version": "4.5.4",
   "description": "checks whether a hyperlink is alive (200 OK) or dead",
@@ -5,0 +5,0 @@ "main": "index.js",

test/link-check.test.js

@@ -127,2 +127,6 @@ 'use strict';
 
+        app.get('/url_\\(with_parentheses\\)', function (req, res) {
+            res.sendStatus(200);
+        });
+
         const server = http.createServer(app);
@@ -476,2 +480,14 @@ server.listen(0 /* random open port */, 'localhost', function serverListen(err) {
 
+    it('should not encode already encoded characters', function(done) {
+        laterCustomRetryCounter = 0;
+        linkCheck(baseUrl + '/url_%28with_parentheses%29', function(err, result) {
+          console.log(err, result);
+            expect(err).to.be(null);
+            expect(result.err).to.be(null);
+            expect(result.status).to.be('alive');
+            expect(result.statusCode).to.be(200);
+            done();
+        });
+    });
+
 });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

34144

increased by2.17%

Lines of code

607

increased by2.53%

No dependency changes