listen - npm Package Compare versions

Comparing version 0.1.0 to 0.1.1

lib/listen.js

@@ -24,2 +24,3 @@ /**
   var count   = 0;
+  var called  = 0;
   var errList;
@@ -45,3 +46,3 @@ var handler;
       }
-      if (!--count && handler) {
+      if (++called === count && handler) {
         resolve(handler);
@@ -72,3 +73,3 @@ }
     handler = fn;
-    if (!count) {
+    if (called === count) {
       resolve(fn);
@@ -75,0 +76,0 @@ }

package.json

 {
   "name"            : "listen",
-  "version"         : "0.1.0",
+  "version"         : "0.1.1",
   "description"     : "Wait for the results of multiple callbacks",
@@ -5,0 +5,0 @@ "author"          : "Maximilian Antoni (http://maxantoni.de)",

test/test-listener.js

@@ -29,2 +29,3 @@ /**
 
+
 });

test/test-then.js

@@ -161,2 +161,15 @@ /**
 
+  'should not confuse argument order': function () {
+    var spy       = sinon.spy();
+
+    var callbackA = this.listener();
+    callbackA(null, false);
+    var callbackB = this.listener();
+    callbackB(null, true);
+    this.then(spy);
+
+    sinon.assert.calledWith(spy, null, [false, true]);
+  },
+
+
   'should pass error to given function': function () {
@@ -163,0 +176,0 @@ var spy       = sinon.spy();

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

13012

increased by2.67%

Lines of code

399

increased by2.57%

No dependency changes