listen - npm Package Compare versions

Comparing version 0.1.3 to 0.1.4

lib/listen.js

@@ -12,8 +12,9 @@ /**
 
-function listen(values) {
+function listen(initialValues) {
+  var values;
   if (arguments.length) {
-    if (Object.prototype.toString.call(values) !== '[object Array]') {
+    if (Object.prototype.toString.call(initialValues) !== '[object Array]') {
       throw new TypeError('Array expected');
     }
-    values = Array.prototype.slice.call(values);
+    values = Array.prototype.slice.call(initialValues);
   } else {
@@ -47,3 +48,7 @@ values = [];
     }
-    errList.push(e);
+    if (e.name === 'ErrorList') {
+      Array.prototype.push.apply(errList, e.errors);
+    } else {
+      errList.push(e);
+    }
   }
@@ -65,3 +70,3 @@
     };
-  };
+  }
 
@@ -68,0 +73,0 @@ listener.push = function push(value) {

package.json

 {
   "name"            : "listen",
-  "version"         : "0.1.3",
+  "version"         : "0.1.4",
   "description"     : "Wait for the results of multiple callbacks",
@@ -21,4 +21,5 @@ "author"          : "Maximilian Antoni (http://maxantoni.de)",
     "urun"          : "~0.0.6",
-    "sinon"         : "~1.3.4",
-    "uglify-js"     : "~1.2.6"
+    "sinon"         : "~1.4.2",
+    "uglify-js"     : "~1.2.6",
+    "autolint"      : "~1.0.4"
   },
@@ -25,0 +26,0 @@ "nomo"            : {

test/test-err.js

@@ -15,2 +15,3 @@ /**
 var listen    = require('../lib/listen');
+var ErrorList = require('../lib/error-list');
 
@@ -32,13 +33,33 @@
 
-    assert.deepEqual(spy.firstCall.args[0].errors, ['a', 'b']);
+    sinon.assert.calledWithMatch(spy, {
+      errors : ['a', 'b']
+    });
   },
 
 
+  'should add error-list to error-list for then-callback': function () {
+    var spy = sinon.spy();
+
+    this.listener.err('a');
+    this.listener.err(new ErrorList(['b', 'c']));
+    this.listener.then(spy);
+
+    sinon.assert.calledWithMatch(spy, {
+      errors : ['a', 'b', 'c']
+    });
+  },
+
+
   'should throw if called after then': function () {
     this.listener.then(function () {});
-    var self = this;
+    var error;
 
-    assert.throws(function () {
-      self.listener.err();
-    }, /^Error: Cannot be called after then$/);
+    try {
+      this.listener.err();
+    } catch (e) {
+      error = e;
+    }
+
+    assert.equal("Error", error.name);
+    assert.equal("Cannot be called after then", error.message);
   }
@@ -45,0 +66,0 @@

test/test-listener.js

@@ -32,7 +32,12 @@ /**
     this.listener.then(function () {});
-    var self = this;
+    var error;
 
-    assert.throws(function () {
-      self.listener();
-    }, /^Error: Cannot be called after then$/);
+    try {
+      this.listener();
+    } catch (e) {
+      error = e;
+    }
+
+    assert.equal('Error', error.name);
+    assert.equal('Cannot be called after then', error.message);
   }
@@ -39,0 +44,0 @@

test/test-push.js

@@ -49,7 +49,12 @@ /**
     this.listener.then(function () {});
-    var self = this;
+    var error;
 
-    assert.throws(function () {
-      self.listener.push(1);
-    }, /^Error: Cannot be called after then$/);
+    try {
+      this.listener.push(1);
+    } catch (e) {
+      error = e;
+    }
+
+    assert.equal('Error', error.name);
+    assert.equal('Cannot be called after then', error.message);
   }
@@ -56,0 +61,0 @@

test/test-then.js

@@ -204,8 +204,14 @@ /**
   'should throw if called again': function () {
-    var then= this.then;
+    var then = this.then;
+    var error;
     then(function () {});
 
-    assert.throws(function () {
+    try {
       then(function () {});
-    }, /^Error: Cannot be called more than once$/);
+    } catch (e) {
+      error = e;
+    }
+
+    assert.equal('Error', error.name);
+    assert.equal('Cannot be called more than once', error.message);
   }
@@ -212,0 +218,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Non-existent author

Supply chain risk

The package was published by an npm account that no longer exists.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

16867

increased by7.4%

Number of package files

16

increased by14.29%

Lines of code

478

increased by10.9%

Number of high supply chain risk alerts

0

decreased by-100%

Worsened metrics

Dev dependency count

5

increased by25%

No dependency changes