logfmt - npm Package Compare versions

Comparing version 0.20.0 to 0.21.0

examples/post_to_express.js

@@ -9,3 +9,5 @@ var http   = require('http');
   headers: {
-    'Content-Type':'application/logplex-1'
+    'Content-Type':'application/logplex-1',
+    'X-Request-ID':'D1908y1rl12k3jhaos9uy8a'
+
   }
@@ -12,0 +14,0 @@ };

lib/request_logger.js

@@ -12,2 +12,4 @@ var commonFormatter = function(req, res){
   var httpHeader = req.header && req.header('x-forwarded-for')
+  var requestID  = req.header && req.header('x-request-id')
+
   var ip = req.ip || httpHeader
@@ -24,2 +26,6 @@ || req.connection.remoteAddress;
 
+  if (requestID) {
+    requestData.request_id = requestID;
+  }
+
   if(res.get){
@@ -32,3 +38,2 @@ requestData.content_length = res.get('content-length');
 
-
 var immediateLogger = function(logger, options, formatter){
@@ -35,0 +40,0 @@ return function(req, res, next){

package.json

 {
   "name": "logfmt",
-  "version": "0.20.0",
+  "version": "0.21.0",
   "description": "key=value logger and parser",
@@ -5,0 +5,0 @@ "main": "logfmt.js",

test/request_logger_test.js

@@ -125,2 +125,29 @@ var logfmt = require('../logfmt'),
 
+
+  test("emits x-request-id header as request_id if present", function(done){
+    var mockReq = {method: 'GET'}
+    mockReq.path = '/bar'
+    mockReq.ip = '1.0.0.1'
+    var mockRes = {statusCode: 200}
+    var headers = {
+      "x-request-id": '56e29d80-fb82-454c-b538-7af3e9d0b18c'
+    }
+    mockReq.header = function(h){
+      return headers[h];
+    }
+    mockRes.get = function(h){
+      return headers[h];
+    }
+    mockRes.end = function(data, encoding){}
+    var next = function(){
+      assert.equal('', logfmt.stream.logline);
+    };
+    var logger = logfmt.requestLogger();
+    logger(mockReq, mockRes, next)
+    mockRes.end()
+    var actual = logfmt.parse(logfmt.stream.logline);
+    assert.equal(actual.request_id, '56e29d80-fb82-454c-b538-7af3e9d0b18c');
+    done();
+  })
+
   test("commonFormatter uses correct path", function(){
@@ -127,0 +154,0 @@ var mockReq = {method: 'GET'}

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

56460

increased by1.72%

Lines of code

1335

increased by2.3%

No dependency changes