lore-engine - npm Package Compare versions

Comparing version 1.0.17 to 1.0.18

package.json

 {
   "name": "lore-engine",
-  "version": "1.0.17",
+  "version": "1.0.18",
   "description": "A WebGL based 3D data visualization engine.",
@@ -5,0 +5,0 @@ "main": "./app.js",

README.md

@@ -6,3 +6,3 @@ ![Lore](https://github.com/reymond-group/lore/blob/master/logo.png?raw=true)
 # Lore
-Current Version: 1.0.17 ([Godzilla](https://youtu.be/RTzb-sduiWc))
+Current Version: 1.0.18 ([Godzilla](https://youtu.be/RTzb-sduiWc))
 
@@ -9,0 +9,0 @@ ### Teasers

src/Helpers/CoordinatesHelper.js

@@ -8,2 +8,3 @@ //@ts-check
 const DrawModes = require('../Core/DrawModes');
+const PointHelper = require('./PointHelper')
 
@@ -21,6 +22,4 @@ /** A helper class for drawing coordinate system indicators. For example, a grid cube. */
      */
-    constructor(renderer, geometryName, shaderName, options) {
+    constructor(renderer, geometryName, options = {}, shaderName = 'coordinates') {
         super(renderer, geometryName, shaderName);
-
-        
         this.defaults = {
@@ -215,4 +214,27 @@ position: new Vector3f(0.0, 0.0, 0.0),
     }
+
+    /**
+     * Creates an instance of CoordinatesHelper from a PointHelper.
+     * 
+     * @param {PointHelper} pointHelper A Lore.Helpers.PointHelper object.
+     */
+    static fromPointHelper(pointHelper, options = {}) {
+      let renderer = pointHelper.renderer;
+      let geometryName = pointHelper.geometry.name + '_Coordinates';
+
+      let opts = {
+        axis: {
+          x: { length: Math.abs(pointHelper.getDimensions().max.getX()) + Math.abs(pointHelper.getDimensions().min.getX()) },
+          y: { length: Math.abs(pointHelper.getDimensions().max.getY()) + Math.abs(pointHelper.getDimensions().min.getY()) },
+          z: { length: Math.abs(pointHelper.getDimensions().max.getZ()) + Math.abs(pointHelper.getDimensions().min.getZ()) }
+        }
+      }
+
+
+      opts = Utils.extend(true, opts, options);
+
+      return new CoordinatesHelper(renderer, geometryName, opts)
+    }
 }
 
 module.exports = CoordinatesHelper

src/Helpers/PointHelper.js

@@ -222,3 +222,3 @@ //@ts-check
       for (var i = 0; i < length; i++) {
-        c[i] = Color.hslToFloat(h);
+        c[i] = h;
       }
@@ -543,28 +543,17 @@ }
     let colors = this.getAttribute('color');
-    let c = null;
     let index = 0;
 
     if (typeof hue === 'number') {
-      let length = colors.length;
-      c = new Float32Array(length * 3);
       hue = Color.hslToFloat(hue);
 
-      for (let i = 0; i < length * 3; i += 3) {
-        c[i] = hue;
-        c[i + 1] = colors[i + 1];
-        c[i + 2] = colors[i + 2];
+      for (let i = 0; i < colors.length; i++) {
+        colors[i * 3] = hue;
       }
     } else {
-      let length = hue.length;
-
-      c = new Float32Array(length * 3);
-
-      for (let i = 0; i < length * 3; i += 3) {
-        c[i] = hue[index++];
-        c[i + 1] = colors[i + 1];
-        c[i + 2] = colors[i + 2];
+      for (let i = 0; i < hue.length; i++) {
+        colors[i * 3] = Color.hslToFloat(hue[i]);
       }
     }
 
-    this.setColors(c);
+    this.setColors(colors);
   }
@@ -670,6 +659,6 @@
   setRGB(r, g, b) {
-    let c = new Float32Array(length * 3);
+    let c = this.getAttribute('color');
 
-    for (let i = 0; i < length * 3; i += 3) {
-      c[i] = Color.rgbToFloat(r, g, b);
+    for (let i = 0; i < c.length; i++) {
+      c[i * 3] = Color.rgbToFloat(r, g, b);
     }
@@ -688,4 +677,4 @@
   setRGBFromArrays(r, g, b) {
-    const length = r.length;
-    let c = new Float32Array(length * 3);
+    const length = Math.min(Math.min(r.length, g.length), b.length);
+    let c = this.getAttribute('color');
 
@@ -692,0 +681,0 @@ for (let i = 0; i < length; i++) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

43836619

increased by0.02%

Number of package files

184

increased by1.1%

Lines of code

19812

increased by0.46%

No dependency changes