minipass - npm Package Compare versions

Comparing version 1.1.11 to 1.2.0

index.js

@@ -30,2 +30,57 @@ 'use strict'
 
+  get _readableState () {
+    const self = this
+    return {
+      objectMode: false,
+      highWaterMark: Number.MAX_SAFE_INTEGER,
+      buffer: self.buffer,
+      get length () {
+        return self.buffer.map(n => n.length).reduce((a,b) => a + b, 0)
+      },
+      get pipes () { return self.pipes.toArray() },
+      get pipesCount () { return self.pipes.length },
+      get flowing () { return self.flowing },
+      get ended () { return self[EOF] },
+      get endEmitted () { return self.emittedEnd },
+      reading: false,
+      sync: false,
+      needReadable: true,
+      readableListening: true,
+      resumeScheduled: true,
+      defaultEncoding: 'utf8',
+      get ranOut () { return self.buffer.length === 0 },
+      awaitDrain: 0,
+      readingMore: false,
+      get encoding () { return self.encoding }
+    }
+  }
+
+  get _writableState () {
+    const self = this
+    return {
+      objectMode: false,
+      highWaterMark: Number.MAX_SAFE_INTEGER,
+      needDrain: false,
+      get ending () { return self[EOF] },
+      get ended () { return self[EOF] },
+      get finished () { return self.emittedEnd },
+      decodeStrings: true,
+      defaultEncoding: 'utf8',
+      get length () {
+        return self.buffer.map(n => n.length).reduce((a,b) => a + b, 0)
+      },
+      writing: false,
+      corked: false,
+      sync: false,
+      bufferProcessing: false,
+      writelen: 0,
+      bufferedRequest: null,
+      lastBufferedRequest: null,
+      pendingcb: 0,
+      get prefinished () { return self[EOF] },
+      errorEmitted: false,
+      bufferedRequestCount: 0
+    }
+  }
+
   get encoding () { return this[ENCODING] }
@@ -42,4 +97,4 @@ set encoding (enc) {
 
-  get writable () { return true }
-  get readable () { return true }
+  get writable () { return !this[EOF] }
+  get readable () { return !this[EMITTED_END] }
 
@@ -173,3 +228,4 @@ write (chunk, encoding, cb) {
       this.emit('end')
-      this.emit('finished')
+      this.emit('prefinish')
+      this.emit('finish')
       this.emit('close')
@@ -176,0 +232,0 @@ }

package.json

 {
   "name": "minipass",
-  "version": "1.1.11",
+  "version": "1.2.0",
   "description": "minimal implementation of a PassThrough stream",
@@ -10,2 +10,3 @@ "main": "index.js",
   "devDependencies": {
+    "end-of-stream": "^1.4.0",
     "tap": "10"
@@ -12,0 +13,0 @@ },

test/basic.js

@@ -257,1 +257,131 @@ const MiniPass = require('../')
 })
+
+t.test('fake baroque streams state objects', t => {
+  const mp = new MiniPass({ encoding: 'utf8' })
+  const eos = require('end-of-stream')
+
+  eos(mp, er => {
+    if (er)
+      throw er
+
+    t.same(mp._readableState, {
+      objectMode: false,
+      highWaterMark: Number.MAX_SAFE_INTEGER,
+      buffer: mp.buffer,
+      length: 0,
+      pipes: [],
+      pipesCount: 0,
+      flowing: false,
+      ended: true,
+      endEmitted: true,
+      reading: false,
+      sync: false,
+      needReadable: true,
+      readableListening: true,
+      resumeScheduled: true,
+      defaultEncoding: 'utf8',
+      ranOut: true,
+      awaitDrain: 0,
+      readingMore: false,
+      encoding: 'utf8'
+    })
+
+    t.end()
+  })
+
+  t.same(mp._readableState, {
+    objectMode: false,
+    highWaterMark: Number.MAX_SAFE_INTEGER,
+    buffer: mp.buffer,
+    length: 0,
+    pipes: [],
+    pipesCount: 0,
+    flowing: false,
+    ended: false,
+    endEmitted: false,
+    reading: false,
+    sync: false,
+    needReadable: true,
+    readableListening: true,
+    resumeScheduled: true,
+    defaultEncoding: 'utf8',
+    ranOut: true,
+    awaitDrain: 0,
+    readingMore: false,
+    encoding: 'utf8'
+  })
+
+  t.same(mp._writableState, {
+    objectMode: false,
+    highWaterMark: Number.MAX_SAFE_INTEGER,
+    needDrain: false,
+    ending: false,
+    ended: false,
+    finished: false,
+    decodeStrings: true,
+    defaultEncoding: 'utf8',
+    length: 0,
+    writing: false,
+    corked: false,
+    sync: false,
+    bufferProcessing: false,
+    writelen: 0,
+    bufferedRequest: null,
+    lastBufferedRequest: null,
+    pendingcb: 0,
+    prefinished: false,
+    errorEmitted: false,
+    bufferedRequestCount: 0
+  })
+
+  mp.write('hello')
+
+  t.same(mp._readableState, {
+    objectMode: false,
+    highWaterMark: Number.MAX_SAFE_INTEGER,
+    buffer: mp.buffer,
+    length: 5,
+    pipes: [],
+    pipesCount: 0,
+    flowing: false,
+    ended: false,
+    endEmitted: false,
+    reading: false,
+    sync: false,
+    needReadable: true,
+    readableListening: true,
+    resumeScheduled: true,
+    defaultEncoding: 'utf8',
+    ranOut: false,
+    awaitDrain: 0,
+    readingMore: false,
+    encoding: 'utf8'
+  })
+
+  mp.end()
+
+  t.same(mp._writableState, {
+    objectMode: false,
+    highWaterMark: Number.MAX_SAFE_INTEGER,
+    needDrain: false,
+    ending: true,
+    ended: true,
+    finished: false,
+    decodeStrings: true,
+    defaultEncoding: 'utf8',
+    length: 5,
+    writing: false,
+    corked: false,
+    sync: false,
+    bufferProcessing: false,
+    writelen: 0,
+    bufferedRequest: null,
+    lastBufferedRequest: null,
+    pendingcb: 0,
+    prefinished: true,
+    errorEmitted: false,
+    bufferedRequestCount: 0
+  })
+
+  mp.read()
+})

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

20181

increased by27.56%

Number of package files

10

increased by11.11%

Lines of code

664

increased by35.23%

Worsened metrics

Dev dependency count

2

increased by100%

No dependency changes