mobx-react - npm Package Compare versions

Comparing version 3.5.0-fix85 to 3.5.0-fix85-2

custom.js

@@ -102,5 +102,5 @@ (function() {
                             isRenderingPending = true;
-                            if (self.__$mobxMounted) { // componentWillReact *could* cause component to be unmounted..
+                            if (/*self.__$mobxIsMounted === true &&*/ self.__$mobxIsUnmounted !== true) { // componentWillReact *could* cause component to be unmounted..
                                 React.Component.prototype.forceUpdate.call(self)
-                            } else {
+                            // } else if (!self.__$mobxIsMounted) {
                                 // long story, see:
@@ -115,3 +115,3 @@ // https://github.com/mobxjs/mobx-react/issues/85
                                 // this will trigger a warning, but yield the correct rendering, see misc.js: 133 
-                                React.Component.prototype.setState.call(self, {}) // fixes 85
+                                // React.Component.prototype.setState.call(self, {}) // fixes 85
                             }
@@ -143,3 +143,3 @@ }
                 this.render.$mobx && this.render.$mobx.dispose();
-                this.__$mobxMounted = false;
+                this.__$mobxIsUnmounted = true;
                 if (isDevtoolsEnabled) {
@@ -159,3 +159,4 @@ var node = findDOMNode(this);
             componentDidMount: function() {
-                this.__$mobxMounted = true;
+                // TODO: remove?
+                // this.__$mobxIsMounted = true;
                 if (isDevtoolsEnabled)
@@ -162,0 +163,0 @@ reportRendering(this);

index.js

@@ -102,5 +102,5 @@ (function() {
                             isRenderingPending = true;
-                            if (self.__$mobxMounted) { // componentWillReact *could* cause component to be unmounted..
+                            if (/*self.__$mobxIsMounted === true &&*/ self.__$mobxIsUnmounted !== true) { // componentWillReact *could* cause component to be unmounted..
                                 React.Component.prototype.forceUpdate.call(self)
-                            } else {
+                            // } else if (!self.__$mobxIsMounted) {
                                 // long story, see:
@@ -115,3 +115,3 @@ // https://github.com/mobxjs/mobx-react/issues/85
                                 // this will trigger a warning, but yield the correct rendering, see misc.js: 133 
-                                React.Component.prototype.setState.call(self, {}) // fixes 85
+                                // React.Component.prototype.setState.call(self, {}) // fixes 85
                             }
@@ -143,3 +143,3 @@ }
                 this.render.$mobx && this.render.$mobx.dispose();
-                this.__$mobxMounted = false;
+                this.__$mobxIsUnmounted = true;
                 if (isDevtoolsEnabled) {
@@ -159,3 +159,4 @@ var node = findDOMNode(this);
             componentDidMount: function() {
-                this.__$mobxMounted = true;
+                // TODO: remove?
+                // this.__$mobxIsMounted = true;
                 if (isDevtoolsEnabled)
@@ -162,0 +163,0 @@ reportRendering(this);

native.js

@@ -102,5 +102,5 @@ (function() {
                             isRenderingPending = true;
-                            if (self.__$mobxMounted) { // componentWillReact *could* cause component to be unmounted..
+                            if (/*self.__$mobxIsMounted === true &&*/ self.__$mobxIsUnmounted !== true) { // componentWillReact *could* cause component to be unmounted..
                                 React.Component.prototype.forceUpdate.call(self)
-                            } else {
+                            // } else if (!self.__$mobxIsMounted) {
                                 // long story, see:
@@ -115,3 +115,3 @@ // https://github.com/mobxjs/mobx-react/issues/85
                                 // this will trigger a warning, but yield the correct rendering, see misc.js: 133 
-                                React.Component.prototype.setState.call(self, {}) // fixes 85
+                                // React.Component.prototype.setState.call(self, {}) // fixes 85
                             }
@@ -143,3 +143,3 @@ }
                 this.render.$mobx && this.render.$mobx.dispose();
-                this.__$mobxMounted = false;
+                this.__$mobxIsUnmounted = true;
                 if (isDevtoolsEnabled) {
@@ -159,3 +159,4 @@ var node = findDOMNode(this);
             componentDidMount: function() {
-                this.__$mobxMounted = true;
+                // TODO: remove?
+                // this.__$mobxIsMounted = true;
                 if (isDevtoolsEnabled)
@@ -162,0 +163,0 @@ reportRendering(this);

package.json

 {
   "name": "mobx-react",
-  "version": "3.5.0-fix85",
+  "version": "3.5.0-fix85-2",
   "description": "React bindings for MobX. Create fully reactive components.",
@@ -5,0 +5,0 @@ "main": "index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

75791

increased by0.5%

Lines of code

1257

increased by0.24%

No dependency changes