mobx-react - npm Package Compare versions

Comparing version 3.5.7 to 3.5.8-fix134

CHANGELOG.md

 # MobX-React Changelog
 
+### 3.5.8
+
+* Fixed issue where `props` where not passed properly to components in very rare cases. Also fixed #115
+
 ### 3.5.7
@@ -4,0 +8,0 @@

custom.js

@@ -266,3 +266,9 @@ (function webpackUniversalModuleDefinition(root, factory) {
 	            // However, people also claim this migth happen during unit tests..
-	            _react2.default.Component.prototype.forceUpdate.call(_this);
+	            var hasError = true;
+	            try {
+	              _react2.default.Component.prototype.forceUpdate.call(_this);
+	              hasError = false;
+	            } finally {
+	              if (hasError) reaction.dispose();
+	            }
 	          }
@@ -323,8 +329,2 @@ }
 	  shouldComponentUpdate: function shouldComponentUpdate(nextProps, nextState) {
-	    // TODO: if context changed, return true.., see #18
-	    // if props or state did change, but a render was scheduled already, no additional render needs to be scheduled
-	    if (this.render.$mobx && this.render.$mobx.isScheduled() === true) {
-	      return false;
-	    }
-
 	    // update on any state changes (as is the default)
@@ -331,0 +331,0 @@ if (this.state !== nextState) {

index.js

@@ -266,3 +266,9 @@ (function webpackUniversalModuleDefinition(root, factory) {
 	            // However, people also claim this migth happen during unit tests..
-	            _react2.default.Component.prototype.forceUpdate.call(_this);
+	            var hasError = true;
+	            try {
+	              _react2.default.Component.prototype.forceUpdate.call(_this);
+	              hasError = false;
+	            } finally {
+	              if (hasError) reaction.dispose();
+	            }
 	          }
@@ -323,8 +329,2 @@ }
 	  shouldComponentUpdate: function shouldComponentUpdate(nextProps, nextState) {
-	    // TODO: if context changed, return true.., see #18
-	    // if props or state did change, but a render was scheduled already, no additional render needs to be scheduled
-	    if (this.render.$mobx && this.render.$mobx.isScheduled() === true) {
-	      return false;
-	    }
-
 	    // update on any state changes (as is the default)
@@ -331,0 +331,0 @@ if (this.state !== nextState) {

native.js

@@ -266,3 +266,9 @@ (function webpackUniversalModuleDefinition(root, factory) {
 	            // However, people also claim this migth happen during unit tests..
-	            _react2.default.Component.prototype.forceUpdate.call(_this);
+	            var hasError = true;
+	            try {
+	              _react2.default.Component.prototype.forceUpdate.call(_this);
+	              hasError = false;
+	            } finally {
+	              if (hasError) reaction.dispose();
+	            }
 	          }
@@ -323,8 +329,2 @@ }
 	  shouldComponentUpdate: function shouldComponentUpdate(nextProps, nextState) {
-	    // TODO: if context changed, return true.., see #18
-	    // if props or state did change, but a render was scheduled already, no additional render needs to be scheduled
-	    if (this.render.$mobx && this.render.$mobx.isScheduled() === true) {
-	      return false;
-	    }
-
 	    // update on any state changes (as is the default)
@@ -331,0 +331,0 @@ if (this.state !== nextState) {

package.json

 {
   "name": "mobx-react",
-  "version": "3.5.7",
+  "version": "3.5.8-fix134",
   "description": "React bindings for MobX. Create fully reactive components.",
@@ -14,4 +14,4 @@ "main": "index.js",
     "prepublish": "npm run build",
-    "test": "npm run build && browserify -x react/addons -x react/lib/ReactContext -x react/lib/ExecutionEnvironment test/*.js | tape-run && tsc -p test/ts",
-    "debug": "browserify -x react/addons -x react/lib/ReactContext -x react/lib/ExecutionEnvironment test/*.js | tape-run --browser chrome"
+    "test": "webpack && browserify -x react/addons -x react/lib/ReactContext -x react/lib/ExecutionEnvironment test/*.js | tape-run && tsc -p test/ts",
+    "debug": "webpack && browserify -x react/addons -x react/lib/ReactContext -x react/lib/ExecutionEnvironment test/*.js | tape-run --browser chrome"
   },
@@ -37,3 +37,3 @@ "author": "Michel Weststrate",
     "lodash": "^4.0.1",
-    "mobx": "^2.5.1",
+    "mobx": "^2.6.0",
     "react": "^15.2.0",
@@ -58,2 +58,2 @@ "react-addons-test-utils": "^15.2.0",
   ]
-}
+}

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Lines of code

2670

increased by0.11%

Number of medium supply chain risk alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

130671

decreased by-0.13%

Number of low quality alerts

1

increased byInfinity%

No dependency changes