mongodb - npm Package Compare versions

Comparing version 1.1.0 to 1.1.1

lib/mongodb/admin.js

@@ -179,5 +179,4 @@ /*!
   options = args.length ? args.shift() : {};
+  options.dbName = 'admin';
 
-  options.dbName = 'admin';
-  // Remove the user
   this.db.removeUser(username, options, function(err, doc) {
@@ -184,0 +183,0 @@ return callback(err, doc);

lib/mongodb/collection.js

@@ -838,10 +838,10 @@ /**
     callback(null, new Cursor(this.db, this, selector, fields, o.skip, o.limit
-		, o.sort, o.hint, o.explain, o.snapshot, o.timeout, o.tailable, o.batchSize
-		, o.slaveOk, o.raw, o.read, o.returnKey, o.maxScan, o.min, o.max, o.showDiskLoc, o.comment, o.awaitdata
-		, o.numberOfRetries, o.dbName));
+      , o.sort, o.hint, o.explain, o.snapshot, o.timeout, o.tailable, o.batchSize
+      , o.slaveOk, o.raw, o.read, o.returnKey, o.maxScan, o.min, o.max, o.showDiskLoc, o.comment, o.awaitdata
+      , o.numberOfRetries, o.dbName));
   } else {
     return new Cursor(this.db, this, selector, fields, o.skip, o.limit
-		, o.sort, o.hint, o.explain, o.snapshot, o.timeout, o.tailable, o.batchSize
-		, o.slaveOk, o.raw, o.read, o.returnKey, o.maxScan, o.min, o.max, o.showDiskLoc, o.comment, o.awaitdata
-		, o.numberOfRetries, o.dbName);
+      , o.sort, o.hint, o.explain, o.snapshot, o.timeout, o.tailable, o.batchSize
+      , o.slaveOk, o.raw, o.read, o.returnKey, o.maxScan, o.min, o.max, o.showDiskLoc, o.comment, o.awaitdata
+      , o.numberOfRetries, o.dbName);
   }
@@ -1501,3 +1501,2 @@ };
  *  - **readPreference** {String}, the preferred read preference ((Server.PRIMARY, Server.PRIMARY_PREFERRED, Server.SECONDARY, Server.SECONDARY_PREFERRED, Server.NEAREST).
- *  - **explain** {Boolean}, return the query plan for the aggregation pipeline instead of the results.
  *
@@ -1511,13 +1510,14 @@ * @param {Array} array containing all the aggregation framework commands for the execution.
 Collection.prototype.aggregate = function(pipeline, options, callback) {
-  var args = Array.prototype.slice.call(arguments, 1);
+  // *  - **explain** {Boolean}, return the query plan for the aggregation pipeline instead of the results. 2.3, 2.4
+  var args = Array.prototype.slice.call(arguments, 0);
   callback = args.pop();
-  options = args.length ? args.shift() : {};
   var self = this;
+  // Get the right options
+  options = args[args.length - 1].explain ? args.pop() : {}
 
-  if(!Array.isArray(pipeline)) return callback(new Error("pipline must be an array"));
-
-  // Check if we have more than one argument then just make the pipeline
-  // the remaining arguments
-  if(args.length > 1) {
-    pipeline = args;
+  // Convert operations to an array
+  if(!Array.isArray(args[0])) {
+    pipeline = [];
+    // Push all the operations to the pipeline
+    for(var i = 0; i < args.length; i++) pipeline.push(args[i]);
   }
@@ -1524,0 +1524,0 @@

lib/mongodb/connection/repl_set.js

@@ -183,3 +183,2 @@ var Connection = require('./connection').Connection,
 /**
- * Return the used state
  * @ignore
@@ -227,3 +226,2 @@ */
  * @ignore
- * @private
  **/
@@ -290,3 +288,2 @@ ReplSet.prototype._checkReplicaSet = function() {
  * @ignore
- * @private
  */
@@ -1172,2 +1169,3 @@ ReplSet.prototype._validateReplicaset = function(result, auths) {
   var allConnections = [];
+  if(this._state.master == null) return [];
   // Get connection object
@@ -1174,0 +1172,0 @@ var allMasterConnections = this._state.master.connectionPool.getAllConnections();

package.json

 { "name" :            "mongodb"
 , "description" :     "A node.js driver for MongoDB"
 , "keywords" :        ["mongodb", "mongo", "driver", "db"]
-, "version" :         "1.1.0"
+, "version" :         "1.1.1"
 , "author" :          "Christian Amor Kvalheim <[e-mail]>"
@@ -54,3 +54,4 @@ , "contributors" :  [ "Aaron Heckmann",
                       "Andrew Stone",
-											"John Le Drew"]
+											"John Le Drew",
+                      "Lucasfilm Singapore"]
 
@@ -62,3 +63,3 @@ , "repository" :    { "type" :  "git"
 , "dependencies" : {
-  "bson": "0.1.0"
+  "bson": "0.1.1"
 }
@@ -65,0 +66,0 @@ , "devDependencies": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No README

Quality

Package does not have a README. This may indicate a failed publish or a low quality package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

2506544

increased by0.7%

Number of package files

40

increased by5.26%

Lines of code

10641

increased by0.06%

Number of medium quality alerts

0

decreased by-100%

Number of lines in readme file

413

increased byInfinity%

Dependency changes

• + Addedbson@0.1.1(transitive)

• - Removedbson@0.1.0(transitive)

• Updatedbson@0.1.1