mongoose - npm Package Compare versions

Comparing version 1.0.12 to 1.0.13

History.md

 
+1.0.13 / 2011-02-16
+===================
+
+  * Fixed embedded documents saving.
+
 1.0.12 / 2011-02-14 
@@ -3,0 +8,0 @@ ===================

lib/mongoose/index.js

@@ -256,3 +256,3 @@
 
-exports.version = '1.0.12';
+exports.version = '1.0.13';
 
@@ -259,0 +259,0 @@ /**

lib/mongoose/model.js

@@ -154,3 +154,5 @@
         // normalize MongooseArray or MongooseNumber
-        if (type._path)
+        if (type instanceof MongooseArray) {
+          type = type.toObject();
+        } else if (type._path)
           type = type.valueOf();
@@ -157,0 +159,0 @@

lib/mongoose/types/documentarray.js

@@ -77,2 +77,16 @@
 /**
+ * Returns an Array and converts any Document
+ * members toObject.
+ *
+ * @return {Array}
+ * @api public
+ */
+
+MongooseDocumentArray.prototype.toObject = function () {
+  return this.map( function (doc) {
+    return doc.toObject();
+  });
+};
+
+/**
  * Module exports.
@@ -79,0 +93,0 @@ */

package.json

 {
     "name": "mongoose"
   , "description": "Mongoose MongoDB ORM"
-  , "version": "1.0.12"
+  , "version": "1.0.13"
   , "author": "Guillermo Rauch <[e-mail]>"
@@ -6,0 +6,0 @@ , "keywords": ["mongodb", "mongoose", "orm", "data", "datastore", "nosql"]

test/model.test.js

@@ -163,2 +163,24 @@
 
+  'test a model that defaults an Array attributes to an empty array': function () {
+    var db = start()
+      , DefaultZeroCardArraySchema = new Schema({
+          arr: {type: Array, cast: String, default: []}
+        });
+    mongoose.model('DefaultZeroCardArray', DefaultZeroCardArraySchema);
+    var DefaultZeroCardArray = db.model('DefaultZeroCardArray', collection);
+    var arr = new DefaultZeroCardArray();
+    arr.get('arr').should.have.length(0);
+    arr.arr.should.have.length(0);
+    db.close();
+  },
+
+  'test that arrays auto-default to the empty array': function () {
+    var db = start()
+      , BlogPost = db.model('BlogPost', collection);
+
+    var post = new BlogPost();
+    post.numbers.should.have.length(0);
+    db.close();
+  },
+
   'test instantiating a model with a hash that maps to at least 1 null value': function () {
@@ -1552,2 +1574,25 @@ var db = start()
   },
+
+  // GH-255
+  'test updating an embedded document in an embedded array': function () {
+    var db = start()
+      , BlogPost = db.model('BlogPost', collection);
+
+    BlogPost.create({comments: [{title: 'woot'}]}, function (err, post) {
+      should.strictEqual(err, null);
+      BlogPost.findById(post._id, function (err, found) {
+        should.strictEqual(err, null);
+        found.comments[0].title.should.equal('woot');
+        found.comments[0].title = 'notwoot';
+        found.save( function (err) {
+          should.strictEqual(err, null);
+          BlogPost.findById(found._id, function (err, updated) {
+            db.close();
+            should.strictEqual(err, null);
+            updated.comments[0].title.should.equal('notwoot');
+          });
+        });
+      });
+    });
+  },
   'test filtering an embedded array by the id shortcut function': function () {
@@ -1554,0 +1599,0 @@ var db = start()

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No License Found

License

(Experimental) License information could not be found.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1405774

increased by0.14%

Number of low license alerts

0

decreased by-100%

Lines of code

24844

increased by0.22%

No dependency changes