mqtt - npm Package Compare versions

Comparing version 5.7.0 to 5.7.1

build/lib/handlers/ack.js

@@ -54,3 +54,3 @@ "use strict";
     const cb = client.outgoing[messageId] ? client.outgoing[messageId].cb : null;
-    let err;
+    let err = null;
     if (!cb) {
@@ -101,3 +101,6 @@ client.log('_handleAck :: Server sent an ack in error. Ignoring.');
             for (let grantedI = 0; grantedI < granted.length; grantedI++) {
-                if ((granted[grantedI] & 0x80) !== 0) {
+                const subackRC = granted[grantedI];
+                if ((subackRC & 0x80) !== 0) {
+                    err = new Error(`Subscribe error: ${exports.ReasonCodes[subackRC]}`);
+                    err.code = subackRC;
                     const topics = client.messageIdToTopic[messageId];
@@ -113,3 +116,3 @@ if (topics) {
             client['_invokeStoreProcessingQueue']();
-            cb(null, packet);
+            cb(err, packet);
             break;
@@ -116,0 +119,0 @@ }

package.json

 {
   "name": "mqtt",
   "description": "A library for the MQTT protocol",
-  "version": "5.7.0",
+  "version": "5.7.1",
   "contributors": [
@@ -6,0 +6,0 @@ "Adam Rudd <[e-mail]>",

README.md

@@ -900,4 +900,7 @@ # ![mqtt.js](https://raw.githubusercontent.com/mqttjs/MQTT.js/137ee0e3940c1f01049a30248c70f24dc6e6f829/MQTT.js.png)
 ```js
+import 'abortcontroller-polyfill/dist/abortcontroller-polyfill-only' // import before mqtt.
 const mqtt = require("mqtt");
-const client = mqtt.connect("wxs://test.mosquitto.org");
+const client = mqtt.connect("wxs://test.mosquitto.org", {
+  timerVariant: 'native' // more info ref issue: #1797
+});
 ```
@@ -904,0 +907,0 @@

src/lib/handlers/ack.ts

@@ -57,3 +57,3 @@ // Other Socket Errors: EADDRINUSE, ECONNRESET, ENOTFOUND, ETIMEDOUT.
 	const cb = client.outgoing[messageId] ? client.outgoing[messageId].cb : null
-	let err
+	let err = null
 
@@ -121,3 +121,7 @@ // Checking `!cb` happens to work, but it's not technically "correct".
 			for (let grantedI = 0; grantedI < granted.length; grantedI++) {
-				if ((granted[grantedI] & 0x80) !== 0) {
+				const subackRC = granted[grantedI]
+				if ((subackRC & 0x80) !== 0) {
+					err = new Error(`Subscribe error: ${ReasonCodes[subackRC]}`)
+					err.code = subackRC
+
 					// suback with Failure status
@@ -134,3 +138,3 @@ const topics = client.messageIdToTopic[messageId]
 			client['_invokeStoreProcessingQueue']()
-			cb(null, packet)
+			cb(err, packet)
 			break
@@ -137,0 +141,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1853000

increased by0.05%

Lines of code

32295

increased by0.03%

Number of lines in readme file

953

increased by0.32%

Worsened metrics

Published versions last two months

2

decreased by-33.33%

No dependency changes