mysql - npm Package Compare versions

Comparing version 2.4.0 to 2.4.1

Changes.md

@@ -7,2 +7,6 @@ # Changes
 
+## v2.4.1 (2014-07-17)
+
+* Fix `pool.query` not invoking callback on connection error #872
+
 ## v2.4.0 (2014-07-13)
@@ -9,0 +13,0 @@

lib/Pool.js

@@ -172,3 +172,7 @@ var mysql          = require('../');
   this.getConnection(function (err, conn) {
-    if (err) return cb && cb(err);
+    if (err) {
+      var cb = query._callback;
+      cb && cb(err);
+      return;
+    }
 
@@ -175,0 +179,0 @@ // Release connection based off event

package.json

 {
   "name": "mysql",
   "description": "A node.js driver for mysql. It is written in JavaScript, does not require compiling, and is 100% MIT licensed.",
-  "version": "2.4.0",
+  "version": "2.4.1",
   "license": "MIT",
@@ -20,2 +20,5 @@ "author": "Felix Geisendörfer <[e-mail]> (http://debuggable.com/)",
   "devDependencies": {
+    "istanbul": "0.3.0",
+    "rimraf": "2.2.8",
+    "mkdirp": "0.5.0",
     "underscore": "1.6.0",
@@ -29,4 +32,6 @@ "urun": "0.0.8",
   "scripts": {
-    "test": "node test/run.js"
+    "test": "node test/run.js",
+    "test-cov": "node test/run-cov.js",
+    "test-travis": "node test/run-cov.js lcovonly"
   }
 }

Readme.md

@@ -1,3 +0,7 @@
-# mysql [![Build Status](https://travis-ci.org/felixge/node-mysql.svg?branch=master)](https://travis-ci.org/felixge/node-mysql) [![NPM version](https://badge.fury.io/js/mysql.svg)](http://badge.fury.io/js/mysql)
+# mysql
 
+[![NPM version](https://badge.fury.io/js/mysql.svg)](http://badge.fury.io/js/mysql)
+[![Build Status](https://travis-ci.org/felixge/node-mysql.svg?branch=master)](https://travis-ci.org/felixge/node-mysql)
+[![Coverage Status](https://img.shields.io/coveralls/felixge/node-mysql.svg)](https://coveralls.io/r/felixge/node-mysql)
+
 ## Install
@@ -4,0 +8,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

299257

increased by0.15%

Lines of code

5374

increased by0.07%

Number of lines in readme file

1142

increased by0.35%

Worsened metrics

Dev dependency count

6

increased by100%

No dependency changes