nano - npm Package Compare versions

Comparing version 3.3.4 to 3.3.5

nano.js

@@ -21,2 +21,3 @@ /* minimal couch in node
   , u           = require('url')
+  , util        = require('util')
   , errs        = require('errs')
@@ -109,3 +110,3 @@ , follow
     var log     = logging()
-      , params  = opts.params
+      , params  = util._extend({}, opts.params)
       , headers = { "content-type": "application/json"
@@ -191,10 +192,10 @@ , "accept"      : "application/json"
     // these need to be encoded
-    if(!isEmpty(params)) {
+    if(!isEmpty(opts.params)) {
       try {
         ['startkey', 'endkey', 'key', 'keys'].forEach(function (key) {
-          if (key in params) {
-            try { params[key] = JSON.stringify(params[key]); }
+          if (key in opts.params) {
+            try { params[key] = JSON.stringify(opts.params[key]); }
             catch (err) {
               return errs.handle(errs.merge(err,
-                { "message": "bad params: " + key + " = " + params[key]
+                { "message": "bad params: " + key + " = " + opts.params[key]
                 , "scope"  : "nano"
@@ -201,0 +202,0 @@ , "errid"  : "encode_keys"

package.json

@@ -5,3 +5,3 @@ { "name"            : "nano"
 , "repository"      : "git://github.com/dscape/nano"
-, "version"         : "3.3.4"
+, "version"         : "3.3.5"
 , "author"          : "Nuno Job <[e-mail]> (http://nunojob.com)"
@@ -33,2 +33,3 @@ , "contributors"    :
   , "Etienne Folio (https://github.com/Ornthalas)"
+  , "John Chesley (http://chesl.es)"
   ]
@@ -45,3 +46,3 @@ , "keywords"        :
   , "specify"       : "1.1.x"
-  , "nock"          : "0.13.x"
+  , "nock"          : "0.14.x"
   }
@@ -48,0 +49,0 @@ , "scripts"         :

tests/design/query.js

@@ -51,2 +51,25 @@ var specify  = require('specify')
 
+specify("design_query:reuse_params", timeout, function (assert) {
+  var opts = { key: ["Derek","San Francisco"] };
+  db.view('people','by_name_and_city', opts, function(error, view) {
+    assert.equal(error, undefined, "View didn't respond");
+    assert.equal(view.rows.length,1);
+    assert.equal(view.rows.length,1);
+    assert.equal(view.rows[0].id,'p_derek');
+    assert.equal(view.rows[0].key[0],'Derek');
+    assert.equal(view.rows[0].key[1],'San Francisco');
+  });
+  db.view('people','by_name_and_city', opts, function(error, view) {
+    assert.equal(error, undefined, "View didn't respond");
+    assert.equal(view.rows.length,1);
+    assert.equal(view.rows.length,1);
+    assert.equal(view.rows[0].id,'p_derek');
+    assert.equal(view.rows[0].key[0],'Derek');
+    assert.equal(view.rows[0].key[1],'San Francisco');
+  });
+  assert.ok(Array.isArray(opts.key));
+  assert.equal(opts.key[0],'Derek');
+  assert.equal(opts.key[1],'San Francisco');
+});
+
 specify("design_query:teardown", timeout, function (assert) {
@@ -59,2 +82,2 @@ nano.db.destroy("design_query", function (err) {
 
-specify.run(process.argv.slice(2));
+specify.run(process.argv.slice(2));

tests/fixtures/design/query.json

@@ -34,2 +34,8 @@ [
   }
+, { "path"     : "/design_query/_design/people/_view/by_name_and_city?key=%5B%22Derek%22%2C%22San%20Francisco%22%5D"
+  , "response" : "{\"total_rows\":3,\"offset\":0,\"rows\":[\r\n{\"id\":\"p_derek\",\"key\":[\"Derek\",\"San Francisco\"],\"value\":\"p_derek\"}\r\n]}\n"
+  }
+, { "path"     : "/design_query/_design/people/_view/by_name_and_city?key=%5B%22Derek%22%2C%22San%20Francisco%22%5D"
+  , "response" : "{\"total_rows\":3,\"offset\":0,\"rows\":[\r\n{\"id\":\"p_derek\",\"key\":[\"Derek\",\"San Francisco\"],\"value\":\"p_derek\"}\r\n]}\n"
+  }
 , { "method"   : "delete"
@@ -36,0 +42,0 @@ , "path"     : "/design_query"

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

151112

increased by1.08%

Lines of code

3580

increased by0.85%

No dependency changes