nat-upnp - npm Package Compare versions

Comparing version 0.0.3 to 0.1.0

lib/nat-upnp/client.js

@@ -12,3 +12,3 @@ var nat = require('../nat-upnp');
 
-Client.prototype.addMapping = function addMapping(options, callback) {
+Client.prototype.portMapping = function portMapping(options, callback) {
   if (!callback) callback = function() {};
@@ -19,9 +19,24 @@
 
+    var remote = typeof options.public === 'number' ?
+          { port: options.public }
+          :
+          options.public,
+        internal = typeof options.private === 'number' ?
+          { port: options.private }
+          :
+          options.private;
+
+    if (typeof options.public === 'number') {
+      remote = { port: options.public };
+    } else {
+      remote = options.public;
+    }
+
     gateway.run('AddPortMapping', [
-      ['NewRemoteHost', options.remote.host],
-      ['NewExternalPort', options.remote.port],
+      ['NewRemoteHost', remote.host],
+      ['NewExternalPort', remote.port],
       ['NewProtocol', options.protocol ?
           options.protocol.toUpperCase() : 'TCP'],
-      ['NewInternalPort', options.internal.port],
-      ['NewInternalClient', options.internal.host || address],
+      ['NewInternalPort', internal.port],
+      ['NewInternalClient', internal.host || address],
       ['NewEnabled', 1],
@@ -28,0 +43,0 @@ ['NewPortMappingDescription', options.description || 'node:nat:upnp'],

package.json

 {
   "name": "nat-upnp",
-  "version": "0.0.3",
+  "version": "0.1.0",
   "main": "lib/nat-upnp",
@@ -5,0 +5,0 @@ "author": "Fedor Indutny <[e-mail]>",

test/api-test.js

@@ -11,10 +11,6 @@ var assert = require('assert'),
   it('should find router device', function(callback) {
-    c.addMapping({
-      remote: {
-        port: ~~(Math.random() * 65536)
-      },
-      internal: {
-        port: ~~(Math.random() * 65536)
-      },
-      ttl: 10
+    c.portMapping({
+      public: ~~(Math.random() * 65536),
+      private: ~~(Math.random() * 65536),
+      ttl: 5
     }, function(err) {
@@ -21,0 +17,0 @@ assert.equal(err, null);

No alert changes

Improved metrics

Total package byte prevSize

12721

increased by2.57%

Lines of code

338

increased by2.74%

No dependency changes