nativescript-cloud - npm Package Compare versions

Comparing version 1.19.0 to 1.19.1-2019-09-18-1

docs/cloud-build.md

@@ -5,3 +5,3 @@ # tns cloud build
 
-Builds the project in the cloud for a specified platform. The produced build result (`.apk`, `.ipa` or `.zip` containing `.app` for iOS Simulator) is downloaded in the `.cloud` directory, which is located in the root of the project.
+Builds the project in the cloud for a specified platform. The produced build result (`.apk`, `.aab`, `.ipa` or `.zip` containing `.app` for iOS Simulator) is downloaded in the `.cloud` directory, which is located in the root of the project.
 
@@ -34,2 +34,3 @@ When running this command the HMR (Hot Module Replacement) is not enabled by default. In case you want to enable HMR, you can pass `--hmr` flag.
 * `--sharedCloud` - Builds the application in the shared cloud instead of the private one. This option is valid only for users who have access to the Private Cloud feature.
+* `--aab` - Specifies that the build will produce an Android App Bundle(`.aab`) file.
 
@@ -36,0 +37,0 @@ <% if(isHtml) { %>

lib/commands/build-command-helper.js

@@ -140,3 +140,4 @@ "use strict";
                 buildData.buildConfiguration = constants_1.CLOUD_BUILD_CONFIGURATIONS.RELEASE;
-                packagePath = (yield this.$nsCloudBuildService.build(buildData.projectSettings, buildData.platform, buildData.buildConfiguration, this.$options.accountId, buildData.androidBuildData, buildData.iOSBuildData)).qrData.originalUrl;
+                const cloudResult = yield this.$nsCloudBuildService.build(buildData.projectSettings, buildData.platform, buildData.buildConfiguration, this.$options.accountId, buildData.androidBuildData, buildData.iOSBuildData);
+                packagePath = cloudResult.qrData ? cloudResult.qrData.originalUrl : cloudResult.outputFilePath;
             }
@@ -143,0 +144,0 @@ return packagePath;

lib/services/cloud-build-service.js

@@ -81,3 +81,4 @@ "use strict";
             const isReleaseBuild = this.$nsCloudBuildHelper.isReleaseConfiguration(buildConfiguration);
-            if (this.$mobileHelper.isAndroidPlatform(platform) && isReleaseBuild) {
+            const isAndroidBuild = this.$mobileHelper.isAndroidPlatform(platform);
+            if (isAndroidBuild && isReleaseBuild) {
                 buildFiles.push({
@@ -118,3 +119,4 @@ filename: uuid.v4(),
             }
-            if (androidBuildData && androidBuildData.aab) {
+            const useAabFlag = isAndroidBuild && androidBuildData && androidBuildData.aab;
+            if (useAabFlag) {
                 additionalCliFlags.push("--aab");
@@ -136,3 +138,3 @@ }
             });
-            if (this.$mobileHelper.isAndroidPlatform(platform)) {
+            if (isAndroidBuild) {
                 buildProps = yield this.$nsCloudBuildPropertiesService.getAndroidBuildProperties(projectSettings, buildProps, filesToUpload, androidBuildData);
@@ -160,12 +162,19 @@ }
                 emulator: iOSBuildData && !iOSBuildData.buildForDevice,
-                extension: androidBuildData && androidBuildData.aab ? "aab" : null
+                extension: useAabFlag ? "aab" : null
             });
             this.$logger.info(`The result of ${buildInformationString} successfully downloaded. OutputFilePath: ${localBuildResult}`);
-            const buildResultUrl = this.getBuildResultUrl(buildResult);
-            const itmsOptions = {
-                pathToProvision: iOSBuildData && iOSBuildData.pathToProvision,
-                projectId: projectSettings.projectId,
-                projectName: projectSettings.projectName,
-                url: buildResultUrl
-            };
+            let qrData = null;
+            if (!useAabFlag) {
+                const buildResultUrl = this.getBuildResultUrl(buildResult);
+                const itmsOptions = {
+                    pathToProvision: iOSBuildData && iOSBuildData.pathToProvision,
+                    projectId: projectSettings.projectId,
+                    projectName: projectSettings.projectName,
+                    url: buildResultUrl
+                };
+                qrData = {
+                    originalUrl: buildResultUrl,
+                    imageData: yield this.getImageData(buildResultUrl, itmsOptions)
+                };
+            }
             const result = {
@@ -176,6 +185,3 @@ cloudOperationId: cloudOperationId,
                 outputFilePath: localBuildResult,
-                qrData: {
-                    originalUrl: buildResultUrl,
-                    imageData: yield this.getImageData(buildResultUrl, itmsOptions)
-                }
+                qrData
             };
@@ -182,0 +188,0 @@ // In case HMR is passed, do not save the hashes as the files generated in the cloud may differ from the local ones.

package.json

 {
   "name": "nativescript-cloud",
-  "version": "1.19.0",
+  "version": "1.19.1-2019-09-18-1",
   "description": "Used for cloud support in NativeScript CLI",
@@ -5,0 +5,0 @@ "main": "lib/bootstrap.js",

README.md

@@ -88,3 +88,3 @@ # nativescript-cloud
 #### build method
-`build` method validates passed arguments and tries to build the application in the cloud. In case of successful build, the build result (.apk, .ipa or .zip) is downloaded. The result contains information about the whole build process, path to the downloaded build result and information used to generate a QR code, pointing to the latest build result (in S3). </br>
+`build` method validates passed arguments and tries to build the application in the cloud. In case of successful build, the build result (.apk, .aab, .ipa or .zip) is downloaded. The result contains information about the whole build process, path to the downloaded build result and information used to generate a QR code, pointing to the latest build result (in S3). </br>
 Definition:
@@ -91,0 +91,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

464847

increased by0.09%

Lines of code

6238

increased by0.11%

Worsened metrics

Number of low quality alerts

1

increased byInfinity%

No dependency changes