nativescript-theme-core - npm Package Compare versions

Comparing version 2.0.23 to 2.0.24

CHANGELOG.md

@@ -0,1 +1,18 @@
+<a name="2.0.24 beta"></a>
+## [2.0.24 beta](https://github.com/NativeScript/theme/compare/v2.0.23...v2.0.24) (2019-10-10)
+
+### Features
+
+* Add platform API classes in .ns-{platform}-{sdkVersion} format to the root element, which should allow
+ targeting both platform and sdkVersion
+* Make .hr to depend on background color by default
+
+### Fixes
+
+* Fix SideDrawer styling to be more like in templates
+* Update Kendo skin colors to be more alike their web counterparts
+* Fix .ns-statusbar-transparent to not target or break API 19
+* Fix compat theme setting in app
+* Make sure app-compat to target compat theming with the variable
+
 <a name="2.0.23 beta"></a>
@@ -2,0 +19,0 @@ ## [2.0.23 beta](https://github.com/NativeScript/theme/compare/v2.0.22...v2.0.23) (2019-09-30)

index.js

@@ -26,2 +26,4 @@ "use strict";
 const whiteSpaceRegExp = /\s+/;
+const platformClass = `ns-${_platform.isAndroid ? "android" : "ios"}`;
+const sdkVersionClass = _platform.device.sdkVersion.replace(".", "-");
 
@@ -154,2 +156,7 @@ let started = false;
     if (!root || root.cssClasses.has("ns-root")) {
+        // Add ns-{platform}-{sdkVersion} classes
+        if (root) {
+            root.className = new ClassList(root.className).add(`${platformClass}__${sdkVersionClass}`).get();
+        }
+
         return;
@@ -161,8 +168,4 @@ }
 
-    const classList = new ClassList(root.className);
+    root.className = new ClassList(root.className).add("ns-root", platformClass, `ns-${_platform.device.deviceType.toLowerCase()}`).get();
 
-    classList.add("ns-root", `ns-${_platform.isAndroid ? "android" : "ios"}`, `ns-${_platform.device.deviceType.toLowerCase()}`);
-
-    root.className = classList.get();
-
     if (!started) {
@@ -169,0 +172,0 @@ handleOrientation({ newValue: getOrientation() });

package.json

 {
   "name": "nativescript-theme-core",
-  "version": "2.0.23",
+  "version": "2.0.24",
   "description": "Telerik NativeScript Core Theme",
@@ -5,0 +5,0 @@ "main": "index",

README.md

@@ -162,5 +162,7 @@ # NativeScript Theme: Core V2
 The newest addition is `.ns-statusbar-transparent` since 2.0.4 - add this class to your root element, if you have enabled 
-transparent status bar in the OS and your ActionBar gets underneath it. Keep in mind that **Android APIs before 21** don't
-support transparent status bars and this will result in an undesired top ActionBar padding.
+transparent status bar in the OS and your ActionBar gets underneath it. 
 
+> Keep in mind that **Android APIs before 21** don't support transparent status bars and this will result 
+in an undesired top ActionBar padding!
+
 ## Using Theme variables
@@ -290,5 +292,8 @@
 
-Take this file, add the following row under it:
+Take this file, add the following under it:
 
 ```scss
+// Uncomment this row, if you target compat styling:
+// $compat: true;
+
 @import '~nativescript-theme-core/index';
@@ -295,0 +300,0 @@ ```

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

557901

increased by4.07%

Lines of code

314

increased by25.6%

Number of lines in readme file

415

increased by1.22%

No dependency changes