ng-annotate - npm Package Compare versions

Comparing version 0.9.0 to 0.9.1

build/es5/ng-annotate-main.js

@@ -211,3 +211,3 @@ // ng-annotate-main.js
         args.length === 1 && args[0] :
-        args.length === 2 && ((args[0].type === "Literal" && is.string(args[0].value)) || args[0].type === "Identifier") && args[1]);
+        args.length === 2 && args[0].type === "Literal" && is.string(args[0].value) && args[1]);
 }
@@ -214,0 +214,0 @@

build/es5/ng-annotate.js

@@ -10,3 +10,3 @@ // ng-annotate.js
 var ngAnnotate = require("./ng-annotate-main");
-var version = "0.9.0";
+var version = "0.9.1";
 var optimist = require("optimist")
@@ -13,0 +13,0 @@ .usage("ng-annotate v" + version + "\n\nUsage: ng-annotate OPTIONS file.js")

build/es5/tests/original.js

@@ -25,6 +25,2 @@ "use strict";
 
-// variable instead of string as first argument
-myMod.controller(ctrlName, function($scope, $timeout) {});
-angular.module("MyMod").controller(ctrlName, function($scope, $timeout) {});
-
 // object property
@@ -31,0 +27,0 @@ var myObj = {};

build/es5/tests/with_annotations_single.js

@@ -25,6 +25,2 @@ "use strict";
 
-// variable instead of string as first argument
-myMod.controller(ctrlName, ['$scope', '$timeout', function($scope, $timeout) {}]);
-angular.module("MyMod").controller(ctrlName, ['$scope', '$timeout', function($scope, $timeout) {}]);
-
 // object property
@@ -31,0 +27,0 @@ var myObj = {};

build/es5/tests/with_annotations.js

@@ -25,6 +25,2 @@ "use strict";
 
-// variable instead of string as first argument
-myMod.controller(ctrlName, ["$scope", "$timeout", function($scope, $timeout) {}]);
-angular.module("MyMod").controller(ctrlName, ["$scope", "$timeout", function($scope, $timeout) {}]);
-
 // object property
@@ -31,0 +27,0 @@ var myObj = {};

CHANGES.md

@@ -0,1 +1,5 @@
+## v0.9.1 2014-05-14
+ * bugfix false positive regression
+   revert 0.9.0 match .controller(name, ..) in addition to .controller("name"..
+
 ## v0.9.0 2014-05-13
@@ -2,0 +6,0 @@ * explicit annotations using /* @ngInject */

ng-annotate-main.js

@@ -211,3 +211,3 @@ // ng-annotate-main.js
         args.length === 1 && args[0] :
-        args.length === 2 && ((args[0].type === "Literal" && is.string(args[0].value)) || args[0].type === "Identifier") && args[1]);
+        args.length === 2 && args[0].type === "Literal" && is.string(args[0].value) && args[1]);
 }
@@ -214,0 +214,0 @@

package.json

 {
   "name": "ng-annotate",
-  "version": "0.9.0",
+  "version": "0.9.1",
   "description": "add, remove and rebuild angularjs dependency injection annotations",
@@ -5,0 +5,0 @@ "main": "build/es5/ng-annotate-main.js",

README.md

@@ -81,5 +81,2 @@ # ng-annotate
 
-`angular.module("MyMod").controller(name, ..)` where name is a variable rather than a
-string literal is also supported.
-
 ng-annotate understands `this.$get = function($scope) ..` and
@@ -86,0 +83,0 @@ `{.., $get: function($scope) ..}` inside a `provider`. `self` and `that` can be used as

tests/original.js

@@ -25,6 +25,2 @@ "use strict";
 
-// variable instead of string as first argument
-myMod.controller(ctrlName, function($scope, $timeout) {});
-angular.module("MyMod").controller(ctrlName, function($scope, $timeout) {});
-
 // object property
@@ -31,0 +27,0 @@ var myObj = {};

tests/with_annotations_single.js

@@ -25,6 +25,2 @@ "use strict";
 
-// variable instead of string as first argument
-myMod.controller(ctrlName, ['$scope', '$timeout', function($scope, $timeout) {}]);
-angular.module("MyMod").controller(ctrlName, ['$scope', '$timeout', function($scope, $timeout) {}]);
-
 // object property
@@ -31,0 +27,0 @@ var myObj = {};

tests/with_annotations.js

@@ -25,6 +25,2 @@ "use strict";
 
-// variable instead of string as first argument
-myMod.controller(ctrlName, ["$scope", "$timeout", function($scope, $timeout) {}]);
-angular.module("MyMod").controller(ctrlName, ["$scope", "$timeout", function($scope, $timeout) {}]);
-
 // object property
@@ -31,0 +27,0 @@ var myObj = {};

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

171007

increased by2.02%

Number of package files

53

increased by3.92%

Worsened metrics

Lines of code

4742

decreased by-0.38%

Number of lines in readme file

168

decreased by-1.75%

No dependency changes