node-elm-compiler - npm Package Compare versions

Comparing version 4.1.4 to 4.1.5

index.js

@@ -8,3 +8,3 @@ 'use strict';
 var path = require("path");
-var temp = require("temp");
+var temp = require("temp").track();
 var firstline = require("firstline");
@@ -225,3 +225,2 @@
           if (exitCode !== 0) {
-            temp.cleanupSync();
             return reject(new Error('Compilation failed\n' + output));
@@ -233,3 +232,2 @@ } else if (options.verbose) {
           fs.readFile(info.path, {encoding: "utf8"}, function(err, data){
-            temp.cleanupSync();
             return err ? reject(err) : resolve(data);
@@ -236,0 +234,0 @@ });

package.json

 {
   "name": "node-elm-compiler",
-  "version": "4.1.4",
+  "version": "4.1.5",
   "description": "A Node.js interface to the Elm compiler binaries. Supports Elm version 0.17",
@@ -5,0 +5,0 @@ "main": "index.js",

README.md

@@ -17,2 +17,6 @@ # node-elm-compiler [![Version](https://img.shields.io/npm/v/node-elm-compiler.svg)](https://www.npmjs.com/package/node-elm-compiler) [![Travis build Status](https://travis-ci.org/rtfeldman/node-elm-compiler.svg?branch=master)](http://travis-ci.org/rtfeldman/node-elm-compiler) [![AppVeyor build status](https://ci.appveyor.com/api/projects/status/xv83jcomgb81i1iu/branch/master?svg=true)](https://ci.appveyor.com/project/rtfeldman/node-elm-compiler/branch/master)
 
+## 4.1.5
+
+Clean up temporary directories more safely.
+
 ## 4.1.4
@@ -19,0 +23,0 @@

test/compile.js

@@ -7,2 +7,3 @@ var chai = require("chai")
 var _ = require("lodash");
+var temp = require("temp");
 
@@ -132,2 +133,28 @@ chai.use(spies);
   });
+
+
+  it("works when run multiple times", function () {
+    var opts = {
+      yes: true,
+      verbose: true,
+      cwd: fixturesDir
+    };
+
+    var runCompile = function() {
+      // running compileToString right after each other can cause raceconditions
+      // the problem is that temp.cleanupSync removes all tempfiles
+      compiler.compileToString(prependFixturesDir("Parent.elm"), opts)
+      var compilePromise = compiler.compileToString(prependFixturesDir("Parent.elm"), opts)
+
+      return compilePromise.then(function(result) {
+        var desc = "Expected elm-make to return the result of the compilation";
+        expect(result.toString(), desc).to.be.a('string');
+      });
+    };
+    var promises = [];
+    for (var i = 0; i < 10; i++) {
+      promises.push(runCompile());
+    }
+    return Promise.all(promises);
+  });
 });
@@ -134,0 +161,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

30494

increased by5.05%

Lines of code

595

increased by3.66%

Number of lines in readme file

86

increased by4.88%

No dependency changes