node-github-webhook - npm Package Compare versions

Comparing version 1.0.1 to 1.0.2

index.js

@@ -20,27 +20,2 @@ /**
 function create(options) {
-  function findHandler(url, arr) {
-    var ret = arr[0]
-    for (var i = 0; i < arr.length; i++) {
-      if (url.split('?').shift() === arr[i].path)
-        ret = arr[i]
-    }
-    return ret
-  }
-
-  if (Array.isArray(options)) {
-    options = findHandler(req.url, options)
-  }
-
-  if (!isObject(options))
-      throw new TypeError('must provide an options object')
-
-  if (typeof options.path !== 'string')
-    throw new TypeError('must provide a \'path\' option')
-  
-  if (typeof options.secret !== 'string')
-    throw new TypeError('must provide a \'secret\' option')
-  
-  if (Array.isArray(options.events) && options.events.indexOf('*') === -1)
-    throw new TypeError('must provide an events array')
-
   // make it an EventEmitter, sort of
@@ -62,2 +37,31 @@ handler.__proto__ = EventEmitter.prototype
 
+    function findHandler(url, arr) {
+      var ret = arr[0]
+      for (var i = 0; i < arr.length; i++) {
+        if (url.split('?').shift() === arr[i].path)
+          ret = arr[i]
+      }
+      return ret
+    }
+
+    function checkType(options) {
+      if (!isObject(options))
+          throw new TypeError('must provide an options object')
+
+      if (typeof options.path !== 'string')
+        throw new TypeError('must provide a \'path\' option')
+      
+      if (typeof options.secret !== 'string')
+        throw new TypeError('must provide a \'secret\' option')
+      
+      if (Array.isArray(options.events) && options.events.indexOf('*') === -1)
+        throw new TypeError('must provide an events array')
+    }
+
+    if (Array.isArray(options)) {
+      options = findHandler(req.url, options)
+    }
+
+    checkType(options)
+
     if (req.url.split('?').shift() !== options.path)
@@ -64,0 +68,0 @@ return callback()

package.json

 {
   "name": "node-github-webhook",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Github Webhooks handler based on Node.js. Support multiple handlers.",
@@ -5,0 +5,0 @@ "main": "index.js",

README.md

@@ -12,2 +12,4 @@ # node-github-webhook
 
+Notice: Github Webhooks setting: `Content-type` must be `application/json`.
+
 ### Usage
@@ -14,0 +16,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

8461

increased by2.46%

Lines of code

92

increased by3.37%

Number of lines in readme file

56

increased by3.7%

No dependency changes