node-gyp - npm Package Compare versions

Comparing version 1.0.2 to 1.0.3

lib/build.js

@@ -225,4 +225,5 @@
       if (jobs) {
-        if (!isNaN(parseInt(jobs, 10))) {
-          argv.push('/m:' + parseInt(jobs, 10))
+        var j = parseInt(jobs, 10)
+        if (!isNaN(j) && j > 0) {
+          argv.push('/m:' + j)
         } else if (jobs.toUpperCase() === 'MAX') {
@@ -238,5 +239,6 @@ argv.push('/m:' + require('os').cpus().length)
       if (jobs) {
-        if (!isNaN(parseInt(jobs, 10))) {
+        var j = parseInt(jobs, 10)
+        if (!isNaN(j) && j > 0) {
           argv.push('--jobs')
-          argv.push(parseInt(jobs, 10))
+          argv.push(j)
         } else if (jobs.toUpperCase() === 'MAX') {
@@ -243,0 +245,0 @@ argv.push('--jobs')

lib/node-gyp.js

@@ -183,4 +183,4 @@
   if (!opts) opts = {}
-  if (!opts.silent && !opts.customFds) {
-    opts.customFds = [ 0, 1, 2 ]
+  if (!opts.silent && !opts.stdio) {
+    opts.stdio = [ 0, 1, 2 ]
   }
@@ -187,0 +187,0 @@ var cp = child_process.spawn(command, args, opts)

lib/rebuild.js

@@ -12,3 +12,3 @@
       { name: 'clean', args: [] }
-    , { name: 'configure', args: [] }
+    , { name: 'configure', args: argv }
     , { name: 'build', args: [] }
@@ -15,0 +15,0 @@ )

package.json

@@ -13,3 +13,3 @@ {
   ],
-  "version": "1.0.2",
+  "version": "1.0.3",
   "installVersion": 9,
@@ -31,3 +31,3 @@ "author": "Nathan Rajlich <[e-mail]> (http://tootallnate.net)",
     "nopt": "2 || 3",
-    "npmlog": "0",
+    "npmlog": "0 || 1",
     "osenv": "0",
@@ -34,0 +34,0 @@ "request": "2",

README.md

@@ -47,3 +47,3 @@ node-gyp
     * Windows 7/8:
-      * Microsoft Visual Studio C++ 2012 for Windows Desktop ([Express][msvc2012] version works well)
+      * Microsoft Visual Studio C++ 2012/13 for Windows Desktop ([Express][msvc2012] version works well)
 
@@ -86,3 +86,3 @@ If you have multiple Python versions installed, you can identify which Python
 __Note__: The `configure` step looks for the `binding.gyp` file in the current
-directory to processs. See below for instructions on creating the `binding.gyp` file.
+directory to process. See below for instructions on creating the `binding.gyp` file.
 
@@ -101,3 +101,3 @@ Now you will have either a `Makefile` (on Unix platforms) or a `vcxproj` file
 __Note:__ To create a _Debug_ build of the bindings file, pass the `--debug` (or
-`-d`) switch when running the either `configure` or `build` command.
+`-d`) switch when running either the `configure`, `build` or `rebuild` command.
 
@@ -126,4 +126,5 @@
 
-Some additional resources for writing `gyp` files:
+Some additional resources for addons and writing `gyp` files:
 
+ * ["Going Native" a nodeschool.io tutorial](http://nodeschool.io/#goingnative)
  * ["Hello World" node addon example](https://github.com/joyent/node/tree/master/test/addons/hello-world)
@@ -143,5 +144,5 @@ * [gyp user documentation](http://code.google.com/p/gyp/wiki/GypUserDocumentation)
 | `build`       | Invokes `make`/`msbuild.exe` and builds the native addon
-| `clean`       | Removes any the `build` dir if it exists
+| `clean`       | Removes the `build` directory if it exists
 | `configure`   | Generates project build files for the current platform
-| `rebuild`     | Runs "clean", "configure" and "build" all in a row
+| `rebuild`     | Runs `clean`, `configure` and `build` all in a row
 | `install`     | Installs node development header files for the given version
@@ -148,0 +149,0 @@ | `list`        | Lists the currently installed node development file versions

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 3 instances in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1393628

increased by0.01%

Lines of code

1320

increased by0.15%

Number of lines in readme file

181

increased by0.56%

Number of low supply chain risk alerts

19

decreased by-13.64%

Dependency changes

• + Addedare-we-there-yet@1.0.6(transitive)

• + Addedcore-util-is@1.0.3(transitive)

• + Addeddelegates@1.0.0(transitive)

• + Addedgauge@1.2.7(transitive)

• + Addedhas-unicode@2.0.1(transitive)

• + Addedisarray@1.0.0(transitive)

• + Addedlodash.pad@4.5.1(transitive)

• + Addedlodash.padend@4.6.1(transitive)

• + Addedlodash.padstart@4.6.1(transitive)

• + Addednpmlog@1.2.1(transitive)

• + Addedprocess-nextick-args@2.0.1(transitive)

• + Addedreadable-stream@2.3.8(transitive)

• + Addedsafe-buffer@5.1.2(transitive)

• + Addedstring_decoder@1.1.1(transitive)

• + Addedutil-deprecate@1.0.2(transitive)

• - Removednpmlog@0.1.1(transitive)

• - Removedsafe-buffer@5.2.1(transitive)

• Updatednpmlog@0 || 1