node-horseman
Advanced tools
Comparing version 1.2.1 to 1.2.2
# Change Log | ||
All notable changes to this project will be documented in this file. | ||
##1.2.2 - 2015-02-26 | ||
### Fixed | ||
- Phantom options, like `loadImages` were not being honored in 1.2.1. | ||
##1.2.1 - 2015-02-26 | ||
@@ -5,0 +9,0 @@ ### Changed |
@@ -46,37 +46,20 @@ var clone = require('clone'); | ||
debug('.setup() creating phantom instance on'); | ||
/* | ||
var phantomArgs = [ | ||
"--ignore-ssl-errors=" + this.options.ignoreSSLErrors, | ||
"--load-images=" + this.options.loadImages, | ||
"--ssl-protocol=" + this.options.sslProtocol, | ||
"--web-security=" + this.options.webSecurity | ||
]; | ||
var phantomOptions = { | ||
'ignore-ssl-errors' : this.options.ignoreSSLErrors, | ||
'load-images' : this.options.loadImages, | ||
'ssl-protocol' : this.options.sslProtocol, | ||
'web-security' : this.options.webSecurity | ||
}; | ||
if (typeof this.options.proxy !== "undefined") { | ||
phantomArgs.push('--proxy='+this.options.proxy); | ||
phantomOptions.proxy = this.options.proxy; | ||
} | ||
if (typeof this.options.proxyType !== "undefined") { | ||
phantomArgs.push('--proxy-type='+this.options.proxyType); | ||
phantomOptions['proxy-type'] = this.options.proxyType; | ||
} | ||
if (typeof this.options.proxyAuth !== "undefined") { | ||
phantomArgs.push('--proxy-auth='+this.options.proxyAuth); | ||
phantomOptions['proxy-auth'] = this.options.proxyAuth; | ||
} | ||
phantomArgs.push({ | ||
port: this.options.port, | ||
dnodeOpts : { weak : this.options.weak } | ||
}); | ||
phantomArgs.unshift( function( instance ){ | ||
self.phantom = instance; | ||
self.phantom.createPage( function( page ){ | ||
self.page = page; | ||
self.page.set("viewportSize",{ | ||
width: 1200, | ||
height: 800 | ||
}); | ||
self.pause.unpause("creating"); | ||
}); | ||
}); | ||
*/ | ||
phantom.create( function( err, instance ){ | ||
@@ -126,3 +109,3 @@ | ||
}); | ||
}); | ||
}, { parameters : phantomOptions }); | ||
@@ -129,0 +112,0 @@ this.pause.pause("creating"); |
{ | ||
"name": "node-horseman", | ||
"version": "1.2.1", | ||
"version": "1.2.2", | ||
"description": "Run PhantomJS from Node", | ||
@@ -5,0 +5,0 @@ "repository": { |
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
145092
1793