node-notifier - npm Package Compare versions

Comparing version 7.0.2 to 8.0.0

CHANGELOG.md

 # Changelog
 
+### `v8.0.0`
+
+Breaking changes:
+
+- Expire time for notify-send is made to match macOS and Windows with default time of 10 seconds. The API is changed to take seconds as input and converting it to milliseconds before passing it on to notify-send. See [#341](https://github.com/mikaelbr/node-notifier/pull/341).
+
 ### `v7.0.2`
@@ -4,0 +10,0 @@

lib/utils.js

@@ -165,2 +165,8 @@ var shellwords = require('shellwords');
 
+  if (options.timeout === false) {
+    delete options.timeout;
+  }
+  if (options.wait === true) {
+    options['expire-time'] = 5; // 5 seconds default time (multipled below)
+  }
   for (var key in options) {
@@ -173,2 +179,7 @@ if (key === 'message' || key === 'title') continue;
   }
+  if (typeof options['expire-time'] === 'undefined') {
+    options['expire-time'] = 10 * 1000; // 10 sec timeout by default
+  } else if (typeof options['expire-time'] === 'number') {
+    options['expire-time'] = options['expire-time'] * 1000; // notify send uses milliseconds
+  }
 
@@ -175,0 +186,0 @@ return options;

package.json

 {
   "name": "node-notifier",
-  "version": "7.0.2",
+  "version": "8.0.0",
   "description": "A Node.js module for sending notifications on native Mac, Windows (post and pre 8) and Linux (or Growl as fallback)",
@@ -41,3 +41,3 @@ "main": "index.js",
   "devDependencies": {
-    "eslint": "^7.5.0",
+    "eslint": "^7.6.0",
     "eslint-config-semistandard": "^15.0.1",
@@ -50,3 +50,3 @@ "eslint-config-standard": "^14.1.1",
     "husky": "^4.2.5",
-    "jest": "^26.1.0",
+    "jest": "^26.4.0",
     "lint-staged": "^10.2.11",
@@ -60,3 +60,3 @@ "prettier": "^2.0.5"
     "shellwords": "^0.1.1",
-    "uuid": "^8.2.0",
+    "uuid": "^8.3.0",
     "which": "^2.0.2"
@@ -63,0 +63,0 @@ },

README.md

@@ -73,3 +73,3 @@ # node-notifier [![NPM version][npm-image]][npm-url] [![Build Status][travis-image]][travis-url]
   },
-  function(err, response) {
+  function (err, response) {
     // Response is response from notification
@@ -79,7 +79,7 @@ }
 
-notifier.on('click', function(notifierObject, options, event) {
+notifier.on('click', function (notifierObject, options, event) {
   // Triggers if `wait: true` and user clicks notification
 });
 
-notifier.on('timeout', function(notifierObject, options) {
+notifier.on('timeout', function (notifierObject, options) {
   // Triggers if `wait: true` and notification closes
@@ -184,3 +184,3 @@ });
   },
-  function(error, response, metadata) {
+  function (error, response, metadata) {
     console.log(response, metadata);
@@ -284,3 +284,3 @@ }
   },
-  function(error, response) {
+  function (error, response) {
     console.log(response);
@@ -340,3 +340,3 @@ }
   },
-  function(error, response) {
+  function (error, response) {
     console.log(response);
@@ -363,6 +363,8 @@ }
 
+  wait: false, // Defaults no exipre time set. If true expire time of 5 seconds is used
+  timeout: 10, // Alias for expire-time, time etc. Time before notify-send expires. Defaults to 10 seconds.
+
   // .. and other notify-send flags:
   'app-name': 'node-notifier',
   urgency: undefined,
-  time: undefined,
   category: undefined,
@@ -369,0 +371,0 @@ hint: undefined

No alert changes

Improved metrics

Total package byte prevSize

5687619

increased by0.02%

Lines of code

1056

increased by1.05%

Number of lines in readme file

462

increased by0.43%

Dependency changes

• Updateduuid@^8.3.0