node-pre-gyp - npm Package Compare versions

Comparing version 0.6.35 to 0.6.36

CHANGELOG.md

 # node-pre-gyp changelog
 
-## 0.6.34
+## 0.6.36
 
+ - Removed the running of `testbinary` during install. Because this was regressed for so long, it is too dangerous to re-enable by default. Developers needing validation can call `node-pre-gyp testbinary` directory.
+ - Fixed regression in v0.6.35 for electron installs (now skipping binary validation which is not yet supported for electron)
+
+## 0.6.35
+
  - No longer recommending `npm ls` in `prepublish` (#291)
  - Fixed testbinary command (#283) @szdavid92
+
+## 0.6.34
+
  - Added new node versions to crosswalk, including v8
@@ -8,0 +16,0 @@ - Upgraded deps to latest versions, started using `^` instead of `~` for all deps.

lib/install.js

@@ -13,4 +13,2 @@ "use strict";
 var versioning = require('./util/versioning.js');
-var testbinary = require('./testbinary.js');
-var clean = require('./clean.js');
 
@@ -151,3 +149,2 @@ var npgVersion = 'unknown';
     var should_do_source_build = source_build === package_json.name || (source_build === true || source_build === 'true');
-    var no_rollback = gyp.opts.hasOwnProperty('rollback') && gyp.opts.rollback === false;
     if (should_do_source_build) {
@@ -183,25 +180,5 @@ log.info('build','requesting source compile');
             if (found && !update_binary) {
-                testbinary(gyp, argv, function(err) {
-                    if (err) {
-                        console.error('['+package_json.name+'] ' + err.message);
-                        log.error("Testing local pre-built binary failed, attempting to re-download");
-                        place_binary(from,to,opts,function(err) {
-                            if (err) {
-                                if (should_do_fallback_build) {
-                                    print_fallback_error(err,opts,package_json);
-                                    return do_build(gyp,argv,callback);
-                                } else {
-                                    return callback(err);
-                                }
-                            } else {
-                                console.log('['+package_json.name+'] Success: "' + binary_module + '" is reinstalled via remote');
-                                return callback();
-                            }
-                        });
-                    } else {
-                        console.log('['+package_json.name+'] Success: "' + binary_module + '" already installed');
-                        console.log('Pass --update-binary to reinstall or --build-from-source to recompile');
-                        return callback();
-                    }
-                });
+                console.log('['+package_json.name+'] Success: "' + binary_module + '" already installed');
+                console.log('Pass --update-binary to reinstall or --build-from-source to recompile');
+                return callback();
             } else {
@@ -216,23 +193,4 @@ if (!update_binary) log.info('check','checked for "' + binary_module + '" (not found)');
                     } else {
-                        testbinary(gyp, argv, function(err) {
-                            if (err) {
-                                if (no_rollback) {
-                                    return callback(err);
-                                }
-                                gyp.opts.silent_clean = true;
-                                clean(gyp, argv, function(error) {
-                                    if (error) console.log(error);
-                                    if (should_do_fallback_build) {
-                                        console.error('['+package_json.name+'] ' + err.message);
-                                        log.error("Testing pre-built binary failed, attempting to source compile");
-                                        return do_build(gyp,argv,callback);
-                                    } else {
-                                        return callback(err);
-                                    }
-                                });
-                            } else {
-                                console.log('['+package_json.name+'] Success: "' + binary_module + '" is installed via remote');
-                                return callback();
-                            }
-                        });
+                        console.log('['+package_json.name+'] Success: "' + binary_module + '" is installed via remote');
+                        return callback();
                     }
@@ -239,0 +197,0 @@ });

lib/testbinary.js

@@ -20,5 +20,11 @@ "use strict";
     var opts = versioning.evaluate(package_json, gyp.opts);
+    // skip validation for runtimes we don't explicitly support (like electron)
+    if (opts.runtime &&
+        opts.runtime !== 'node-webkit' &&
+        opts.runtime !== 'node') {
+        return callback();
+    }
+    var nw = (opts.runtime && opts.runtime === 'node-webkit');
     // ensure on windows that / are used for require path
     var binary_module = opts.module.replace(/\\/g, '/');
-    var nw = (opts.runtime && opts.runtime === 'node-webkit');
     if ((process.arch != opts.target_arch) ||
@@ -25,0 +31,0 @@ (process.platform != opts.target_platform)) {

package.json

 {
   "name": "node-pre-gyp",
   "description": "Node.js native addon binary install tool",
-  "version" : "0.6.35",
+  "version" : "0.6.36",
   "keywords": [
@@ -6,0 +6,0 @@ "native",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

121955

decreased by-1.43%

Lines of code

2767

decreased by-1.28%

No dependency changes