node-pre-gyp - npm Package Compare versions

Comparing version 0.6.36 to 0.6.37

CHANGELOG.md

 # node-pre-gyp changelog
 
+## 0.6.37
+
+ - Solved one part of #276: now now deduce the node ABI from the major version for node >= 2 even when not stored in the abi_crosswalk.json
+ - Fixed docs to avoid mentioning the deprecated and dangerous `prepublish` in package.json (#291)
+ - Add new node versions to crosswalk
+ - Ported tests to use tape instead of mocha
+ - Got appveyor tests passing by downgrading npm and node-gyp
+
 ## 0.6.36
@@ -4,0 +12,0 @@

lib/util/abi_crosswalk.json

@@ -1250,2 +1250,6 @@ {
   },
+  "4.8.4": {
+    "node_abi": 46,
+    "v8": "4.5"
+  },
   "5.0.0": {
@@ -1419,2 +1423,18 @@ "node_abi": 47,
   },
+  "6.11.0": {
+    "node_abi": 48,
+    "v8": "5.1"
+  },
+  "6.11.1": {
+    "node_abi": 48,
+    "v8": "5.1"
+  },
+  "6.11.2": {
+    "node_abi": 48,
+    "v8": "5.1"
+  },
+  "6.11.3": {
+    "node_abi": 48,
+    "v8": "5.1"
+  },
   "7.0.0": {
@@ -1484,6 +1504,46 @@ "node_abi": 51,
   },
+  "7.10.1": {
+    "node_abi": 51,
+    "v8": "5.5"
+  },
   "8.0.0": {
     "node_abi": 57,
     "v8": "5.8"
+  },
+  "8.1.0": {
+    "node_abi": 57,
+    "v8": "5.8"
+  },
+  "8.1.1": {
+    "node_abi": 57,
+    "v8": "5.8"
+  },
+  "8.1.2": {
+    "node_abi": 57,
+    "v8": "5.8"
+  },
+  "8.1.3": {
+    "node_abi": 57,
+    "v8": "5.8"
+  },
+  "8.1.4": {
+    "node_abi": 57,
+    "v8": "5.8"
+  },
+  "8.2.0": {
+    "node_abi": 57,
+    "v8": "5.8"
+  },
+  "8.2.1": {
+    "node_abi": 57,
+    "v8": "5.8"
+  },
+  "8.3.0": {
+    "node_abi": 57,
+    "v8": "6.0"
+  },
+  "8.4.0": {
+    "node_abi": 57,
+    "v8": "6.0"
   }
 }

lib/util/versioning.js

@@ -20,2 +20,10 @@ "use strict";
 
+var major_versions = {};
+Object.keys(abi_crosswalk).forEach(function(v) {
+    var major = v.split('.')[0];
+    if (!major_versions[major]) {
+        major_versions[major] = v;
+    }
+});
+
 function get_electron_abi(runtime, target_version) {
@@ -140,2 +148,9 @@ if (!runtime) {
                     }
+                } else if (major >= 2) {
+                    // look for last release that is the same major version
+                    if (major_versions[major]) {
+                        cross_obj = abi_crosswalk[major_versions[major]];
+                        console.log('Warning: node-pre-gyp could not find exact match for ' + target_version);
+                        console.log('Warning: but node-pre-gyp successfully choose ' + major_versions[major] + ' as ABI compatible target');
+                    }
                 } else if (major === 0) { // node.js
@@ -142,0 +157,0 @@ if (target_parts[1] % 2 === 0) { // for stable/even node.js series

package.json

 {
   "name": "node-pre-gyp",
   "description": "Node.js native addon binary install tool",
-  "version" : "0.6.36",
+  "version" : "0.6.37",
   "keywords": [
@@ -30,2 +30,3 @@ "native",
     "semver": "^5.3.0",
+    "tape": "^4.6.3",
     "tar": "^2.2.1",
@@ -36,3 +37,2 @@ "tar-pack": "^3.4.0"
     "aws-sdk": "^2.28.0",
-    "mocha": "^3.2.0",
     "retire": "^1.2.12",
@@ -45,11 +45,10 @@ "jshint": "^2.9.4"
     "undef": true,
-    "unused": true,
-    "noarg": true,
-    "mocha": true
+    "unused": false,
+    "noarg": true
   },
   "scripts": {
-    "pretest": "retire -n && jshint test/build.test.js test/s3_setup.test.js test/versioning.test.js",
+    "pretest": "jshint test/build.test.js test/s3_setup.test.js test/versioning.test.js",
     "update-crosswalk": "node scripts/abi_crosswalk.js",
-    "test": "jshint lib lib/util scripts bin/node-pre-gyp && mocha -R spec --timeout 500000"
+    "test": "jshint lib lib/util scripts bin/node-pre-gyp && tape test/*test.js"
   }
 }

README.md

@@ -127,3 +127,3 @@ # node-pre-gyp
  - You should add `"bundledDependencies":["node-pre-gyp"]`. This ensures that when you publish your module that the correct version of node-pre-gyp will be included in the `node_modules` folder during publishing. Then when uses install your module `node-pre-gyp` will already be present. Without this your module will not be safely installable for downstream applications that have a depedency on node-pre-gyp in the npm tree (without bundling npm deduping might break the install when node-pre-gyp is moved in flight)
- - Your `scripts` section should optionally add `"prepublish": "npm ls"` to ensure the right node-pre-gyp version is bundled before publishing your module. If node-pre-gyp is missing or an old version is present then this will catch that error before you publish a broken package.
+ - Your `scripts` section should optionally add `"prepublishOnly": "npm ls"` to ensure the right node-pre-gyp version is bundled before publishing your module. If node-pre-gyp is missing or an old version is present then this will catch that error before you publish a broken package.
  - Your `scripts` section should override the `install` target with `"install": "node-pre-gyp install --fallback-to-build"`. This allows node-pre-gyp to be used instead of the default npm behavior of always source compiling with `node-gyp` directly.
@@ -130,0 +130,0 @@ - Your package.json should contain a `binary` section describing key properties you provide to allow node-pre-gyp to package optimally. They are detailed below.

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Dev dependency count

3

decreased by-25%

Lines of code

2841

increased by2.67%

Worsened metrics

Total package byte prevSize

121698

decreased by-0.21%

Dependency count

10

increased by11.11%

Number of package files

30

decreased by-6.25%

Dependency changes

• + Addedtape@^4.6.3

• + Added@ljharb/resumer@0.0.1(transitive)

• + Added@ljharb/through@2.3.13(transitive)

• + Addedarray-buffer-byte-length@1.0.1(transitive)

• + Addedarraybuffer.prototype.slice@1.0.3(transitive)

• + Addedavailable-typed-arrays@1.0.7(transitive)

• + Addedcall-bind@1.0.7(transitive)

• + Addeddata-view-buffer@1.0.1(transitive)

• + Addeddata-view-byte-length@1.0.1(transitive)

• + Addeddata-view-byte-offset@1.0.0(transitive)

• + Addeddeep-equal@1.1.2(transitive)

• + Addeddefine-data-property@1.1.4(transitive)

• + Addeddefine-properties@1.2.1(transitive)

• + Addeddefined@1.0.1(transitive)

• + Addeddotignore@0.1.2(transitive)

• + Addedes-abstract@1.23.3(transitive)

• + Addedes-define-property@1.0.0(transitive)

• + Addedes-errors@1.3.0(transitive)

• + Addedes-object-atoms@1.0.0(transitive)

• + Addedes-set-tostringtag@2.0.3(transitive)

• + Addedes-to-primitive@1.2.1(transitive)

• + Addedfor-each@0.3.3(transitive)

• + Addedfunction-bind@1.1.2(transitive)

• + Addedfunction.prototype.name@1.1.6(transitive)

• + Addedfunctions-have-names@1.2.3(transitive)

• + Addedget-intrinsic@1.2.4(transitive)

• + Addedget-symbol-description@1.0.2(transitive)

• + Addedglobalthis@1.0.4(transitive)

• + Addedgopd@1.0.1(transitive)

• + Addedhas@1.0.4(transitive)

• + Addedhas-bigints@1.0.2(transitive)

• + Addedhas-property-descriptors@1.0.2(transitive)

• + Addedhas-proto@1.0.3(transitive)

• + Addedhas-symbols@1.0.3(transitive)

• + Addedhas-tostringtag@1.0.2(transitive)

• + Addedhasown@2.0.2(transitive)

• + Addedinternal-slot@1.0.7(transitive)

• + Addedis-arguments@1.1.1(transitive)

• + Addedis-array-buffer@3.0.4(transitive)

• + Addedis-bigint@1.0.4(transitive)

• + Addedis-boolean-object@1.1.2(transitive)

• + Addedis-callable@1.2.7(transitive)

• + Addedis-core-module@2.15.1(transitive)

• + Addedis-data-view@1.0.1(transitive)

• + Addedis-date-object@1.0.5(transitive)

• + Addedis-negative-zero@2.0.3(transitive)

• + Addedis-number-object@1.0.7(transitive)

• + Addedis-regex@1.1.4(transitive)

• + Addedis-shared-array-buffer@1.0.3(transitive)

• + Addedis-string@1.0.7(transitive)

• + Addedis-symbol@1.0.4(transitive)

• + Addedis-typed-array@1.1.13(transitive)

• + Addedis-weakref@1.0.2(transitive)

• + Addedisarray@2.0.5(transitive)

• + Addedmock-property@1.0.3(transitive)

• + Addedobject-inspect@1.12.31.13.2(transitive)

• + Addedobject-is@1.1.6(transitive)

• + Addedobject-keys@1.1.1(transitive)

• + Addedobject.assign@4.1.5(transitive)

• + Addedpath-parse@1.0.7(transitive)

• + Addedpossible-typed-array-names@1.0.0(transitive)

• + Addedregexp.prototype.flags@1.5.2(transitive)

• + Addedresolve@1.22.8(transitive)

• + Addedsafe-array-concat@1.1.2(transitive)

• + Addedsafe-regex-test@1.0.3(transitive)

• + Addedset-function-length@1.2.2(transitive)

• + Addedset-function-name@2.0.2(transitive)

• + Addedside-channel@1.0.6(transitive)

• + Addedstring.prototype.trim@1.2.9(transitive)

• + Addedstring.prototype.trimend@1.0.8(transitive)

• + Addedstring.prototype.trimstart@1.0.8(transitive)

• + Addedsupports-preserve-symlinks-flag@1.0.0(transitive)

• + Addedtape@4.17.0(transitive)

• + Addedtyped-array-buffer@1.0.2(transitive)

• + Addedtyped-array-byte-length@1.0.1(transitive)

• + Addedtyped-array-byte-offset@1.0.2(transitive)

• + Addedtyped-array-length@1.0.6(transitive)

• + Addedunbox-primitive@1.0.2(transitive)

• + Addedwhich-boxed-primitive@1.0.2(transitive)

• + Addedwhich-typed-array@1.1.15(transitive)