node-pre-gyp - npm Package Compare versions

Comparing version 0.9.0 to 0.9.1

CHANGELOG.md

 # node-pre-gyp changelog
 
+## 0.9.1
+
+- Fixed regression (in v0.9.0) with support for http redirects @allenluce (https://github.com/mapbox/node-pre-gyp/pull/361)
+
 ## 0.9.0
@@ -4,0 +8,0 @@

lib/clean.js

@@ -12,2 +12,3 @@ "use strict";
 var napi = require('./util/napi.js');
+var path = require('path');
 
@@ -19,9 +20,15 @@ function clean (gyp, argv, callback) {
     var to_delete = opts.module_path;
-    exists(to_delete, function(found) {
-        if (found) {
-            if (!gyp.opts.silent_clean) console.log('['+package_json.name+'] Removing "%s"', to_delete);
-            return rm(to_delete, callback);
-        }
-        return callback();
-    });
+    if (!to_delete) {
+        return callback(new Error("module_path is empty, refusing to delete"));
+    } else if (path.normalize(to_delete) == path.normalize(process.cwd())) {
+        return callback(new Error("module_path is not set, refusing to delete"));
+    } else {
+        exists(to_delete, function(found) {
+            if (found) {
+                if (!gyp.opts.silent_clean) console.log('['+package_json.name+'] Removing "%s"', to_delete);
+                return rm(to_delete, callback);
+            }
+            return callback();
+        });
+    }
 }

lib/install.js

@@ -35,3 +35,4 @@ "use strict";
           'User-Agent': 'node-pre-gyp (v' + npgVersion + ', ' + envVersionInfo + ')'
-        }
+        },
+        follow_max: 10,
     };
@@ -108,4 +109,8 @@
 
-        req.on('response', function(res) {
-            if (res.statusCode !== 200) {
+      req.on('response', function(res) {
+           // ignore redirects, needle handles these automatically.
+           if (res.headers.hasOwnProperty('location') && res.headers.location !== '') {
+             return;
+           }
+           if (res.statusCode !== 200) {
                 badDownload = true;
@@ -112,0 +117,0 @@ var err = new Error(res.statusCode + ' status code downloading tarball ' + from);

lib/util/napi.js

@@ -103,3 +103,3 @@ "use strict";
 	var napi_build_versions = [];
-	if (package_json.binary.napi_versions) { // remove duplicates
+	if (package_json.binary && package_json.binary.napi_versions) { // remove duplicates
 		package_json.binary.napi_versions.forEach(function(napi_version) {
@@ -106,0 +106,0 @@ if (!napi_build_versions.includes(napi_version)) napi_build_versions.push(napi_version);

lib/util/versioning.js

@@ -215,3 +215,3 @@ "use strict";
         }
-        if (!o || o[p] === undefined) {
+        if (!o || o[p] === undefined || o[p] === "") {
             missing.push('binary.' + p);
@@ -218,0 +218,0 @@ }

package.json

 {
   "name": "node-pre-gyp",
   "description": "Node.js native addon binary install tool",
-  "version": "0.9.0",
+  "version": "0.9.1",
   "keywords": [
@@ -35,6 +35,7 @@ "native",
   "devDependencies": {
-    "tape": "^4.6.3",
     "aws-sdk": "^2.28.0",
+    "jshint": "^2.9.5",
+    "nock": "^9.2.3",
     "retire": "^1.2.12",
-    "jshint": "^2.9.5"
+    "tape": "^4.6.3"
   },
@@ -49,3 +50,3 @@ "jshintConfig": {
   "scripts": {
-    "pretest": "jshint test/build.test.js test/s3_setup.test.js test/versioning.test.js lib lib/util scripts bin/node-pre-gyp",
+    "pretest": "jshint test/build.test.js test/s3_setup.test.js test/versioning.test.js test/fetch.test.js lib lib/util scripts bin/node-pre-gyp",
     "update-crosswalk": "node scripts/abi_crosswalk.js",
@@ -52,0 +53,0 @@ "test": "jshint lib lib/util scripts bin/node-pre-gyp && tape test/*test.js"

README.md

@@ -292,3 +292,3 @@ # node-pre-gyp
 
-Using `node-pre-gyp` with N-API projects requires a handful of additional congiguration values and imposes some additional requirements. 
+Using `node-pre-gyp` with N-API projects requires a handful of additional configuration values and imposes some additional requirements. 
 
@@ -362,3 +362,3 @@ The most significant difference is that an N-API module can be coded to target multiple  N-API versions. Therefore, an N-API module must declare in its `package.json` file which N-API versions the module is designed to run against. In addition, since multiple builds may be required for a single module, path and file names must be specified in way that avoids naming conflicts.
 
-These values are present for use in the `binding.gyp` file and may be used as `{napi_version}` and `{node_abi_napi}` for text substituion in the `package.json` file. 
+These values are present for use in the `binding.gyp` file and may be used as `{napi_version}` and `{node_abi_napi}` for text substituion in the `binary` properties of the `package.json` file. 
 
@@ -365,0 +365,0 @@ ## S3 Hosting

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

138873

decreased by-27.94%

Dev dependency count

5

increased by25%

Number of package files

31

decreased by-11.43%

Lines of code

3215

decreased by-31.97%

No dependency changes