node-red-contrib-deconz - npm Package Compare versions

Comparing version 1.2.1 to 1.3.0

examples/Bulb to homekit.json

@@ -68,3 +68,2 @@ [
     "port": "80",
-    "apikey": "F18D851E01",
     "ws_port": "443",
@@ -71,0 +70,0 @@ "secure": false

examples/Light ColorTemperature.json

@@ -68,3 +68,2 @@ [
     "port": "80",
-    "apikey": "F18D851E01",
     "ws_port": "443",
@@ -71,0 +70,0 @@ "secure": false

examples/Light RGBW.json

@@ -156,3 +156,2 @@ [
     "port": "80",
-    "apikey": "02BA6A91A3",
     "ws_port": "443",
@@ -159,0 +158,0 @@ "secure": false,

examples/Thermostat.json

@@ -487,3 +487,2 @@ [
     "port": "80",
-    "apikey": "AAAAAAAAA",
     "ws_port": "443",
@@ -490,0 +489,0 @@ "secure": false,

examples/Xiaomi sensor with battery.json

@@ -150,3 +150,2 @@ [
     "port": "80",
-    "apikey": "F18D851E01",
     "ws_port": "443",
@@ -153,0 +152,0 @@ "secure": false

nodes/locales/en-US/server.json

@@ -17,4 +17,5 @@ {
     "tip": {
-        "deploy": "<b>Important:</b> deploy server node to get devices list"
+        "deploy": "<b>Important:</b> deploy server node to get devices list",
+        "secured_apikey_warning_message_update": "<b>Important:</b> Please click on update to save the API key in the vault"
     }
 }

nodes/out.js

@@ -147,10 +147,11 @@ const DeconzHelper = require('../lib/DeconzHelper.js');
                     if (deviceMeta !== undefined && deviceMeta && "device_id" in deviceMeta) {
+                        let url = 'http://' + node.server.ip + ':' + node.server.port + '/api/' + node.server.credentials.secured_apikey;
 						if (command == 'scene'){ // make a new URL for recalling the scene
 							var groupid = ((node.config.device).split('group_').join(''));
-                            var url = 'http://' + node.server.ip + ':' + node.server.port + '/api/' + node.server.apikey + '/groups/' + groupid + '/scenes/' + payload + '/recall';
+                            url += '/groups/' + groupid + '/scenes/' + payload + '/recall';
 						} else if ((/group_/g).test(node.config.device)) {
                             var groupid = ((node.config.device).split('group_').join(''));
-                            var url = 'http://' + node.server.ip + ':' + node.server.port + '/api/' + node.server.apikey + '/groups/' + groupid + '/action';
+                            url += '/groups/' + groupid + '/action';
                         } else {
-                            var url = 'http://' + node.server.ip + ':' + node.server.port + '/api/' + node.server.apikey + '/lights/' + deviceMeta.device_id + '/state';
+                            url += '/lights/' + deviceMeta.device_id + '/state';
                         }
@@ -165,4 +166,6 @@ var post = {};
                         }
-                        if (parseInt(config.transitionTime) >= 0) {
-                            post['transitiontime'] = parseInt(config.transitionTime);
+
+						let transitionTime = RED.util.evaluateNodeProperty(config.transitionTime, config.transitionTimeType || "num", node, message);
+                        if (parseInt(transitionTime) >= 0) {
+                            post['transitiontime'] = parseInt(transitionTime);
                         }
@@ -169,0 +172,0 @@

nodes/server.js

@@ -18,3 +18,7 @@ var request = require('request');
             node.secure = n.secure || false;
-            node.apikey = n.apikey;
+
+            // Prior 1.2.0 the apikey was not stored in credentials
+            if(node.credentials.secured_apikey === undefined && n.apikey !== undefined){
+                node.credentials.secured_apikey = n.apikey;
+            }
             node.devices = {};
@@ -56,3 +60,3 @@
 
-                var url = "http://" + node.ip + ":" + node.port + "/api/" + node.apikey;
+                var url = "http://" + node.ip + ":" + node.port + "/api/" + node.credentials.secured_apikey;
                 // node.log('discoverDevices: Requesting: ' + url);
@@ -251,4 +255,8 @@
 
-    RED.nodes.registerType('deconz-server', ServerNode, {});
+    RED.nodes.registerType('deconz-server', ServerNode, {
+        credentials:{
+            secured_apikey: {type: "text"}
+        }
+    });
 };
 

package.json

 {
   "author": {
     "name": "Andrey Popov",
-    "email": "[e-mail]"
+    "email": "[e-mail]",
+    "url": "https://github.com/andreypopov"
   },
+  "maintainers": [
+    {
+      "name": "Zehir",
+      "email": "[e-mail]",
+      "url": "https://github.com/Zehir"
+    }
+  ],
   "bugs": {
-    "url": "https://github.com/andreypopov/node-red-contrib-deconz/issues/"
+    "url": "https://github.com/deconz-community/node-red-contrib-deconz/issues/"
   },
@@ -16,3 +24,3 @@ "dependencies": {
   "description": "deCONZ connectivity nodes for node-red",
-  "homepage": "https://github.com/andreypopov/node-red-contrib-deconz",
+  "homepage": "https://github.com/deconz-community/node-red-contrib-deconz",
   "keywords": [
@@ -39,5 +47,5 @@ "deconz",
     "type": "git",
-    "url": "git+https://github.com/andreypopov/node-red-contrib-deconz.git"
+    "url": "git+https://github.com/deconz-community/node-red-contrib-deconz.git"
   },
-  "version": "1.2.1"
+  "version": "1.3.0"
 }

README.md

@@ -0,1 +1,11 @@
+# Changes!
+
+Hi, I'm Dennis the Community Manager of deCONZ. I've tried to invite Andrey over but he mentioned that he stopped development. I've asked him to transfer the repository so we can advance on it later. @Zehir wil probably take over development sometime soon! Please bear with us.
+
+I'd like to thank @Andreypopov for his contributions!
+
+# @andreypopov WILL NOT SUPPORT THIS PROJECT ANYMORE. 
+I don't use deconz. Moved to https://flows.nodered.org/node/node-red-contrib-zigbee2mqtt <br>
+and the most advanced project (in beta) https://flows.nodered.org/node/node-red-contrib-spruthub
+
 # node-red-contrib-deconz
@@ -25,3 +35,2 @@ Node-Red Nodes for deCONZ connectivity.
 
-# Support
-Developing and supporting this plugin needs time and efforts. Appreciate your support on [Patreon](https://www.patreon.com/bePatron?u=12661781). Here, you can sign up to be a member and help support my project.
+

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1209121

increased by0.18%

Lines of code

6712

increased by0.07%

Number of lines in readme file

36

increased by33.33%

Worsened metrics

Number of package files

76

decreased by-2.56%

Number of medium supply chain risk alerts

3

increased by50%

No dependency changes