node-red-contrib-sun-position - npm Package Compare versions

Comparing version 1.0.13 to 1.0.14

CHANGELOG.md

 # node-red-contrib-sun-position
 
+#### 1.0.14:  BugFix
+
+- blind-control + clock-time
+  - fixed bug for day of the week (String/integer format)
+
 #### 1.0.13:  BugFix
@@ -4,0 +9,0 @@

nodes/clock-timer.js

@@ -427,3 +427,3 @@ /********************************************
         prepareRules(node, msg, tempData);
-        // node.debug(`checkRules now=${dNow.toISOString()}, nowNr=${nowNr}, rules.count=${node.rules.count}, rules.lastUntil=${node.rules.lastUntil}`); // {colors:true, compact:10}
+        // node.debug(`checkRules now=${dNow.toISOString()}, nowNr=${nowNr}, dayNr=${dayNr}, dateNr=${dateNr}, monthNr=${monthNr}, dayId=${dayId}, rules.count=${node.rules.count}, rules.lastUntil=${node.rules.lastUntil}`);
 
@@ -915,2 +915,3 @@ /**
                     rule.timeDays = rule.timeDays.split(',');
+                    rule.timeDays = rule.timeDays.map( e => parseInt(e) );
                 }
@@ -922,2 +923,3 @@
                     rule.timeMonths = rule.timeMonths.split(',');
+                    rule.timeMonths = rule.timeMonths.map( e => parseInt(e) );
                 }
@@ -924,0 +926,0 @@

nodes/within-time-switch.js

@@ -128,3 +128,3 @@ /********************************************
 
-        if (config.timeDays && config.timeDays !== '*' && !config.timeDays.includes(dNow.getDay())) {
+        if (config.timeDays && !config.timeDays.includes(dNow.getDay())) {
             node.debug('invalid Day config. today=' + dNow.getDay() + ' timeDays=' + util.inspect(config.timeDays, Object.getOwnPropertyNames(config.timeDays)));
@@ -134,9 +134,6 @@ result.warn = RED._('within-time-switch.errors.invalid-day');
         }
-        if (config.timeMonths && config.timeMonths !== '*') {
-            const mn = config.timeMonths.split(',');
-            if (!mn.includes(dNow.getMonth())) {
-                node.debug('invalid Day config. today=' + dNow.getMonth() + ' timeMonths=' + util.inspect(config.timeMonths, Object.getOwnPropertyNames(config.timeMonths)));
-                result.warn = RED._('within-time-switch.errors.invalid-month');
-                return result;
-            }
+        if (config.timeMonths && !config.timeMonths.includes(dNow.getDay())) {
+            node.debug('invalid Month config. today=' + dNow.getMonth() + ' timeMonths=' + util.inspect(config.timeMonths, Object.getOwnPropertyNames(config.timeMonths)));
+            result.warn = RED._('within-time-switch.errors.invalid-month');
+            return result;
         }
@@ -334,6 +331,18 @@ if (config.timedatestart || config.timedateend) {
             throw new Error('No valid days given! Please check settings!');
+        } else if (!config.timeDays || config.timeDays === '*') {
+            config.timeDays = null;
+        } else {
+            config.timeDays = config.timeDays.split(',');
+            config.timeDays = config.timeDays.map( e => parseInt(e) );
         }
+
         if (config.timeMonths === '') {
             throw new Error('No valid month given! Please check settings!');
+        } else if (!config.timeMonths || config.timeMonths === '*') {
+            config.timeMonths = null;
+        } else {
+            config.timeMonths = config.timeMonths.split(',');
+            config.timeMonths = config.timeMonths.map( e => parseInt(e) );
         }
+
         if (this.timeOnlyEvenDays && this.timeOnlyOddDays) {
@@ -340,0 +349,0 @@ this.timeOnlyEvenDays = false;

package.json

 {
   "name": "node-red-contrib-sun-position",
-  "version": "1.0.13",
+  "version": "1.0.14",
   "description": "NodeRED nodes to get sun and moon position",
@@ -5,0 +5,0 @@ "keywords": [

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1703952

increased by0.04%

Lines of code

11727

increased by0.09%

Worsened metrics

Number of lines in readme file

800

decreased by-0.12%

No dependency changes