node-sass - npm Package Compare versions

Comparing version 0.9.5-rc1 to 0.9.5

lib/cli.js

@@ -165,3 +165,3 @@ var watch = require('node-watch'),
 
-  if (!options.dest) {
+  if (!options.dest && (process.stdout.isTTY || process.env.isTTY)) {
     var suffix = '.css';
@@ -168,0 +168,0 @@ if (/\.css$/.test(options.src)) {

lib/render.js

@@ -31,3 +31,3 @@ var sass = require('../sass'),
 
-    if (options.stdout || (!process.stdout.isTTY && !process.env.isTTY)) {
+    if (options.stdout || (!options.dest && (!process.stdout.isTTY || !process.env.isTTY))) {
       emitter.emit('log', css);
@@ -34,0 +34,0 @@ return done();

package.json

@@ -5,3 +5,3 @@ {
   "description": "wrapper around libsass",
-  "version": "0.9.5-rc1",
+  "version": "0.9.5",
   "homepage": "https://github.com/sass/node-sass",
@@ -42,11 +42,11 @@ "keywords": [
   "dependencies": {
-    "chalk": "~0.4.0",
-    "mkdirp": "~0.3.5",
-    "mocha": "~1.18.2",
+    "chalk": "~0.5.1",
+    "mkdirp": "~0.5.0",
+    "mocha": "~1.21.4",
     "nan": "~1.3.0",
     "node-watch": "~0.3.4",
-    "object-assign": "^0.3.1",
-    "shelljs": "~0.2.6",
-    "sinon": "~1.9.1",
-    "node-sass-middleware": "~0.2.0",
+    "object-assign": "~1.0.0",
+    "shelljs": "~0.3.0",
+    "sinon": "~1.10.3",
+    "node-sass-middleware": "~0.3.0",
     "yargs": "~1.3.1",
@@ -61,4 +61,4 @@ "get-stdin": "~3.0.0"
     "mocha-lcov-reporter": "^0.0.1",
-    "object-assign": "^0.3.1"
+    "object-assign": "^1.0.0"
   }
 }

README.md

@@ -9,4 +9,3 @@ # node-sass
 [![devDependency Status](https://david-dm.org/sass/node-sass/dev-status.svg?theme=shields.io)](https://david-dm.org/sass/node-sass#info=devDependencies)
-[![Coverage Status](http://img.shields.io/coveralls/sass/node-sass.svg)](https://coveralls.io/r/sass/node-sass)
-[![Gitter chat](https://badges.gitter.im/sass/node-sass.png)](https://gitter.im/sass/node-sass)
+[![Gitter chat](http://img.shields.io/badge/gitter-sass/node--sass-brightgreen.svg)](https://gitter.im/sass/node-sass)
 
@@ -37,2 +36,4 @@ Node-sass is a library that provides binding for Node.js to [libsass], the C version of the popular stylesheet preprocessor, Sass.
 
+Compiling versions 0.9.4 and above on Windows machines requires [Visual Studio 2013 WD](http://www.visualstudio.com/downloads/download-visual-studio-vs#d-express-windows-desktop). If you have multiple VS versions, use ```npm install``` with the ```--msvs_version=2013``` flag.
+
 ## Usage
@@ -39,0 +40,0 @@

sass.js

@@ -73,2 +73,6 @@ var path = require('path');
 
+  if (options.imagePath && typeof options.imagePath !== 'string') {
+    throw new Error('imagePath needs to be a string');
+  }
+
   return {
@@ -75,0 +79,0 @@ file: options.file || null,

test/cli.js

@@ -37,2 +37,3 @@ var path   = require('path'),
   it('should read data from stdin', function(done) {
+    this.timeout(6000);
     var src = fs.createReadStream(sampleScssPath);
@@ -50,2 +51,19 @@ var emitter = spawn(cliPath, ['--stdout']);
 
+  it('should write to disk when using --output', function(done) {
+    this.timeout(6000);
+    var src = fs.createReadStream(sampleScssPath);
+    var emitter = spawn(cliPath, ['--output', sampleCssOutputPath], {
+      stdio: [null, 'ignore', null]
+    });
+
+    emitter.on('close', function() {
+      fs.exists(sampleCssOutputPath, function(exists) {
+        assert(exists);
+        fs.unlink(sampleCssOutputPath, done);
+      });
+    });
+
+    src.pipe(emitter.stdin);
+  });
+
   it('should print help when run with no arguments', function(done) {
@@ -61,2 +79,3 @@ var env = assign(process.env, { isTTY: true });
   it('should compile sample.scss as sample.css', function(done) {
+    this.timeout(6000);
     var env = assign(process.env, { isTTY: true });
@@ -79,2 +98,3 @@ var resultPath = path.join(__dirname, 'sample.css');
   it('should compile sample.scss to ../out.css', function(done) {
+    this.timeout(6000);
     var env = assign(process.env, { isTTY: true });
@@ -81,0 +101,0 @@ var resultPath = path.resolve(__dirname, '../out.css');

test/test.js

@@ -138,2 +138,17 @@ var sass = process.env.NODESASS_COVERAGE ? require('../sass-coverage') : require('../sass');
   });
+  it('should throw on non-string path', function(done) {
+    try {
+      sass.render({
+        file: path.resolve(__dirname, 'image_path.scss'),
+        imagePath: ['/path/to/images'],
+        success: function () {},
+        error: function () {}
+      });
+    } catch(err) {
+      assert(err);
+      return done();
+    }
+
+    done(new Error('did not throw'));
+  });
 });
@@ -140,0 +155,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Copyleft License

License

(Experimental) Copyleft license information was found.

Found 1 instance in 1 package

Mixed license

License

(Experimental) Package contains multiple licenses.

Found 1 instance in 1 package

Non-permissive License

License

(Experimental) A license not known to be considered permissive was found.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Copyleft License

License

(Experimental) Copyleft license information was found.

Found 1 instance in 1 package

Mixed license

License

(Experimental) Package contains multiple licenses.

Found 1 instance in 1 package

Non-permissive License

License

(Experimental) A license not known to be considered permissive was found.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

20178884

increased by220.92%

Number of package files

1748

increased by1057.62%

Lines of code

22472

increased by1796.37%

Number of lines in readme file

287

increased by0.35%

Worsened metrics

Number of low supply chain risk alerts

19

increased by11.76%

Number of medium supply chain risk alerts

4

increased by33.33%

Dependency changes

• + Addedescape-string-regexp@1.0.5(transitive)

• - Removedansi-styles@1.0.0(transitive)

• - Removedchalk@0.4.0(transitive)

• - Removedcommander@2.0.0(transitive)

• - Removeddebug@4.3.7(transitive)

• - Removeddiff@1.0.7(transitive)

• - Removedgrowl@1.7.0(transitive)

• - Removedhas-color@0.1.7(transitive)

• - Removedmkdirp@0.3.5(transitive)

• - Removedmocha@1.18.2(transitive)

• - Removedms@2.1.3(transitive)

• - Removednode-sass@0.9.6(transitive)

• - Removednode-sass-middleware@0.2.0(transitive)

• - Removedobject-assign@0.3.1(transitive)

• - Removedshelljs@0.2.6(transitive)

• - Removedsinon@1.9.1(transitive)

• - Removedstrip-ansi@0.1.1(transitive)

• Updatedchalk@~0.5.1

• Updatedmkdirp@~0.5.0

• Updatedmocha@~1.21.4

• Updatednode-sass-middleware@~0.3.0

• Updatedobject-assign@~1.0.0

• Updatedshelljs@~0.3.0

• Updatedsinon@~1.10.3