node-sass - npm Package Compare versions

Comparing version 4.7.2 to 4.8.1

CHANGELOG.md

@@ -0,1 +1,21 @@
+## v4.8.1
+
+https://github.com/sass/node-sass/releases/tag/v4.8.1
+
+## v4.8.0
+
+https://github.com/sass/node-sass/releases/tag/v4.8.0
+
+## v4.7.2
+
+https://github.com/sass/node-sass/releases/tag/v4.7.2
+
+## v4.7.1
+
+https://github.com/sass/node-sass/releases/tag/v4.7.1
+
+## v4.7.0
+
+https://github.com/sass/node-sass/releases/tag/v4.7.0
+
 ## v4.6.1
@@ -2,0 +22,0 @@

lib/extensions.js

@@ -10,3 +10,3 @@ /*!
   path = require('path'),
-  defaultBinaryPath = path.join(__dirname, '..', 'vendor'),
+  defaultBinaryDir = path.join(__dirname, '..', 'vendor'),
   trueCasePathSync = require('true-case-path');
@@ -79,2 +79,3 @@
     case 59: return 'Node.js 9.x';
+    case 63: return 'Node.js 10.x';
     default: return false;
@@ -130,3 +131,3 @@ }
 function getInstalledBinaries() {
-  return fs.readdirSync(defaultBinaryPath);
+  return fs.readdirSync(getBinaryDir());
 }
@@ -251,2 +252,34 @@
 /**
+ * Get binary dir.
+ * If environment variable SASS_BINARY_DIR,
+ * .npmrc variable sass_binary_dir or
+ * process argument --sass-binary-dir is provided,
+ * select it by appending binary name, otherwise
+ * use default binary dir.
+ * Once the primary selection is made, check if
+ * callers wants to throw if file not exists before
+ * returning.
+ *
+ * @api public
+ */
+
+function getBinaryDir() {
+  var binaryDir;
+
+  if (getArgument('--sass-binary-dir')) {
+    binaryDir = getArgument('--sass-binary-dir');
+  } else if (process.env.SASS_BINARY_DIR) {
+    binaryDir = process.env.SASS_BINARY_DIR;
+  } else if (process.env.npm_config_sass_binary_dir) {
+    binaryDir = process.env.npm_config_sass_binary_dir;
+  } else if (pkg.nodeSassConfig && pkg.nodeSassConfig.binaryDir) {
+    binaryDir = pkg.nodeSassConfig.binaryDir;
+  } else {
+    binaryDir = defaultBinaryDir;
+  }
+
+  return binaryDir;
+}
+
+/**
  * Get binary path.
@@ -277,3 +310,3 @@ * If environment variable SASS_BINARY_PATH,
   } else {
-    binaryPath = path.join(defaultBinaryPath, getBinaryName().replace(/_(?=binding\.node)/, '/'));
+    binaryPath = path.join(getBinaryDir(), getBinaryName().replace(/_(?=binding\.node)/, '/'));
   }
@@ -422,2 +455,3 @@
 module.exports.getBinaryName = getBinaryName;
+module.exports.getBinaryDir = getBinaryDir;
 module.exports.getBinaryPath = getBinaryPath;
@@ -424,0 +458,0 @@ module.exports.getBinaryCachePath = getBinaryCachePath;

package.json

 {
   "name": "node-sass",
-  "version": "4.7.2",
-  "libsass": "3.5.0.beta.2",
+  "version": "4.8.1",
+  "libsass": "3.5.0",
   "description": "Wrapper around libsass",
@@ -68,3 +68,3 @@ "license": "MIT",
     "mkdirp": "^0.5.1",
-    "nan": "^2.3.2",
+    "nan": "^2.9.2",
     "node-gyp": "^3.3.1",
@@ -87,5 +87,5 @@ "npmlog": "^4.0.0",
     "rimraf": "^2.5.2",
-    "sass-spec": "3.5.0-1",
+    "sass-spec": "^3.5.0",
     "unique-temp-dir": "^1.0.0"
   }
 }

README.md

@@ -460,3 +460,3 @@ # node-sass
 
-[@jking90](https://github.com/jking90) wrote a [DocPad](http://docpad.org/) plugin that compiles `.scss` files using node-sass: <https://github.com/jking90/docpad-plugin-nodesass>
+[@10xLaCroixDrinker](https://github.com/10xLaCroixDrinker) wrote a [DocPad](http://docpad.org/) plugin that compiles `.scss` files using node-sass: <https://github.com/10xLaCroixDrinker/docpad-plugin-nodesass>
 
@@ -571,2 +571,3 @@ ### Duo.js extension
 SASS_BINARY_PATH | sass_binary_path | --sass-binary-path | path
+SASS_BINARY_DIR  | sass_binary_dir  | --sass-binary-dir  | path
 
@@ -573,0 +574,0 @@ These parameters can be used as environment variable:

scripts/install.js

@@ -54,3 +54,3 @@ /*!
   try {
-    request(url, downloadOptions(), function(err, response) {
+    request(url, downloadOptions(), function(err, response, buffer) {
       if (err) {
@@ -62,3 +62,10 @@ reportError(err);
         console.log('Download complete');
-        cb();
+
+        if (successful(response)) {
+          fs.createWriteStream(dest)
+            .on('error', cb)
+            .end(buffer, cb);
+        } else {
+          cb();
+        }
       }
@@ -70,6 +77,2 @@ })
 
-      if (successful(response)) {
-        response.pipe(fs.createWriteStream(dest));
-      }
-
       // The `progress` is true by default. However if it has not
@@ -76,0 +79,0 @@ // been explicitly set it's `undefined` which is considered

scripts/util/downloadoptions.js

@@ -21,3 +21,4 @@ var proxy = require('./proxy'),
       'User-Agent': userAgent(),
-    }
+    },
+    encoding: null,
   };
@@ -24,0 +25,0 @@

src/libsass/.github/CONTRIBUTING.md

@@ -8,14 +8,14 @@ # Contributing to LibSass
 
-LibSass is a library that implements a [sass language] [8] compiler. As such it does not directly interface with end users (frontend developers).
+LibSass is a library that implements a [sass language][8] compiler. As such it does not directly interface with end users (frontend developers).
 For direct contributions to the LibSass code base you will need to have at least a rough idea of C++, we will not lie about that.
 But there are other ways to contribute to the progress of LibSass. All contributions are done via github pull requests.
 
-You can also contribute to the LibSass [documentation] [9] or provide additional [spec tests] [10] (and we will gladly point you in the
+You can also contribute to the LibSass [documentation][9] or provide additional [spec tests][10] (and we will gladly point you in the
 direction for corners that lack test coverage). Foremost we rely on good and concise bug reports for issues the spec tests do not yet catch.
 
 ## Precheck: My Sass isn't compiling
-- [ ] Check if you can reproduce the issue via [SourceMap Inspector] [5] (updated regularly).
-- [ ] Validate official ruby sass compiler via [SassMeister] [6] produces your expected result.
-- [ ] Search for similar issue in [LibSass] [1] and [node-sass] [2] (include closed tickets)
-- [ ] Optionally test your code directly with [sass] [7] or [sassc] [3] ([installer] [4])
+- [ ] Check if you can reproduce the issue via [SourceMap Inspector][5] (updated regularly).
+- [ ] Validate official ruby sass compiler via [SassMeister][6] produces your expected result.
+- [ ] Search for similar issue in [LibSass][1] and [node-sass][2] (include closed tickets)
+- [ ] Optionally test your code directly with [sass][7] or [sassc][3] ([installer][4])
 
@@ -51,3 +51,3 @@ ## Precheck: My build/install fails
 Important is that someone else can get the test case up and running to reproduce it locally. For this
-we urge you to verify that your sample yields the expected result by testing it via [SassMeister] [6]
+we urge you to verify that your sample yields the expected result by testing it via [SassMeister][6]
 or directly via ruby sass or node-sass (or any other libsass implementor) before submitting your bug
@@ -54,0 +54,0 @@ report. Once you verified all of the above, you may use the template below to file your bug report.

src/libsass/.github/ISSUE_TEMPLATE.md

@@ -1,4 +0,13 @@
-### Title: Be as meaningful as possible in 60 chars if possible
+[todo]: # (Title: Be as meaningful as possible)
+[todo]: # (Title: Try to use 60 or less chars)
 
-input.scss
+[todo]: # (This is only a template!)
+[todo]: # (remove unneeded bits)
+[todo]: # (use github preview!)
+
+## input.scss
+
+[todo]: # (always test and report with scss syntax)
+[todo]: # (use sass only when results differ from scss)
+
 ```scss
@@ -10,3 +19,7 @@ test {
 
-[libsass 3.5.5] [1]
+## Actual results
+
+[todo]: # (update version info!)
+
+[libsass 3.X.y][1]
 ```css
@@ -17,3 +30,7 @@ test {
 
-ruby sass 3.4.21
+## Expected result
+
+[todo]: # (update version info!)
+
+ruby sass 3.X.y
 ```css
@@ -24,9 +41,17 @@ test {
 
+[todo]: # (update version info!)
+[todo]: # (example for node-sass!)
+
 version info:
 ```cmd
 $ node-sass --version
-node-sass       3.3.3   (Wrapper)       [JavaScript]
-libsass         3.2.5   (Sass Compiler) [C/C++]
+node-sass       3.X.y   (Wrapper)       [JavaScript]
+libsass         3.X.y   (Sass Compiler) [C/C++]
 ```
 
+[todo]: # (Go to http://libsass.ocbnet.ch/srcmap)
+[todo]: # (Enter your SCSS code and hit compile)
+[todo]: # (Click `bookmark` and replace the url)
+[todo]: # (link is used in actual results above)
+
 [1]: http://libsass.ocbnet.ch/srcmap/#dGVzdCB7CiAgY29udGVudDogYmFyOyB9Cg==

src/libsass/docs/api-doc.md

@@ -190,3 +190,3 @@ ## Introduction
 1. [Perl Example](https://github.com/sass/perl-libsass/blob/master/lib/CSS/Sass.xs)
-2. [Go Example](http://godoc.org/github.com/wellington/go-libsass#example-Context-Compile)
+2. [Go Example](https://godoc.org/github.com/wellington/go-libsass#example-Compiler--Stdin)
 3. [Node Example](https://github.com/sass/node-sass/blob/master/src/binding.cpp)
@@ -193,0 +193,0 @@

src/libsass/docs/api-value.md

 `Sass_Values` are used to pass values and their types between the implementer
 and LibSass. Sass knows various different value types (including nested arrays
 and hash-maps). If you implement a binding to another programming language, you
-have to find a way to [marshal] [1] (convert) `Sass_Values` between the target
+have to find a way to [marshal][1] (convert) `Sass_Values` between the target
 language and C. `Sass_Values` are currently only used by custom functions, but
@@ -6,0 +6,0 @@ it should also be possible to use them without a compiler context.

src/libsass/docs/build-on-windows.md

@@ -6,3 +6,3 @@ We support builds via MingGW and via Visual Studio Community 2013.
 
-First grab the latest [MinGW for windows] [1] installer. Once it is installed, you can click on continue or open the Installation Manager via `bin\mingw-get.exe`.
+First grab the latest [MinGW for windows][1] installer. Once it is installed, you can click on continue or open the Installation Manager via `bin\mingw-get.exe`.
 
@@ -12,5 +12,5 @@ You need to have the following components installed:
 
-Next we need to install [git for windows] [2]. You probably want to check the option to add it to the global path, but you do not need to install the unix tools.
+Next we need to install [git for windows][2]. You probably want to check the option to add it to the global path, but you do not need to install the unix tools.
 
-If you want to run the spec test-suite you also need [ruby] [3] and a few gems available. Grab the [latest installer] [3] and make sure to add it the global path. Then install the missing gems:
+If you want to run the spec test-suite you also need [ruby][3] and a few gems available. Grab the [latest installer][3] and make sure to add it the global path. Then install the missing gems:
 
@@ -17,0 +17,0 @@ ```bash

src/libsass/docs/build-with-mingw.md

 ## Building LibSass with MingGW (makefiles)
 
-First grab the latest [MinGW for windows] [1] installer. Once it is installed, you can click on continue or open the Installation Manager via `bin\mingw-get.exe`.
+First grab the latest [MinGW for windows][1] installer. Once it is installed, you can click on continue or open the Installation Manager via `bin\mingw-get.exe`.
 
@@ -8,5 +8,5 @@ You need to have the following components installed:
 
-Next we need to install [git for windows] [2]. You probably want to check the option to add it to the global path, but you do not need to install the unix tools.
+Next we need to install [git for windows][2]. You probably want to check the option to add it to the global path, but you do not need to install the unix tools.
 
-If you want to run the spec test-suite you also need [ruby] [3] and a few gems available. Grab the [latest installer] [3] and make sure to add it the global path. Then install the missing gems:
+If you want to run the spec test-suite you also need [ruby][3] and a few gems available. Grab the [latest installer][3] and make sure to add it the global path. Then install the missing gems:
 
@@ -13,0 +13,0 @@ ```bash

src/libsass/docs/build.md

@@ -1,2 +0,2 @@
-`libsass` is only a library and does not do much on its own. You need an implementation that you can use from the [command line] [6]. Or some [[bindings|Implementations]] to use it within your favorite programming language. You should be able to get [`sassc`] [6] running by following the instructions in this guide.
+`libsass` is only a library and does not do much on its own. You need an implementation that you can use from the [command line][6]. Or some [bindings|Implementations][9] to use it within your favorite programming language. You should be able to get [`sassc`][6] running by following the instructions in this guide.
 
@@ -14,4 +14,4 @@ Before starting, see [setup dev environment](setup-environment.md).
 
-- [Building with makefiles] [1]
-- [Building with autotools] [2]
+- [Building with makefiles][1]
+- [Building with autotools][2]
 
@@ -22,4 +22,4 @@ ### Building on Windows (experimental)
 
-- [Building with MinGW] [3]
-- [Building with Visual Studio] [11]
+- [Building with MinGW][3]
+- [Building with Visual Studio][11]
 
@@ -30,3 +30,3 @@ ### Building on Max OS X (untested)
 
-- [Building on Mac OS X] [10]
+- [Building on Mac OS X][10]
 
@@ -37,3 +37,3 @@ ### Building a system library (experimental)
 
-- [Building shared system library] [4]
+- [Building shared system library][4]
 
@@ -53,3 +53,3 @@ Compiling with clang instead of gcc
 
-We constantly and automatically test `libsass` against the official [spec test-suite] [5]. To do this we need to have a test-runner (which is written in ruby) and a command-line tool ([`sassc`] [6]) to run the tests. Therefore we need to additionally compile `sassc`. To do this, the build files of all three projects need to work together. This may not have the same quality for all build flavors. You definitely need to have ruby (2.1?) installed (version 1.9 seems to cause problems at least on windows). You also need some gems installed:
+We constantly and automatically test `libsass` against the official [spec test-suite][5]. To do this we need to have a test-runner (which is written in ruby) and a command-line tool ([`sassc`][6]) to run the tests. Therefore we need to additionally compile `sassc`. To do this, the build files of all three projects need to work together. This may not have the same quality for all build flavors. You definitely need to have ruby (2.1?) installed (version 1.9 seems to cause problems at least on windows). You also need some gems installed:
 
@@ -75,3 +75,3 @@ ```bash
 
-We use two CI services to automatically test all commits against the latest [spec test-suite] [5].
+We use two CI services to automatically test all commits against the latest [spec test-suite][5].
 
@@ -78,0 +78,0 @@ - [LibSass on Travis-CI (linux)][7]

src/libsass/Readme.md

@@ -1,84 +0,93 @@
-LibSass
-=======
+LibSass - Sass compiler written in C++
+======================================
 
-by Aaron Leung ([@akhleung]), Hampton Catlin ([@hcatlin]), Marcel Greter ([@mgreter]) and Michael Mifsud ([@xzyfer])
+Currently maintained by Marcel Greter ([@mgreter]) and Michael Mifsud ([@xzyfer])  
+Originally created by Aaron Leung ([@akhleung]) and Hampton Catlin ([@hcatlin])
 
-[![Unix CI](https://travis-ci.org/sass/libsass.svg?branch=master)](https://travis-ci.org/sass/libsass)
-[![Windows CI](https://ci.appveyor.com/api/projects/status/github/sass/libsass?svg=true)](https://ci.appveyor.com/project/sass/libsass/branch/master)
-[![Bountysource](https://www.bountysource.com/badge/tracker?tracker_id=283068)](https://www.bountysource.com/trackers/283068-libsass?utm_source=283068&utm_medium=shield&utm_campaign=TRACKER_BADGE)
-[![Coverage Status](https://img.shields.io/coveralls/sass/libsass.svg)](https://coveralls.io/r/sass/libsass?branch=feature%2Ftest-travis-ci-3)
-[![Join us](https://libsass-slack.herokuapp.com/badge.svg)](https://libsass-slack.herokuapp.com/)
+[![Unix CI](https://travis-ci.org/sass/libsass.svg?branch=master)](https://travis-ci.org/sass/libsass "Travis CI")
+[![Windows CI](https://ci.appveyor.com/api/projects/status/github/sass/libsass?svg=true)](https://ci.appveyor.com/project/sass/libsass/branch/master "Appveyor CI")
+[![Coverage Status](https://img.shields.io/coveralls/sass/libsass.svg)](https://coveralls.io/r/sass/libsass?branch=feature%2Ftest-travis-ci-3 "Code coverage of spec tests")
+[![Percentage of issues still open](http://isitmaintained.com/badge/open/sass/libsass.svg)](http://isitmaintained.com/project/sass/libsass "Percentage of issues still open")
+[![Average time to resolve an issue](http://isitmaintained.com/badge/resolution/sass/libsass.svg)](http://isitmaintained.com/project/sass/libsass "Average time to resolve an issue")
+[![Bountysource](https://www.bountysource.com/badge/tracker?tracker_id=283068)](https://www.bountysource.com/trackers/283068-libsass?utm_source=283068&utm_medium=shield&utm_campaign=TRACKER_BADGE "Bountysource")
+[![Join us](https://libsass-slack.herokuapp.com/badge.svg)](https://libsass-slack.herokuapp.com/ "Slack communication channels")
 
-https://github.com/sass/libsass
 
-LibSass is just a library, but if you want to RUN LibSass,
-then go to https://github.com/sass/sassc or
-https://github.com/sass/sassc-ruby or
-[find your local implementer](docs/implementations.md).
+[LibSass](https://github.com/sass/libsass "LibSass GitHub Project") is just a library!
+If you want to use LibSass to compile Sass, you need an implementer. Some
+implementations are only bindings into other programming languages. But most also
+ship with a command line interface (CLI) you can use directly. There is also
+[SassC](https://github.com/sass/sassc), which is the official lightweight
+CLI tool built by the same people as LibSass.
 
-LibSass requires GCC 4.6+ or Clang/LLVM. If your OS is older, this version may not compile.
+### Excerpt of "sanctioned" implementations:
 
-On Windows, you need MinGW with GCC 4.6+ or VS 2013 Update 4+. It is also possible to build LibSass with Clang/LLVM on Windows.
+- https://github.com/sass/node-sass (Node.js)
+- https://github.com/sass/perl-libsass (Perl)
+- https://github.com/sass/libsass-python (Python)
+- https://github.com/wellington/go-libsass (Go)
+- https://github.com/sass/sassc-ruby (Ruby)
+- https://github.com/sass/libsass-net (C#)
+- https://github.com/medialize/sass.js (JS)
+- https://github.com/bit3/jsass (Java)
 
+This list does not say anything about the quality of either the listed or not listed [implementations](docs/implementations.md)!  
+The authors of the listed projects above are just known to work regularly together with LibSass developers.
+
 About
 -----
 
-LibSass is a C/C++ port of the Sass CSS precompiler. The original version was written in Ruby, but this version is meant for efficiency and portability.
+LibSass is a C++ port of the original Ruby Sass CSS compiler with a [C API](docs/api-doc.md).
+We coded LibSass with portability and efficiency in mind. You can expect LibSass to be a lot
+faster than Ruby Sass and on par or faster than the best alternative CSS compilers around.
 
-This library strives to be light, simple, and easy to build and integrate with a variety of platforms and languages.
-
 Developing
 ----------
 
-As you may have noticed, the LibSass repo itself has
-no executables and no tests. Oh noes! How can you develop???
+As noted above, the LibSass repository does not contain any binaries or other way to execute
+LibSass. Therefore, you need an implementer to develop LibSass. Easiest is to start with
+the official [SassC](http://github.com/sass/sassc) CLI wrapper. It is *guaranteed* to compile
+with the latest code in LibSass master, since it is also used in the CI process. There is no
+limitation here, as you may use any other LibSass implementer to test your LibSass branch!
 
-Well, luckily, [SassC](http://github.com/sass/sassc) is the official binary wrapper for
-LibSass and is *always* kept in sync. SassC is used by continous integration systems in
-LibSass repository. When developing LibSass, it is best to actually
-checkout SassC and develop in that directory with the SassC spec
-and tests there.
-
-We even run Travis tests for SassC!
-
-Tests
+Testing
 -------
 
-Since LibSass is a pure library, tests are run through the [SassSpec](https://github.com/sass/sass-spec) project using the [SassC](http://github.com/sass/sassc) driver.
+Since LibSass is a pure library, tests are run through the [Sass-Spec](https://github.com/sass/sass-spec)
+project using the [SassC](http://github.com/sass/sassc) CLI wrapper. To run the tests against LibSass while
+developing, you can run `./script/spec`. This will clone SassC and Sass-Spec under the project folder and
+then run the Sass-Spec test suite. You may want to update the clones to ensure you have the latest version.
+Note that the scripts in the `./script` folder are mainly intended for our CI needs.
 
-To run tests against LibSass while developing, you can run `./script/spec`. This will clone SassC and Sass-Spec under the project folder and then run the Sass-Spec test suite. You may want to update the clones to ensure you have the latest version.
+Building
+--------
 
-### DEBUG builds
+To build LibSass you need GCC 4.6+ or Clang/LLVM. If your OS is older, you may need to upgrade
+them first (or install clang as an alternative). On Windows, you need MinGW with GCC 4.6+ or VS 2013
+Update 4+. It is also possible to build LibSass with Clang/LLVM on Windows with various build chains
+and/or command line interpreters.
 
-Set the environment variable `DEBUG` to `1` to enable debug builds that can be debugged
-with `gdb`, `lldb` and others. E.g.: use `$ DEBUG=1 ./script/spec` to run the tests with
-a debug build.
+See the [build docs for further instructions](docs/build.md)!
 
-Library Usage
+Compatibility
 -------------
 
-While LibSass is a library primarily written in C++, it provides a simple
-C interface which should be used by most implementers. LibSass does not do
-much on its own without an implementer. This can be a command line tool, like
-[sassc](https://github.com/sass/sassc) or a [binding](docs/implementations.md)
-to your favorite programing language.
+Current LibSass 3.4 should be compatible with Sass 3.4. Please refer to the [sass compatibility
+page](http://sass-compatibility.github.io/) for a more detailed comparison. But note that there
+are still a few incomplete edges which we are aware of. Otherwise LibSass has reached a good level
+of stability, thanks to our ever growing [Sass-Spec test suite](https://github.com/sass/sass-spec).
 
-If you want to build or interface with LibSass, we recommend to check out the
-documentation pages about [building LibSass](docs/build.md) and
-the [C-API documentation](docs/api-doc.md).
-
 About Sass
 ----------
 
-Sass is a CSS pre-processor language to add on exciting, new,
-awesome features to CSS. Sass was the first language of its kind
-and by far the most mature and up to date codebase.
+Sass is a CSS pre-processor language to add on exciting, new, awesome features to CSS. Sass was
+the first language of its kind and by far the most mature and up to date codebase.
 
-Sass was originally concieved of by the co-creator of this library,
-Hampton Catlin ([@hcatlin]). Most of the language has been the result of years
-of work by Natalie Weizenbaum ([@nex3]) and Chris Eppstein ([@chriseppstein]).
+Sass was originally conceived of by the co-creator of this library, Hampton Catlin ([@hcatlin]).
+Most of the language has been the result of years of work by Natalie Weizenbaum ([@nex3]) and
+Chris Eppstein ([@chriseppstein]).
 
 For more information about Sass itself, please visit http://sass-lang.com
 
-Initial development of libsass by Aaron Leung and Hampton Catlin was supported by [Moovweb](http://www.moovweb.com).
+Initial development of LibSass by Aaron Leung and Hampton Catlin was supported by [Moovweb](http://www.moovweb.com).
 
@@ -88,8 +97,4 @@ Licensing
 
-Our MIT license is designed to be as simple, and liberal as possible.
+Our [MIT license](LICENSE) is designed to be as simple and liberal as possible.
 
-sass2scss was originally written by [Marcel Greter][@mgreter]
-and he happily agreed to have it merged into the project.
-
-
 [@hcatlin]: https://github.com/hcatlin
@@ -96,0 +101,0 @@ [@akhleung]: https://github.com/akhleung

test/downloadoptions.js

@@ -15,3 +15,4 @@ var assert = require('assert'),
             'User-Agent': ua(),
-          }
+          },
+          encoding: null,
         };
@@ -41,3 +42,4 @@
             'User-Agent': ua(),
-          }
+          },
+          encoding: null,
         };
@@ -66,3 +68,4 @@
             'User-Agent': ua(),
-          }
+          },
+          encoding: null,
         };
@@ -69,0 +72,0 @@

test/runtime.js

@@ -86,2 +86,33 @@ var assert = require('assert'),
 
+    describe('SASS_BINARY_DIR', function() {
+      beforeEach(function() {
+        process.argv.push('--sass-binary-dir', 'aaa');
+        process.env.SASS_BINARY_DIR = 'bbb';
+        process.env.npm_config_sass_binary_dir = 'ccc';
+        pkg.nodeSassConfig = { binaryDir: 'ddd' };
+      });
+
+      it('command line argument', function() {
+        assert.equal(sass.getBinaryDir(), 'aaa');
+      });
+
+      it('environment variable', function() {
+        process.argv = [];
+        assert.equal(sass.getBinaryDir(), 'bbb');
+      });
+
+      it('npm config variable', function() {
+        process.argv = [];
+        process.env.SASS_BINARY_DIR = null;
+        assert.equal(sass.getBinaryDir(), 'ccc');
+      });
+
+      it('package.json', function() {
+        process.argv = [];
+        process.env.SASS_BINARY_DIR = null;
+        process.env.npm_config_sass_binary_dir = null;
+        assert.equal(sass.getBinaryDir(), 'ddd');
+      });
+    });
+
     describe('SASS_BINARY_PATH', function() {
@@ -88,0 +119,0 @@ beforeEach(function() {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 2 instances in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

AI-detected potential code anomaly

Supply chain risk

AI has identified unusual behaviors that may pose a security risk.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1829050

increased by2.86%

Number of package files

334

increased by0.6%

Lines of code

5827

increased by1.09%

Number of lines in readme file

615

increased by0.16%

Worsened metrics

Number of low supply chain risk alerts

105

increased by8.25%

Dependency changes

• Updatednan@^2.9.2