node-statsd - npm Package Compare versions

Comparing version 0.0.6 to 0.0.7

lib/statsd.js

@@ -178,3 +178,5 @@ var dgram = require('dgram'),
   } else {
-    callback(null, 0);
+    if(typeof callback === 'function'){
+      callback(null, 0);
+    }
   }
@@ -181,0 +183,0 @@ };

package.json

 { "name" : "node-statsd"
 , "description" : "node client for Etsy'd StatsD server"
-, "version" : "0.0.6"
+, "version" : "0.0.7"
 , "author" : "Steve Ivy"
@@ -5,0 +5,0 @@ , "contributors": [ "Russ Bradberry <[e-mail]>" ]

test/test_statsd.js

@@ -41,4 +41,13 @@ var dgram = require('dgram'),
         socket = dgram.createSocket("udp4"),
-        buf = new Buffer(testFinished);
+        buf = new Buffer(testFinished),
+        callbackThrows = false;
 
+    // Regression test for "undefined is not a function" with missing callback on mock instance.
+    try {
+      statsd[method]('test', 1);
+    } catch(e) {
+      callbackThrows = true;
+    }
+    assert.ok(!callbackThrows);
+
     statsd[method]('test', 1, null, function(error, bytes){
@@ -45,0 +54,0 @@ assert.ok(!error);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

26208

increased by1.18%

Lines of code

574

increased by1.77%

No dependency changes