node-xlsx - npm Package Compare versions

Comparing version 0.7.1 to 0.7.2

lib/helpers.js

@@ -43,3 +43,3 @@ 'use strict';
       if (data[R][C] === null) {
-        continue;
+        continue; // eslint-disable-line
       }
@@ -57,4 +57,4 @@ var cell = { v: data[R][C] };
       } else {
-          cell.t = 's';
-        }
+        cell.t = 's';
+      }
       workSheet[cellRef] = cell;
@@ -61,0 +61,0 @@ }

lib/index.js

@@ -47,7 +47,4 @@ 'use strict';
   var excelData = _xlsx2.default.write(workBook, Object.assign({}, defaults, options));
-  if (!excelData) {
-    return false;
-  }
-  return new Buffer(excelData, 'binary');
+  return excelData instanceof Buffer ? excelData : new Buffer(excelData, 'binary');
 }
 //# sourceMappingURL=index.js.map

package.json

 {
   "name": "node-xlsx",
   "author": "Olivier Louvignes <[e-mail]>",
-  "version": "0.7.1",
+  "version": "0.7.2",
   "description": "NodeJS Excel files parser & builder",
@@ -23,18 +23,18 @@ "main": "lib/index.js",
   "devDependencies": {
-    "babel-cli": "^6.8.0",
-    "babel-eslint": "^6.0.4",
-    "babel-plugin-transform-class-properties": "^6.8.0",
+    "babel-cli": "^6.11.4",
+    "babel-eslint": "^6.1.2",
+    "babel-plugin-transform-class-properties": "^6.11.5",
     "babel-plugin-transform-function-bind": "^6.8.0",
     "babel-plugin-transform-object-rest-spread": "^6.8.0",
-    "babel-preset-es2015": "^6.6.0",
-    "babel-register": "^6.8.0",
-    "codeclimate-test-reporter": "^0.3.1",
-    "eslint": "^2.9.0",
-    "eslint-config-airbnb": "^8.0.0",
-    "eslint-plugin-import": "^1.6.1",
-    "eslint-plugin-jsx-a11y": "^1.0.4",
-    "expect": "^1.19.0",
-    "mocha": "^2.4.5",
-    "nyc": "^6.4.2",
-    "rimraf": "^2.5.2"
+    "babel-preset-es2015": "^6.13.2",
+    "babel-register": "^6.11.6",
+    "codeclimate-test-reporter": "^0.3.3",
+    "eslint": "^3.3.1",
+    "eslint-config-airbnb-base": "^5.0.2",
+    "eslint-plugin-import": "^1.13.0",
+    "eslint-plugin-jsx-a11y": "^2.1.0",
+    "expect": "^1.20.2",
+    "mocha": "^3.0.2",
+    "nyc": "^8.1.0",
+    "rimraf": "^2.5.4"
   },
@@ -41,0 +41,0 @@ "keywords": [

src/helpers.js

@@ -24,3 +24,3 @@ import XLSX from 'xlsx';
       if (data[R][C] === null) {
-        continue;
+        continue; // eslint-disable-line
       }
@@ -27,0 +27,0 @@ const cell = {v: data[R][C]};

src/index.js

@@ -28,6 +28,3 @@
   const excelData = XLSX.write(workBook, Object.assign({}, defaults, options));
-  if (!excelData) {
-    return false;
-  }
-  return new Buffer(excelData, 'binary');
+  return excelData instanceof Buffer ? excelData : new Buffer(excelData, 'binary');
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

35622

increased by0.23%

Worsened metrics

Lines of code

256

decreased by-2.29%

No dependency changes