nodemailer - npm Package Compare versions

Comparing version 0.3.2 to 0.3.3

lib/transport.js

@@ -71,4 +71,6 @@ var SendmailTransport = require("./engines/sendmail"),
     }else{
-        callback(null);
+        if(typeof callback == "function"){
+            callback(null);
+        }
     }
 };

lib/wellknown.js

@@ -50,4 +50,3 @@ /*
         host: "smtp.sendgrid.net",
-        secureConnection: true,
-        port: 465,
+        port: 587,
         requiresAuth: true
@@ -54,0 +53,0 @@ },

package.json

 {
     "name": "nodemailer",
     "description": "Easy to use module to send e-mails, supports unicode and SSL/TLS",
-    "version": "0.3.2",
+    "version": "0.3.3",
     "author" : "Andris Reinman",
@@ -35,5 +35,5 @@ "maintainers":[
     "engine": {
-        "node": ">=0.5"
+        "node": ">=0.4"
     },
     "keywords": ["e-mail", "mime", "email", "sendmail", "ses"]
 }

README.md

@@ -137,3 +137,3 @@ Nodemailer
  * **port** - port of the SMTP server (defaults to 25, not needed with `service`)
- * **secureConnection** - use SSL (default is `false`, not needed with `service`)
+ * **secureConnection** - use SSL (default is `false`, not needed with `service`). If you're using port 587 then keep `secureConnection` false, since the connection is started in insecure plain text mode and only later upgraded with STARTTLS  
  * **name** - the name of the client server (defaults to machine name)
@@ -140,0 +140,0 @@ * **auth** - authentication object as `{user:"...", pass:"..."}`

test/nodemailer.js

@@ -11,2 +11,53 @@ var testCase = require('nodeunit').testCase,
     }
+}
+
+exports["Transport close"] = {
+    "SMTP - Callback in transport.close": function(test){
+        var transport = nodemailer.createTransport("SMTP", {});
+        transport.close(function(){
+            test.ok(true);
+            test.done();
+        });
+    },
+    
+    "SMTP - No callback in transport.close": function(test){
+        var transport = nodemailer.createTransport("SMTP", {});
+        transport.close();
+        process.nextTick(function(){
+            test.ok(true);
+            test.done();
+        });
+    },
+    "Sendmail - Callback in transport.close": function(test){
+        var transport = nodemailer.createTransport("Sendmail", {});
+        transport.close(function(){
+            test.ok(true);
+            test.done();
+        });
+    },
+    
+    "Sendmail - No callback in transport.close": function(test){
+        var transport = nodemailer.createTransport("Sendmail", {});
+        transport.close();
+        process.nextTick(function(){
+            test.ok(true);
+            test.done();
+        });
+    },
+    "SES - Callback in transport.close": function(test){
+        var transport = nodemailer.createTransport("SES", {});
+        transport.close(function(){
+            test.ok(true);
+            test.done();
+        });
+    },
+    
+    "SES - No callback in transport.close": function(test){
+        var transport = nodemailer.createTransport("SES", {});
+        transport.close();
+        process.nextTick(function(){
+            test.ok(true);
+            test.done();
+        });
+    }
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

566438

increased by0.31%

Lines of code

1966

increased by2.5%

No dependency changes