nodemailer - npm Package Compare versions

Comparing version 4.3.0 to 4.3.1

CHANGELOG.md

 # CHANGELOG
 
+## 4.3.1 2017-10-25
+
+- Fixed a confict with Electron.js where timers do not have unref method
+
 ## 4.3.0 2017-10-23
@@ -4,0 +8,0 @@

lib/ses-transport/index.js

@@ -126,3 +126,9 @@ 'use strict';
         this.sendingRateTTL = setTimeout(() => this._checkRatedQueue(), now - delay);
-        this.sendingRateTTL.unref();
+
+        try {
+            this.sendingRateTTL.unref();
+        } catch (E) {
+            // Ignore. Happens on envs with non-node timer implementation
+        }
+
         return false;
@@ -129,0 +135,0 @@ }

lib/smtp-pool/pool-resource.js

@@ -113,3 +113,4 @@ 'use strict';
                 returned = true;
-                setTimeout(() => {
+
+                let timer = setTimeout(() => {
                     if (returned) {
@@ -125,3 +126,9 @@ return;
                     callback(err);
-                }, 1000).unref();
+                }, 1000);
+
+                try {
+                    timer.unref();
+                } catch (E) {
+                    // Ignore. Happens on envs with non-node timer implementation
+                }
             });
@@ -128,0 +135,0 @@

lib/smtp-transport/index.js

@@ -182,3 +182,4 @@ 'use strict';
                 returned = true;
-                setTimeout(() => {
+
+                let timer = setTimeout(() => {
                     if (returned) {
@@ -194,3 +195,9 @@ return;
                     callback(err);
-                }, 1000).unref();
+                }, 1000);
+
+                try {
+                    timer.unref();
+                } catch (E) {
+                    // Ignore. Happens on envs with non-node timer implementation
+                }
             });
@@ -197,0 +204,0 @@

package.json

 {
     "name": "nodemailer",
-    "version": "4.3.0",
+    "version": "4.3.1",
     "description": "Easy as cake e-mail sending from your Node.js applications",
@@ -13,3 +13,5 @@ "main": "lib/nodemailer.js",
     },
-    "keywords": ["Nodemailer"],
+    "keywords": [
+        "Nodemailer"
+    ],
     "author": "Andris Reinman",
@@ -16,0 +18,0 @@ "license": "MIT",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

506225

increased by0.12%

Lines of code

10786

increased by0.13%

No dependency changes