nuka-carousel - npm Package Compare versions

Comparing version 4.7.1 to 4.7.2

CHANGELOG.md

 # Nuka Changelog
 
+## 4.7.1 (2020-09-08)
+
+- [#706](https://github.com/FormidableLabs/nuka-carousel/pull/706) Add a more descriptive explanation about wrapAround
+- [#707](https://github.com/FormidableLabs/nuka-carousel/pull/707) Push fresh yarn.lock
+- [#716](https://github.com/FormidableLabs/nuka-carousel/pull/716) Update types for missing slideOffset, zoomScale
+- [#717](https://github.com/FormidableLabs/nuka-carousel/pull/717) fixes #709 - Carousel collapsing with certain prop config
+- [#723](https://github.com/FormidableLabs/nuka-carousel/pull/723) Cleanup dev dependencies, fix vulnerabilities, eslint fixes
+- [#698, #714, #722](https://github.com/FormidableLabs/nuka-carousel/pull/698, https://github.com/FormidableLabs/nuka-carousel/pull/714, https://github.com/FormidableLabs/nuka-carousel/pull/722) Dependency bumps
+
 ## 4.7.0 (2020-05-20)
 
 - [#695](https://github.com/FormidableLabs/nuka-carousel/pull/695) Add `slide-current` className to current 'active' slide, cleanup some utility functions
-- [#667](https://github.com/FormidableLabs/nuka-carousel/pull/667) Fixes Issue 622: Only fully visible slides are interactable. update wicg-inert version
+- [#667](https://github.com/FormidableLabs/nuka-carousel/pull/667) Fixes Issue 622: Only fully visible slides are interactive. update wicg-inert version
 
@@ -8,0 +17,0 @@ ## 4.6.7 (2020-04-23)

es/index.js

@@ -143,4 +143,2 @@ function _typeof(obj) { "@babel/helpers - typeof"; if (typeof Symbol === "function" && typeof Symbol.iterator === "symbol") { _typeof = function _typeof(obj) { return typeof obj; }; } else { _typeof = function _typeof(obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }; } return _typeof(obj); }
     value: function componentDidMount() {
-      var _this2 = this;
-
       // see https://github.com/facebook/react/issues/3417#issuecomment-121649937
@@ -161,22 +159,3 @@ this.mounted = true;
       this.getLockScrollEvents().lockTouchScroll();
-      var heightCheckDelay = 200;
-
-      var initializeHeight = function initializeHeight(delay) {
-        _this2.timers.push(setTimeout(function () {
-          // If slideHeight is greater than zero, then
-          // assume the app has been initialized.  If not,
-          // keep trying to set dimensions until things work.
-          if (_this2.state.slideHeight > 0) {
-            return;
-          }
-
-          _this2.setDimensions(); // Increase delay per attempt so the checks
-          // slowly decrease if content is taking forever to load.
-
-
-          initializeHeight(delay + heightCheckDelay);
-        }, delay));
-      };
-
-      initializeHeight(heightCheckDelay);
+      this.initializeCarouselHeight();
     } // eslint-disable-next-line complexity
@@ -190,2 +169,3 @@
       var axisChanged = prevProps.vertical !== this.props.vertical;
+      var childrenChanged = prevProps.children !== this.props.children;
 
@@ -235,2 +215,6 @@ if (axisChanged) {
 
+      if (childrenChanged) {
+        this.initializeCarouselHeight();
+      }
+
       if (slideCountChanged && slideCount <= this.state.currentSlide) {
@@ -266,2 +250,28 @@ this.goToSlide(Math.max(slideCount - 1, 0), this.props);
   }, {
+    key: "initializeCarouselHeight",
+    value: function initializeCarouselHeight() {
+      var _this2 = this;
+
+      var heightCheckDelay = 200;
+
+      var initializeHeight = function initializeHeight(delay) {
+        _this2.timers.push(setTimeout(function () {
+          // If slideHeight is greater than zero, then
+          // assume the app has been initialized.  If not,
+          // keep trying to set dimensions until things work.
+          if (_this2.state.slideHeight > 0) {
+            return;
+          }
+
+          _this2.setDimensions(); // Increase delay per attempt so the checks
+          // slowly decrease if content is taking forever to load.
+
+
+          initializeHeight(delay + heightCheckDelay);
+        }, delay));
+      };
+
+      initializeHeight(heightCheckDelay);
+    }
+  }, {
     key: "establishChildNodesMutationObserver",
@@ -293,4 +303,4 @@ value: function establishChildNodesMutationObserver() {
         for (var _i = 0, _childNodesArray = childNodesArray; _i < _childNodesArray.length; _i++) {
-          var node = _childNodesArray[_i];
-          observeChildNodeMutation(node);
+          var childNode = _childNodesArray[_i];
+          observeChildNodeMutation(childNode);
         }
@@ -297,0 +307,0 @@ }

index.d.ts

@@ -285,3 +285,3 @@ // Definitions by: Roman Charugin <https://github.com/Romic>
    */
-  onDragStart?: () => void;
+  onDragStart?: (e?: Event) => void;
 
@@ -294,2 +294,8 @@ /**
   /**
+   * Adds a number value to set the scale of the opacity for the 'scroll3d' transition mode.
+   * @default 0.65
+   */
+  opacityScale?: number;
+
+  /**
    * Pause autoPlay when mouse is over carousel
@@ -499,9 +505,9 @@ * @default true
 export interface PreviousButtonProps extends CarouselSlideRenderControlProps {}
-export class PreviousButton extends React.Component<PreviousButtonProps> {}
+export class PreviousButton extends React.FunctionalComponent<PreviousButtonProps> {}
 
 export interface NextButtonProps extends CarouselSlideRenderControlProps {}
-export class NextButton extends React.Component<NextButtonProps> {}
+export class NextButton extends React.FunctionalComponent<NextButtonProps> {}
 
 export interface PagingDotsProps extends CarouselSlideRenderControlProps {}
-export class PagingDots extends React.Component<PagingDotsProps> {
+export class PagingDots extends React.FunctionalComponent<PagingDotsProps> {
   public getButtonStyles(active: boolean): React.CSSProperties;
@@ -508,0 +514,0 @@ public getListStyles(): React.CSSProperties;

lib/index.js

@@ -185,4 +185,2 @@ "use strict";
     value: function componentDidMount() {
-      var _this2 = this;
-
       // see https://github.com/facebook/react/issues/3417#issuecomment-121649937
@@ -203,22 +201,3 @@ this.mounted = true;
       this.getLockScrollEvents().lockTouchScroll();
-      var heightCheckDelay = 200;
-
-      var initializeHeight = function initializeHeight(delay) {
-        _this2.timers.push(setTimeout(function () {
-          // If slideHeight is greater than zero, then
-          // assume the app has been initialized.  If not,
-          // keep trying to set dimensions until things work.
-          if (_this2.state.slideHeight > 0) {
-            return;
-          }
-
-          _this2.setDimensions(); // Increase delay per attempt so the checks
-          // slowly decrease if content is taking forever to load.
-
-
-          initializeHeight(delay + heightCheckDelay);
-        }, delay));
-      };
-
-      initializeHeight(heightCheckDelay);
+      this.initializeCarouselHeight();
     } // eslint-disable-next-line complexity
@@ -232,2 +211,3 @@
       var axisChanged = prevProps.vertical !== this.props.vertical;
+      var childrenChanged = prevProps.children !== this.props.children;
 
@@ -277,2 +257,6 @@ if (axisChanged) {
 
+      if (childrenChanged) {
+        this.initializeCarouselHeight();
+      }
+
       if (slideCountChanged && slideCount <= this.state.currentSlide) {
@@ -308,2 +292,28 @@ this.goToSlide(Math.max(slideCount - 1, 0), this.props);
   }, {
+    key: "initializeCarouselHeight",
+    value: function initializeCarouselHeight() {
+      var _this2 = this;
+
+      var heightCheckDelay = 200;
+
+      var initializeHeight = function initializeHeight(delay) {
+        _this2.timers.push(setTimeout(function () {
+          // If slideHeight is greater than zero, then
+          // assume the app has been initialized.  If not,
+          // keep trying to set dimensions until things work.
+          if (_this2.state.slideHeight > 0) {
+            return;
+          }
+
+          _this2.setDimensions(); // Increase delay per attempt so the checks
+          // slowly decrease if content is taking forever to load.
+
+
+          initializeHeight(delay + heightCheckDelay);
+        }, delay));
+      };
+
+      initializeHeight(heightCheckDelay);
+    }
+  }, {
     key: "establishChildNodesMutationObserver",
@@ -335,4 +345,4 @@ value: function establishChildNodesMutationObserver() {
         for (var _i = 0, _childNodesArray = childNodesArray; _i < _childNodesArray.length; _i++) {
-          var node = _childNodesArray[_i];
-          observeChildNodeMutation(node);
+          var childNode = _childNodesArray[_i];
+          observeChildNodeMutation(childNode);
         }
@@ -339,0 +349,0 @@ }

package.json

 {
   "name": "nuka-carousel",
-  "version": "4.7.1",
+  "version": "4.7.2",
   "description": "Pure React Carousel",
@@ -30,3 +30,3 @@ "main": "index.js",
     "enzyme": "^3.3.0",
-    "enzyme-adapter-react-16": "^1.15.4",
+    "enzyme-adapter-react-16": "^1.15.5",
     "eslint": "^4.8.0",
@@ -37,3 +37,3 @@ "eslint-config-formidable": "^3.0.0",
     "eslint-plugin-filenames": "^1.2.0",
-    "eslint-plugin-import": "^2.18.2",
+    "eslint-plugin-import": "^2.22.1",
     "eslint-plugin-prettier": "^2.6.0",
@@ -44,3 +44,3 @@ "eslint-plugin-react": "^7.14.3",
     "jest-puppeteer-preset": "^2.0.1",
-    "prettier": "2.1.1",
+    "prettier": "2.1.2",
     "puppeteer": "^5.2.1",
@@ -51,6 +51,6 @@ "react": "^16.9.0",
     "typescript": "^3.6.2",
-    "url-loader": "^4.1.0",
+    "url-loader": "^4.1.1",
     "webpack": "4.44.1",
     "webpack-cli": "^3.3.12",
-    "webpack-dev-server": "^3.0.0"
+    "webpack-dev-server": "^3.11.0"
   },
@@ -57,0 +57,0 @@ "peerDependencies": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

288135

increased by0.56%

Lines of code

5488

increased by0.42%

No dependency changes