oath - npm Package Compare versions

Comparing version 0.0.2 to 0.0.3

History.md

 
+0.0.3 / 2011-10-04 
+==================
+
+  * bugfix: skip pending that don't have required response callback
+
 0.0.2 / 2011-10-04 
@@ -3,0 +8,0 @@ ==================

lib/oath.js

@@ -13,3 +13,3 @@ /*!
  */
-exports.version = '0.0.2';
+exports.version = '0.0.3';
 
@@ -183,5 +183,7 @@
 Oath.prototype.complete = function (type, result) {
+  var fn;
   while (this.pending[0]) {
-    this.pending.shift()[type](result);
+    fn = this.pending.shift()[type];
+    if (fn && 'function' === typeof fn) fn(result);
   }
 };

package.json

@@ -5,3 +5,3 @@ {
   "description": "Tiny promises.",
-  "version": "0.0.2",
+  "version": "0.0.3",
   "homepage": "http://logicalparadox.github.com/oath",
@@ -8,0 +8,0 @@ "repository": {

test/oath.test.js

@@ -27,6 +27,7 @@ var assert = require('assert'),
     
-    promise({ doctor: 'who' }).then(success, failure);
+    promise({ doctor: 'who' })
+      .then(success, failure);
     
     this.on('exit', function () {
-      assert.equal(n, 1, 'the success function has been called');
+      assert.equal(n, 1, 'the success function has been called twice');
     });
@@ -53,6 +54,7 @@ },
     
-    promise({ doctor: 'who' }).then(success, failure);
-    
+    promise({ doctor: 'who' })
+      .then(success) // if no failure object skip
+      .then(success, failure);
     this.on('exit', function () {
-      assert.equal(n, -1, 'the success function has been called');
+      assert.equal(n, -1, 'i have successfully failed');
     });
@@ -59,0 +61,0 @@ },

Fixed alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Number of medium supply chain risk alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

12684

decreased by-38.1%

Number of package files

9

decreased by-10%

Lines of code

310

decreased by-28.41%

No dependency changes