observ-array - npm Package Compare versions

Comparing version 3.1.0 to 3.2.0

array-methods.js

@@ -30,4 +30,4 @@ var ObservArray = require("./index.js")
     obs.unshift = observArrayUnshift
-    obs.reverse = notImplemented
-    obs.sort = notImplemented
+    obs.reverse = require("./array-reverse.js")
+    obs.sort = require("./array-sort.js")
 
@@ -34,0 +34,0 @@ methods.forEach(function (tuple) {

package.json

 {
   "name": "observ-array",
-  "version": "3.1.0",
+  "version": "3.2.0",
   "description": "An array containing observable values",
@@ -25,2 +25,5 @@ "keywords": [],
   "devDependencies": {
+    "observ-hash": "^2.0.0",
+    "observ-struct": "^6.0.0",
+    "observ-varhash": "^1.0.4",
     "tape": "~2.5.0"
@@ -27,0 +30,0 @@ },

set.js

@@ -1,2 +0,2 @@
-var addListener = require("./add-listener.js")
+var applyPatch = require("./apply-patch.js")
 var setNonEnumerable = require("./lib/set-non-enumerable.js")
@@ -9,3 +9,3 @@ var adiff = require("adiff")
     if (!Array.isArray(rawList)) rawList = []
-        
+
     var obs = this
@@ -22,34 +22,1 @@ var changes = adiff.diff(obs._list, rawList)
 }
-
-function applyPatch (valueList, args) {
-    var obs = this
-    var valueArgs = args.map(unpack)
-
-    valueList.splice.apply(valueList, valueArgs)
-    obs._list.splice.apply(obs._list, args)
-
-    var extraRemoveListeners = args.slice(2).map(function (observ) {
-        return typeof observ === "function" ?
-            addListener(obs, observ) :
-            null
-    })
-
-    extraRemoveListeners.unshift(args[0], args[1])
-    var removedListeners = obs._removeListeners.splice
-        .apply(obs._removeListeners, extraRemoveListeners)
-
-    removedListeners.forEach(function (removeObservListener) {
-        if (removeObservListener) {
-            removeObservListener()
-        }
-    })
-
-    return valueArgs
-}
-
-function unpack(value, index){
-    if (index === 0 || index === 1) {
-        return value
-    }
-    return typeof value === "function" ? value() : value
-}

test/index.js

@@ -365,2 +365,5 @@ var test = require("tape")
     assert.end()
-})
+})
+
+require('./reverse.js')
+require('./sort.js')

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

44164

increased by82.19%

Number of package files

20

increased by33.33%

Lines of code

1215

increased by125%

Worsened metrics

Dev dependency count

4

increased by300%

No dependency changes