ogen - npm Package Compare versions

Comparing version 1.1.0 to 1.2.0

package.json

 {
   "name": "ogen",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "description": "An observable Async/Await. Write async code that looks synchronous.",
@@ -5,0 +5,0 @@ "main": "source/ogen.js",

source/ogen.js

@@ -15,3 +15,11 @@ /* eslint-disable no-use-before-define */
   } = callbacks;
-  const item = iter.next(prev);
+
+  let item;
+
+  try {
+    item = iter.next(prev);
+  } catch (err) {
+    return onError(err);
+  }
+
   const value = item.value;
@@ -18,0 +26,0 @@

source/test/index.js

@@ -105,3 +105,3 @@ const test = require('tape');
     assert.pass(msg);
-    setTimeout(() => assert.end(), 500);
+    setTimeout(() => assert.end(), 10);
   },
@@ -112,1 +112,60 @@ () => {
 });
+
+
+test('promise throw', assert => {
+  const msg = 'should notify onError';
+  const halt = 'should not emit more data';
+  const noComplete = 'should not notify onComplete';
+
+  const fetchSomething = () => new Promise(() => {
+    throw new Error('Could not fetch data');
+  });
+
+  const generator = function* () {
+    const result = yield fetchSomething();
+
+    // should not emit this
+    yield result + ' 2';
+  };
+
+  const observable = ogen(generator)();
+
+  observable.subscribe(val => {
+    assert.fail(halt);
+    assert.fail(`emitted: ${ val }`);
+  },
+  () => {
+    assert.pass(msg);
+    setTimeout(() => assert.end(), 10);
+  },
+  () => {
+    assert.fail(noComplete);
+  });
+});
+
+test('generator throw', assert => {
+  const msg = 'should notify onError';
+  const halt = 'should not emit more data';
+  const noComplete = 'should not notify onComplete';
+
+  const generator = function* () {
+    throw new Error('faulty generator');
+
+    /* eslint-disable no-unreachable */
+    yield 'should not emit this';
+  };
+
+  const observable = ogen(generator)();
+
+  observable.subscribe(val => {
+    assert.fail(halt);
+    assert.fail(`emitted: ${ val }`);
+  },
+  () => {
+    assert.pass(msg);
+    setTimeout(() => assert.end(), 10);
+  },
+  () => {
+    assert.fail(noComplete);
+  });
+});

No alert changes

Improved metrics

Total package byte prevSize

13724

10.82%

Lines of code

175

42.28%

No dependency changes