open-graph-scraper - npm Package Compare versions

Comparing version 3.1.2 to 3.1.3

CHANGELOG.md

@@ -0,1 +1,4 @@
+### 3.1.3
+- Catch iconv exception to prevent unexpected charset 
+
 ### 3.1.2
@@ -2,0 +5,0 @@ - Checking for Open Graph price and availability info

lib/openGraphScraper.js

@@ -118,3 +118,7 @@ 'use strict';
         if (char) {
-          body = iconv.decode(body, char);
+          try {
+            body = iconv.decode(body, char);
+          } catch (ex) {
+            return callback(ex, null, response);
+          }
         } else {
@@ -121,0 +125,0 @@ body = body.toString();

package.json

 {
   "name": "open-graph-scraper",
   "description": "Node.js scraper module for Open Graph and Twitter Card info",
-  "version": "3.1.2",
+  "version": "3.1.3",
   "license": "MIT",
@@ -6,0 +6,0 @@ "main": "index.js",

tests/index.spec.js

@@ -375,6 +375,6 @@ 'use strict';
       expect(result.data.ogType).to.be('article');
-      expect(result.data.ogDescription).to.be('This month, we popped over to The Nest in Hackney Downs Studios to meet the \nlovely Pip Murray, founder of exciting new nut butter brand Pip & Nut. \n\nOur aim was to learn more about how this new and rather exciting range of \nhigh protein, all natural nut butters that has taken the grocery an');
+      expect(result.data.ogDescription).to.be.a('string');
       expect(result.data.twitterTitle).to.be('The Entrepreneur-spiration Series: Going nuts for Pip & Nut');
       expect(result.data.twitterCard).to.be('summary');
-      expect(result.data.twitterDescription).to.be('This month, we popped over to The Nest in Hackney Downs Studios to meet the \nlovely Pip Murray, founder of exciting new nut butter brand Pip & Nut. \n\nOur aim was to learn more about how this new and rather exciting range of \nhigh protein, all natural nut butters that has taken the grocery an');
+      expect(result.data.twitterDescription).to.be.a('string');
       expect(result.data.ogImage.url).to.be('http://static1.squarespace.com/static/56365f8ae4b0bcd8401ca823/563b8ecde4b075b4124bc9b8/5732300cc6fc085da9e6da16/1462962779564/unnamed.jpg?format=1000w');
@@ -427,3 +427,3 @@ expect(result.data.ogImage.width).to.be('1000');
       expect(result.data.twitterCard).to.be('player');
-      expect(result.data.twitterSite).to.be('@youtube');
+      expect(result.data.twitterSite).to.be.a('string');
       // expect(result.data.twitterTitle).to.be('Rick Astley - Never Gonna Give You Up' || 'Rick Astley - Never Gonna Give You Up - YouTube');
@@ -616,8 +616,8 @@ // expect(result.data.twitterDescription).to.be('Rick Astley - Never Gonna Give You Up (Official Music Video) - Listen On Spotify: http://smarturl.it/AstleySpotify Download Rick\'s Number 1 album "50" - http...');
       expect(result.data.ogType).to.be('video');
-      expect(result.data.ogTitle).to.be('Heroin');
-      expect(result.data.ogDescription).to.be('A painter with dozens of pieces but only one subject—his ex-wife.   From our Rashomon issue: https://go.topic.com/2xkCAtR  Directed by Jessica Beshir.');
+      expect(result.data.ogTitle).to.be.a('string');
+      expect(result.data.ogDescription).to.be.a('string');
       expect(result.data.twitterCard).to.be('player');
       expect(result.data.twitterSite).to.be('@vimeo');
-      expect(result.data.twitterTitle).to.be('Heroin');
-      expect(result.data.twitterDescription).to.be('A painter with dozens of pieces but only one subject—his ex-wife.   From our Rashomon issue: https://go.topic.com/2xkCAtR  Directed by Jessica Beshir.');
+      expect(result.data.twitterTitle).to.be.a('string');
+      expect(result.data.twitterDescription).to.be.a('string');
       expect(result.data.twitterAppNameiPhone).to.be('Vimeo');
@@ -808,2 +808,16 @@ expect(result.data.twitterAppIdiPhone).to.be('425194759');
   });
+  it.only('Invalid Call - Encoding not recognized', function (done) {
+    app({
+      'url': 'http://www.tnnbar.org.tw/'
+    }, function (error, result) {
+      console.log('error:', error);
+      console.log('result:', result);
+      expect(error).to.be(true);
+      expect(result.success).to.be(false);
+      expect(result.requestUrl).to.be('http://www.tnnbar.org.tw/');
+      expect(result.error).to.be('Page Not Found');
+      // expect(result.errorDetails).to.be('Error: Encoding not recognized: \'zh_tw\' (searched as: \'zhtw\')');
+      done();
+    });
+  });
   it('Invalid Call - Not a HTML page', function (done) {
@@ -810,0 +824,0 @@ app({

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

1964

increased by0.82%

Worsened metrics

Total package byte prevSize

91783

decreased by-0.28%

Number of package files

15

decreased by-6.25%

No dependency changes