open - npm Package Compare versions

Comparing version 8.2.0 to 8.2.1

index.d.ts

@@ -69,18 +69,2 @@ import {ChildProcess} from 'child_process';
 	/**
-	An object containing auto-detected binary names for common apps. Useful to work around cross-platform differences.
-
-	@example
-	```
-	import open = require('open');
-
-	await open('https://google.com', {
-		app: {
-			name: open.apps.chrome
-		}
-	});
-	```
-	*/
-	apps: Record<open.AppName, string | readonly string[]>;
-
-	/**
 	Open stuff like URLs, files, executables. Cross-platform.
@@ -117,4 +101,20 @@
 	): Promise<ChildProcess>;
+
+	/**
+	An object containing auto-detected binary names for common apps. Useful to work around cross-platform differences.
+
+	@example
+	```
+	import open = require('open');
+
+	await open('https://google.com', {
+		app: {
+			name: open.apps.chrome
+		}
+	});
+	```
+	*/
+	apps: Record<open.AppName, string | readonly string[]>;
 };
 
 export = open;

index.js

@@ -93,2 +93,3 @@ const path = require('path');
 	let {name: app, arguments: appArguments = []} = options.app || {};
+	appArguments = [...appArguments];
 
@@ -95,0 +96,0 @@ if (Array.isArray(app)) {

package.json

 {
 	"name": "open",
-	"version": "8.2.0",
+	"version": "8.2.1",
 	"description": "Open stuff like URLs, files, executables. Cross-platform.",
@@ -5,0 +5,0 @@ "license": "MIT",

readme.md

@@ -131,27 +131,2 @@ # open
 
-## Caveats
-
-### Double-quotes on Windows
-
-TL;DR: All double-quotes are stripped from the `target` and do not get to your desired destination (on Windows!).
-
-Due to specific behaviors of Window's Command Prompt (`cmd.exe`) regarding ampersand (`&`) characters breaking commands and URLs, double-quotes are now a special case.
-
-The solution ([#146](https://github.com/sindresorhus/open/pull/146)) to this and other problems was to leverage the fact that `cmd.exe` interprets a double-quoted argument as a plain text argument just by quoting it (like Node.js already does). Unfortunately, `cmd.exe` can only do **one** of two things: handle them all **OR** not handle them at all. As per its own documentation:
-
->*If /C or /K is specified, then the remainder of the command line after the switch is processed as a command line, where the following logic is used to process quote (") characters:*
->
->    1.  *If all of the following conditions are met, then quote characters on the command line are preserved:*
->        - *no /S switch*
->        - *exactly two quote characters*
->        - *no special characters between the two quote characters, where special is one of: &<>()@^|*
->        - *there are one or more whitespace characters between the two quote characters*
->        - *the string between the two quote characters is the name of an executable file.*
->
->    2.  *Otherwise, old behavior is to see if the first character is a quote character and if so, strip the leading character and remove the last quote character on the command line, preserving any text after the last quote character.*
-
-The option that solved all of the problems was the second one, and for additional behavior consistency we're also now using the `/S` switch, so we **always** get the second option. The caveat is that this built-in double-quotes handling ends up stripping all of them from the command line and so far we weren't able to find an escaping method that works (if you do, please feel free to contribute!).
-
-To make this caveat somewhat less impactful (at least for URLs), check out the [url option](#url). Double-quotes will be "preserved" when using it with an URL.
-
 ## Related
@@ -158,0 +133,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

311

increased by0.32%

Worsened metrics

Total package byte prevSize

43322

decreased by-4.68%

Number of lines in readme file

147

decreased by-14.53%

No dependency changes