openid-client - npm Package Compare versions

Comparing version 1.6.0 to 1.6.1

CHANGELOG.md

@@ -21,2 +21,7 @@ # openid-client CHANGELOG
 ## Version 1.6.0
+### Version 1.6.1
+- [DIFF](https://github.com/panva/node-openid-client/compare/v1.6.0...v1.6.1)
+- fixed verify callback skipping userinfo call when arity says it should but no access token is present (#18)
+
+### Version 1.6.0
 - [DIFF](https://github.com/panva/node-openid-client/compare/v1.5.3...v1.6.0)
@@ -23,0 +28,0 @@ - added at_hash presence assertion for applicable (implicit) ID Token validation

lib/passport_strategy.js

@@ -106,7 +106,11 @@ 'use strict';
       callback = callback.then((result) => {
-        const userinfoRequest = client.userinfo(result.tokenset);
-        return userinfoRequest.then((userinfo) => {
-          result.userinfo = userinfo;
-          return result;
-        });
+        if (result.tokenset.access_token) {
+          const userinfoRequest = client.userinfo(result.tokenset);
+          return userinfoRequest.then((userinfo) => {
+            result.userinfo = userinfo;
+            return result;
+          });
+        }
+
+        return result;
       });
@@ -116,3 +120,3 @@ }
     callback.then((result) => {
-      if (result.userinfo) {
+      if (loadUserinfo) {
         this._verify(result.tokenset, result.userinfo, verified.bind(this));
@@ -119,0 +123,0 @@ } else {

package.json

 {
   "name": "openid-client",
-  "version": "1.6.0",
+  "version": "1.6.1",
   "description": "OpenID Connect Relying Party (RP, Client) implementation for Node.js servers, supports passportjs",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

README.md

@@ -141,3 +141,3 @@ # openid-client
     console.log('received and validated tokens %j', tokenSet);
-    console.log('validated id_token claims %j' tokenSet.claims);
+    console.log('validated id_token claims %j', tokenSet.claims);
   });
@@ -154,3 +154,3 @@ ```
     console.log('received and validated tokens %j', tokenSet);
-    console.log('validated id_token claims %j' tokenSet.claims);
+    console.log('validated id_token claims %j', tokenSet.claims);
   });
@@ -157,0 +157,0 @@ ```

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

69402

increased by0.46%

Lines of code

1292

increased by0.23%

No dependency changes