opentok-react-native - npm Package Compare versions

Comparing version 0.4.0 to 0.4.1

package.json

 {
   "name": "opentok-react-native",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "description": "React Native components for OpenTok iOS and Android SDKs",
@@ -5,0 +5,0 @@ "main": "src/index.js",

README.md

@@ -162,3 +162,3 @@ ![OpenTok Labs](https://d26dzxoao6i3hh.cloudfront.net/items/0U1R0a0e2g1E361H0x3c/Image%202017-11-22%20at%2012.16.38%20PM.png?v=2507a2df)
 
-  * **resolution** (String) - The desired resolution of the video. The format of the string is "widthxheight", where the width and height are represented in pixels. Valid values are "1280x720", "640x480", and "320x240". The published video will only use the desired resolution if the client configuration supports it. Some devices and clients do not support each of these resolution settings.
+  * **resolution** (String) - The desired resolution of the video. The format of the string is "widthxheight", where the width and height are represented in pixels. Valid values are "1280x720", "640x480", and "352x288". The published video will only use the desired resolution if the client configuration supports it. Some devices and clients do not support each of these resolution settings.
 
@@ -169,3 +169,3 @@ * **videoTrack** (Boolean) — If this property is set to false, the video subsystem will not be initialized for the publisher, and setting the publishVideo property will have no effect. If your application does not require the use of video, it is recommended to set this property rather than use the publishVideo property, which only temporarily disables the video track.
 
-The `OTPublisher` component will initialize a publisher and publish to a specified session upon mounting. To destroy the publisher, unmount the `OTPublisher` component.
+The `OTPublisher` component will initialize a publisher and publish to the specified session upon mounting. To destroy the publisher, unmount the `OTPublisher` component. Please keep in mind that the publisher view is not removed unless you specifically unmount the `OTPublisher` component.
 
@@ -172,0 +172,0 @@ ```html

src/OTPublisher.js

@@ -16,3 +16,2 @@ import React, { Component } from 'react';
     this.componentEvents = {
-      streamDestroyed: Platform.OS === 'android' ? 'publisher:onStreamDestroyed' : 'publisher:streamDestroyed',
       sessionConnected: Platform.OS === 'android' ? 'session:onConnected' : 'session:sessionDidConnect',
@@ -27,3 +26,2 @@ };
     this.sessionConnected = nativeEvents.addListener(this.componentEvents.sessionConnected, () => this.sessionConnectedHandler());
-    this.streamDestroyed = nativeEvents.addListener(this.componentEvents.streamDestroyed, () => this.streamDestroyedHandler());
   }
@@ -57,3 +55,2 @@ componentDidMount() {
         this.sessionConnected.remove();        
-        this.streamDestroyed.remove();
         OT.removeJSComponentEvents(this.componentEventsArray);         
@@ -68,3 +65,3 @@ const events = sanitizePublisherEvents(this.props.eventHandlers);
       if (publishError) {
-        handleError(error);
+        handleError(publishError);
       } else {
@@ -77,7 +74,2 @@ this.setState({
   }
-  streamDestroyedHandler = () => {
-    this.setState({
-      publisher: null,
-    });
-  }
   createPublisher() {
@@ -84,0 +76,0 @@ if (Platform.OS === 'android') {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

92390

increased by0.19%

Worsened metrics

Lines of code

612

decreased by-1.29%

No dependency changes