pa11y - npm Package Compare versions

Comparing version 5.0.0-beta.4 to 5.0.0-beta.5

CHANGELOG.md

 
 # Changelog
 
+## 5.0.0-beta.5 pre-release (2017-12-11)
+
+  * Update dependencies
+    * puppeteer: ^0.11.0 to ^0.13.0
+
 ## 5.0.0-beta.4 pre-release (2017-12-06)
@@ -5,0 +10,0 @@

lib/pa11y.js

@@ -95,3 +95,3 @@ 'use strict';
 	// to set the HTTP method or post data
-	await page.setRequestInterceptionEnabled(true);
+	await page.setRequestInterception(true);
 
@@ -141,3 +141,3 @@ // Intercept requests so we can set the HTTP method
 
-	const gotoConfig = {waitUntil: 'networkidle'};
+	const gotoConfig = {waitUntil: 'networkidle2'};
 	gotoConfig.timeout = options.timeout;
@@ -161,5 +161,5 @@
 	options.log.debug('Injecting HTML CodeSniffer');
-	await page.injectFile(`${__dirname}/vendor/HTMLCS.js`);
+	await page.addScriptTag({path: `${__dirname}/vendor/HTMLCS.js`});
 	options.log.debug('Injecting Pa11y');
-	await page.injectFile(`${__dirname}/runner.js`);
+	await page.addScriptTag({path: `${__dirname}/runner.js`});
 
@@ -166,0 +166,0 @@ // Launch the test runner!

package.json

 {
   "name": "pa11y",
-  "version": "5.0.0-beta.4",
+  "version": "5.0.0-beta.5",
   "description": "Pa11y is your automated accessibility testing pal",
@@ -39,3 +39,3 @@ "keywords": [
     "pa11y-reporter-json": "^1.0.0",
-    "puppeteer": "^0.11.0",
+    "puppeteer": "^0.13.0",
     "semver": "^5.4.1"
@@ -42,0 +42,0 @@ },

test/unit/lib/pa11y.test.js

@@ -92,4 +92,4 @@ 'use strict';
 		it('enables request interception', () => {
-			assert.calledOnce(puppeteer.mockPage.setRequestInterceptionEnabled);
-			assert.calledWithExactly(puppeteer.mockPage.setRequestInterceptionEnabled, true);
+			assert.calledOnce(puppeteer.mockPage.setRequestInterception);
+			assert.calledWithExactly(puppeteer.mockPage.setRequestInterception, true);
 		});
@@ -165,3 +165,3 @@
 			assert.calledWith(puppeteer.mockPage.goto, 'https://mock-url/', {
-				waitUntil: 'networkidle',
+				waitUntil: 'networkidle2',
 				timeout: pa11y.defaults.timeout
@@ -177,9 +177,9 @@ });
 		it('injects HTML CodeSniffer', () => {
-			assert.called(puppeteer.mockPage.injectFile);
-			assert.calledWith(puppeteer.mockPage.injectFile, path.resolve(`${__dirname}/../../../lib/vendor/HTMLCS.js`));
+			assert.called(puppeteer.mockPage.addScriptTag);
+			assert.calledWith(puppeteer.mockPage.addScriptTag, {path: path.resolve(`${__dirname}/../../../lib/vendor/HTMLCS.js`)});
 		});
 
 		it('injects the Pa11y runner', () => {
-			assert.called(puppeteer.mockPage.injectFile);
-			assert.calledWith(puppeteer.mockPage.injectFile, path.resolve(`${__dirname}/../../../lib/runner.js`));
+			assert.called(puppeteer.mockPage.addScriptTag);
+			assert.calledWith(puppeteer.mockPage.addScriptTag, {path: path.resolve(`${__dirname}/../../../lib/runner.js`)});
 		});
@@ -334,3 +334,3 @@
 			assert.calledWith(puppeteer.mockPage.goto, 'https://mock-url/', {
-				waitUntil: 'networkidle',
+				waitUntil: 'networkidle2',
 				timeout: options.timeout
@@ -637,3 +637,3 @@ });
 			assert.calledWith(puppeteer.mockPage.goto, 'https://mock-url/', {
-				waitUntil: 'networkidle',
+				waitUntil: 'networkidle2',
 				timeout: pa11y.defaults.timeout
@@ -640,0 +640,0 @@ });

test/unit/mock/puppeteer.mock.js

@@ -19,7 +19,7 @@ 'use strict';
 	goto: sinon.stub().resolves(),
-	injectFile: sinon.stub().resolves(),
+	addScriptTag: sinon.stub().resolves(),
 	on: sinon.stub(),
 	screenshot: sinon.stub().resolves(),
 	setExtraHTTPHeaders: sinon.stub().resolves(),
-	setRequestInterceptionEnabled: sinon.stub().resolves(),
+	setRequestInterception: sinon.stub().resolves(),
 	setUserAgent: sinon.stub().resolves(),
@@ -26,0 +26,0 @@ setViewport: sinon.stub().resolves(),

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

352368

increased by0.04%

Dependency changes

• + Addedpuppeteer@0.13.0(transitive)

• - Removedpuppeteer@0.11.0(transitive)

• Updatedpuppeteer@^0.13.0