pem - npm Package Compare versions

Comparing version 1.13.1 to 1.13.2

CHANGELOG.md

@@ -0,1 +1,8 @@
+## [1.13.2](https://github.com/Dexus/pem/compare/v1.13.1...v1.13.2) (2018-10-26)
+
+
+### Bug Fixes
+
+* **package:** security fix ([#217](https://github.com/Dexus/pem/issues/217)) ([bed1190](https://github.com/Dexus/pem/commit/bed1190))
+
 ## [1.13.1](https://github.com/Dexus/pem/compare/v1.13.0...v1.13.1) (2018-09-14)
@@ -2,0 +9,0 @@

HISTORY.md

@@ -7,2 +7,9 @@ ### Changelog
 
+#### [v1.13.1](https://github.com/Dexus/pem/compare/v1.13.0...v1.13.1)
+
+> 14 September 2018
+
+- fix(package): remove -utf8 option [`#214`](https://github.com/Dexus/pem/issues/214)
+- chore(release): 1.13.1 [skip ci] [`68ad452`](https://github.com/Dexus/pem/commit/68ad4525640dff9a4095efcf04cdb083b3aadb6f)
+
 #### [v1.13.0](https://github.com/Dexus/pem/compare/v1.12.8...v1.13.0)
@@ -61,10 +68,5 @@
 - Update eslint-config-standard to the latest version 🚀 [`#186`](https://github.com/Dexus/pem/pull/186)
-- Update eslint-plugin-node to the latest version 🚀 [`#185`](https://github.com/Dexus/pem/pull/185)
-- Update mocha to the latest version 🚀 [`#183`](https://github.com/Dexus/pem/pull/183)
-- Update semantic-release to the latest version 🚀 [`#182`](https://github.com/Dexus/pem/pull/182)
 - Update semantic-release to the latest version 🚀 [`#178`](https://github.com/Dexus/pem/pull/178)
 - Update travis-deploy-once to the latest version 🚀 [`#181`](https://github.com/Dexus/pem/pull/181)
 - chore(package): update cross-env to version 5.1.2 [`#180`](https://github.com/Dexus/pem/pull/180)
-- Update docco to the latest version 🚀 [`#177`](https://github.com/Dexus/pem/pull/177)
-- readCertificateInfo reports email addresses in subjectAltName field [`#170`](https://github.com/Dexus/pem/pull/170)
 - chore(package): update semantic-release to version 15.1.5 [`#182`](https://github.com/Dexus/pem/issues/182)
@@ -95,5 +97,2 @@ - Update HISTORY.md via TravisCI [`8e89517`](https://github.com/Dexus/pem/commit/8e895178e7701e4f0fea7a5d98a41be10a4ce457)
 
-- fix #159; renamed helper methods [`#159`](https://github.com/Dexus/pem/issues/159)
 - change template for docs [`10672e4`](https://github.com/Dexus/pem/commit/10672e4d2d7e0c9e856e5bc1af90c4977da2ee8b)
-- update template for docs [`2f95e38`](https://github.com/Dexus/pem/commit/2f95e3802ca2c742ec3c9f09591d4d34be165158)
-- fix(tests): renamed helper functions [`0073032`](https://github.com/Dexus/pem/commit/007303276a16a03394361ab290d3d93a74ed77c8)

lib/convert.js

@@ -172,4 +172,4 @@ 'use strict'
   var delTempPWFiles = []
-  helper.createPasswordFile({ 'cipher': '', 'password': password, 'passType': 'in' }, params, delTempPWFiles[delTempPWFiles.length])
-  helper.createPasswordFile({ 'cipher': '', 'password': password, 'passType': 'out' }, params, delTempPWFiles[delTempPWFiles.length])
+  helper.createPasswordFile({ 'cipher': '', 'password': password, 'passType': 'in' }, params, delTempPWFiles)
+  helper.createPasswordFile({ 'cipher': '', 'password': password, 'passType': 'out' }, params, delTempPWFiles)
   openssl.spawnWrapper(params, false, function (error, code) {
@@ -206,4 +206,4 @@ function done (error) {
   var delTempPWFiles = []
-  helper.createPasswordFile({ 'cipher': '', 'password': password, 'passType': 'in' }, params, delTempPWFiles[delTempPWFiles.length])
-  helper.createPasswordFile({ 'cipher': '', 'password': password, 'passType': 'out' }, params, delTempPWFiles[delTempPWFiles.length])
+  helper.createPasswordFile({ 'cipher': '', 'password': password, 'passType': 'in' }, params, delTempPWFiles)
+  helper.createPasswordFile({ 'cipher': '', 'password': password, 'passType': 'out' }, params, delTempPWFiles)
   openssl.spawnWrapper(params, false, function (error, code) {
@@ -264,4 +264,4 @@ function done (error) {
       var delTempPWFiles = [tmpfile]
-      helper.createPasswordFile({ 'cipher': '', 'password': password, 'passType': 'in' }, params, delTempPWFiles[delTempPWFiles.length])
-      helper.createPasswordFile({ 'cipher': '', 'password': password, 'passType': 'out' }, params, delTempPWFiles[delTempPWFiles.length])
+      helper.createPasswordFile({ 'cipher': '', 'password': password, 'passType': 'in' }, params, delTempPWFiles)
+      helper.createPasswordFile({ 'cipher': '', 'password': password, 'passType': 'out' }, params, delTempPWFiles)
       openssl.spawnWrapper(params, false, function (error, code) {
@@ -268,0 +268,0 @@ function done (error) {

lib/helper.js

@@ -8,2 +8,3 @@ 'use strict'
 var tempDir = process.env.PEMJS_TMPDIR || osTmpdir()
+
 /**
@@ -70,10 +71,11 @@ * pem helper module
  * @param {Object} params params will be extended with the data that need for the openssl command. IS USED AS POINTER!
- * @param {String} PasswordFile PasswordFile is the filePath that later need to deleted, after the openssl command. IS USED AS POINTER!
+ * @param {String} PasswordFileArray PasswordFileArray is an array of filePaths that later need to deleted ,after the openssl command. IS USED AS POINTER!
  * @return {Boolean} result
  */
-module.exports.createPasswordFile = function (options, params, PasswordFile) {
+module.exports.createPasswordFile = function (options, params, PasswordFileArray) {
   if (!options || !options.hasOwnProperty('password') || !options.hasOwnProperty('passType') || !/^(word|in|out)$/.test(options.passType)) {
     return false
   }
-  PasswordFile = pathlib.join(tempDir, crypto.randomBytes(20).toString('hex'))
+  var PasswordFile = pathlib.join(tempDir, crypto.randomBytes(20).toString('hex'))
+  PasswordFileArray.push(PasswordFile)
   options.password = options.password.trim()
@@ -80,0 +82,0 @@ if (options.password === '') {

lib/pem.js

@@ -72,3 +72,3 @@ 'use strict'
   if (options && options.cipher && (Number(helper.ciphers.indexOf(options.cipher)) !== -1) && options.password) {
-    helper.createPasswordFile({ 'cipher': options.cipher, 'password': options.password, 'passType': 'out' }, params, delTempPWFiles[delTempPWFiles.length])
+    helper.createPasswordFile({ 'cipher': options.cipher, 'password': options.password, 'passType': 'out' }, params, delTempPWFiles)
   }
@@ -267,3 +267,3 @@
   if (options.clientKeyPassword) {
-    helper.createPasswordFile({ 'cipher': '', 'password': options.clientKeyPassword, 'passType': 'in' }, params, delTempPWFiles[delTempPWFiles.length])
+    helper.createPasswordFile({ 'cipher': '', 'password': options.clientKeyPassword, 'passType': 'in' }, params, delTempPWFiles)
   }
@@ -389,3 +389,3 @@
     if (options.serviceKeyPassword) {
-      helper.createPasswordFile({ 'cipher': '', 'password': options.serviceKeyPassword, 'passType': 'in' }, params, delTempPWFiles[delTempPWFiles.length])
+      helper.createPasswordFile({ 'cipher': '', 'password': options.serviceKeyPassword, 'passType': 'in' }, params, delTempPWFiles)
     }
@@ -398,3 +398,3 @@ tmpfiles.push(options.serviceCertificate)
     if (options.serviceKeyPassword) {
-      helper.createPasswordFile({ 'cipher': '', 'password': options.serviceKeyPassword, 'passType': 'in' }, params, delTempPWFiles[delTempPWFiles.length])
+      helper.createPasswordFile({ 'cipher': '', 'password': options.serviceKeyPassword, 'passType': 'in' }, params, delTempPWFiles)
     }
@@ -416,3 +416,3 @@ tmpfiles.push(options.serviceKey)
   if (options.clientKeyPassword) {
-    helper.createPasswordFile({ 'cipher': '', 'password': options.clientKeyPassword, 'passType': 'in' }, params, delTempPWFiles[delTempPWFiles.length])
+    helper.createPasswordFile({ 'cipher': '', 'password': options.clientKeyPassword, 'passType': 'in' }, params, delTempPWFiles)
   }
@@ -566,3 +566,3 @@
   if (password) {
-    helper.createPasswordFile({ 'cipher': '', 'password': password, 'passType': 'in' }, params, delTempPWFiles[delTempPWFiles.length])
+    helper.createPasswordFile({ 'cipher': '', 'password': password, 'passType': 'in' }, params, delTempPWFiles)
   }
@@ -711,7 +711,7 @@
     // create password file for the import "-passin"
-    helper.createPasswordFile({ 'cipher': options.cipher, 'password': options.clientKeyPassword, 'passType': 'in' }, params, delTempPWFiles[delTempPWFiles.length])
+    helper.createPasswordFile({ 'cipher': options.cipher, 'password': options.clientKeyPassword, 'passType': 'in' }, params, delTempPWFiles)
   }
   // NOTICE: The password field is needed! self if it is empty.
   // create password file for the password "-password"
-  helper.createPasswordFile({ 'cipher': '', 'password': password, 'passType': 'word' }, params, delTempPWFiles[delTempPWFiles.length])
+  helper.createPasswordFile({ 'cipher': '', 'password': password, 'passType': 'word' }, params, delTempPWFiles)
 
@@ -766,3 +766,3 @@ params.push('-in')
 
-  helper.createPasswordFile({ 'cipher': '', 'password': options.p12Password, 'passType': 'in' }, args, delTempPWFiles[delTempPWFiles.length])
+  helper.createPasswordFile({ 'cipher': '', 'password': options.p12Password, 'passType': 'in' }, args, delTempPWFiles)
 
@@ -775,3 +775,3 @@ if (Buffer.isBuffer(bufferOrPath)) {
   if (options.clientKeyPassword) {
-    helper.createPasswordFile({ 'cipher': '', 'password': options.clientKeyPassword, 'passType': 'out' }, args, delTempPWFiles[delTempPWFiles.length])
+    helper.createPasswordFile({ 'cipher': '', 'password': options.clientKeyPassword, 'passType': 'out' }, args, delTempPWFiles)
   } else {
@@ -844,3 +844,3 @@ args.push('-nodes')
   if (passphrase) {
-    helper.createPasswordFile({ 'cipher': '', 'password': passphrase, 'passType': 'in' }, params, delTempPWFiles[delTempPWFiles.length])
+    helper.createPasswordFile({ 'cipher': '', 'password': passphrase, 'passType': 'in' }, params, delTempPWFiles)
   }
@@ -888,3 +888,3 @@
 
-  helper.createPasswordFile({ 'cipher': '', 'password': passphrase, 'passType': 'in' }, args, delTempPWFiles[delTempPWFiles.length])
+  helper.createPasswordFile({ 'cipher': '', 'password': passphrase, 'passType': 'in' }, args, delTempPWFiles)
 
@@ -891,0 +891,0 @@ if (Buffer.isBuffer(bufferOrPath)) {

package.json

@@ -13,3 +13,3 @@ {
   "description": "Create private keys and certificates with node.js and io.js",
-  "version": "1.13.1",
+  "version": "1.13.2",
   "repository": {
@@ -16,0 +16,0 @@ "type": "git",

test/helper.spec.js

@@ -19,3 +19,3 @@ 'use strict'
         ['pkcs12', '-info', '-in', bufferOrPath, '-noout', '-maciter', '-nodes'],
-        tmpfiles[tmpfiles.length]
+        tmpfiles
       )
@@ -33,3 +33,3 @@ helper.deleteTempFiles(tmpfiles, function (fsErr) {
         ['pkcs12', '-info', '-in', bufferOrPath, '-noout', '-maciter', '-nodes'],
-        tmpfiles[tmpfiles.length]
+        tmpfiles
       )
@@ -47,3 +47,3 @@ helper.deleteTempFiles(tmpfiles, function (fsErr) {
         ['pkcs12', '-info', '-in', bufferOrPath, '-noout', '-maciter', '-nodes'],
-        tmpfiles[tmpfiles.length]
+        tmpfiles
       )
@@ -50,0 +50,0 @@ helper.deleteTempFiles(tmpfiles, function (fsErr) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

3190

increased by0.03%

Worsened metrics

Total package byte prevSize

184284

decreased by-0.37%

No dependency changes