pg-pool - npm Package Compare versions

Comparing version 1.4.2 to 1.4.3

index.js

@@ -99,3 +99,8 @@ var genericPool = require('generic-pool')
     this.connect(function (err, client, done) {
-      if (err) return reject(err)
+      if (err) {
+        if (cb) {
+          cb(err)
+        }
+        return reject(err)
+      }
       client.query(text, values, function (err, res) {
@@ -102,0 +107,0 @@ done(err)

package.json

 {
   "name": "pg-pool",
-  "version": "1.4.2",
+  "version": "1.4.3",
   "description": "Connection pool for node-postgres",
@@ -5,0 +5,0 @@ "main": "index.js",

test/index.js

@@ -65,2 +65,13 @@ var expect = require('expect.js')
 
+    it('passes connection errors to callback', function (done) {
+      var pool = new Pool({host: 'no-postgres-server-here.com'})
+      pool.query('SELECT $1::text as name', ['brianc'], function (err, res) {
+        expect(res).to.be(undefined)
+        expect(err).to.be.an(Error)
+        pool.end(function (err) {
+          done(err)
+        })
+      })
+    })
+
     it('removes client if it errors in background', function (done) {
@@ -67,0 +78,0 @@ var pool = new Pool()

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

23871

increased by1.82%

Lines of code

355

increased by4.41%

No dependency changes