piral-blazor - npm Package Compare versions

Comparing version 1.3.1 to 1.3.2-beta.6156

esm/dependencies.js

@@ -35,2 +35,3 @@ var _a, _b;
             prio = Math.max(prio, 0);
+            const isGlobal = kind === 'global';
             const depWithPrio = {
@@ -46,3 +47,7 @@ prio,
                 // let others (any global, or higher prio) finish first
-                yield Promise.all(depsWithPrios.filter((m) => m.prio > prio || (kind !== m.kind && m.kind === 'global')).map((m) => m.load()));
+                yield Promise.all(depsWithPrios
+                    .filter((m) => m !== depWithPrio)
+                    // prefer (any) global pilets before non-global ones and otherwise prefer higher prio than lower ones
+                    .filter((m) => m.prio > prio || (m.kind === 'global' && !isGlobal))
+                    .map((m) => m.load()));
                 window.dispatchEvent(new CustomEvent('loading-blazor-pilet', { detail: meta }));
@@ -58,3 +63,3 @@ if (capabilities.includes('load')) {
                     const pdbUrl = toPdb(dllUrl);
-                    const dependencySymbols = dependencies.map(toPdb).filter(dep => references.includes(dep));
+                    const dependencySymbols = dependencies.map(toPdb).filter((dep) => references.includes(dep));
                     const id = Math.random().toString(26).substring(2);
@@ -124,10 +129,10 @@ if (supportsCore) {
             };
-            if (kind === 'global' && !convert.loader) {
+            if (isGlobal && !convert.loader) {
                 result = convert.boot().then(load);
             }
-            else if (!convert.lazy || kind === 'global') {
+            else if (!convert.lazy || isGlobal) {
                 result = convert.loader.then(load);
             }
             dependency = (config) => result || (result = load(config));
-            if (prio) {
+            if (prio || isGlobal) {
                 depsWithPrios.push(depWithPrio);
@@ -134,0 +139,0 @@ }

lib/dependencies.js

@@ -38,2 +38,3 @@ "use strict";
             prio = Math.max(prio, 0);
+            const isGlobal = kind === 'global';
             const depWithPrio = {
@@ -49,3 +50,7 @@ prio,
                 // let others (any global, or higher prio) finish first
-                yield Promise.all(depsWithPrios.filter((m) => m.prio > prio || (kind !== m.kind && m.kind === 'global')).map((m) => m.load()));
+                yield Promise.all(depsWithPrios
+                    .filter((m) => m !== depWithPrio)
+                    // prefer (any) global pilets before non-global ones and otherwise prefer higher prio than lower ones
+                    .filter((m) => m.prio > prio || (m.kind === 'global' && !isGlobal))
+                    .map((m) => m.load()));
                 window.dispatchEvent(new CustomEvent('loading-blazor-pilet', { detail: meta }));
@@ -61,3 +66,3 @@ if (capabilities.includes('load')) {
                     const pdbUrl = toPdb(dllUrl);
-                    const dependencySymbols = dependencies.map(toPdb).filter(dep => references.includes(dep));
+                    const dependencySymbols = dependencies.map(toPdb).filter((dep) => references.includes(dep));
                     const id = Math.random().toString(26).substring(2);
@@ -127,10 +132,10 @@ if (supportsCore) {
             };
-            if (kind === 'global' && !convert.loader) {
+            if (isGlobal && !convert.loader) {
                 result = convert.boot().then(load);
             }
-            else if (!convert.lazy || kind === 'global') {
+            else if (!convert.lazy || isGlobal) {
                 result = convert.loader.then(load);
             }
             dependency = (config) => result || (result = load(config));
-            if (prio) {
+            if (prio || isGlobal) {
                 depsWithPrios.push(depWithPrio);
@@ -137,0 +142,0 @@ }

package.json

 {
   "name": "piral-blazor",
-  "version": "1.3.1",
+  "version": "1.3.2-beta.6156",
   "description": "Plugin for integrating Blazor components in Piral.",
@@ -70,5 +70,5 @@ "keywords": [
   "devDependencies": {
-    "piral-core": "^1.3.1"
+    "piral-core": "1.3.2-beta.6156"
   },
-  "gitHead": "b8d5d565ebfffc3aa4b60db561da885965aa3dd9"
+  "gitHead": "db349ac075fdc07b75eabffac1fcf964f851b189"
 }

src/dependencies.ts

@@ -44,5 +44,13 @@ import type { PiletMetadata } from 'piral-core';
     },
-    defineBlazorReferences(references: Array<string>, meta: Partial<PiletMetadata> = {}, satellites = {}, prio = 0, kind = 'local', sharedDependencies = []) {
+    defineBlazorReferences(
+      references: Array<string>,
+      meta: Partial<PiletMetadata> = {},
+      satellites = {},
+      prio = 0,
+      kind = 'local',
+      sharedDependencies = [],
+    ) {
       prio = Math.max(prio, 0);
 
+      const isGlobal = kind === 'global';
       const depWithPrio = {
@@ -59,3 +67,9 @@ prio,
         // let others (any global, or higher prio) finish first
-        await Promise.all(depsWithPrios.filter((m) => m.prio > prio || (kind !== m.kind && m.kind === 'global')).map((m) => m.load()));
+        await Promise.all(
+          depsWithPrios
+            .filter((m) => m !== depWithPrio)
+            // prefer (any) global pilets before non-global ones and otherwise prefer higher prio than lower ones
+            .filter((m) => m.prio > prio || (m.kind === 'global' && !isGlobal))
+            .map((m) => m.load()),
+        );
 
@@ -75,3 +89,3 @@ window.dispatchEvent(new CustomEvent('loading-blazor-pilet', { detail: meta }));
           const pdbUrl = toPdb(dllUrl);
-          const dependencySymbols = dependencies.map(toPdb).filter(dep => references.includes(dep));
+          const dependencySymbols = dependencies.map(toPdb).filter((dep) => references.includes(dep));
           const id = Math.random().toString(26).substring(2);
@@ -153,5 +167,5 @@
 
-      if (kind === 'global' && !convert.loader) {
+      if (isGlobal && !convert.loader) {
         result = convert.boot().then(load);
-      } else if (!convert.lazy || kind === 'global') {
+      } else if (!convert.lazy || isGlobal) {
         result = convert.loader.then(load);
@@ -162,3 +176,3 @@ }
 
-      if (prio) {
+      if (prio || isGlobal) {
         depsWithPrios.push(depWithPrio);
@@ -165,0 +179,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

197767

increased by0.52%

Lines of code

3137

increased by0.77%

Worsened metrics

Number of low quality alerts

1

increased byInfinity%

No dependency changes