playwright-core - npm Package Compare versions

Comparing version 1.44.0 to 1.44.1-beta-1716449392000

lib/server/electron/electron.js

@@ -159,3 +159,3 @@ "use strict";
       // --remote-debugging-port=0 must be the last playwright's argument, loader.ts relies on it.
-      const electronArguments = ['--inspect=0', '--remote-debugging-port=0', ...args];
+      let electronArguments = ['--inspect=0', '--remote-debugging-port=0', ...args];
       if (_os.default.platform() === 'linux') {
@@ -186,2 +186,12 @@ const runningAsRoot = process.geteuid && process.geteuid() === 0;
       }
+      let shell = false;
+      if (process.platform === 'win32') {
+        // On Windows in order to run .cmd files, shell: true is required.
+        // https://github.com/nodejs/node/issues/52554
+        shell = true;
+        // On Windows, we need to quote the executable path due to shell: true.
+        command = `"${command}"`;
+        // On Windows, we need to quote the arguments due to shell: true.
+        electronArguments = electronArguments.map(arg => `"${arg}"`);
+      }
 
@@ -204,5 +214,3 @@ // When debugging Playwright test that runs Electron, NODE_OPTIONS
         },
-        // On Windows in order to run .cmd files, shell: true is required.
-        // https://github.com/nodejs/node/issues/52554
-        shell: process.platform === 'win32',
+        shell,
         stdio: 'pipe',
@@ -209,0 +217,0 @@ cwd: options.cwd,

lib/server/trace/viewer/traceViewer.js

@@ -111,3 +111,3 @@ "use strict";
   await installRootRedirect(server, traceUrls, options);
-  const page = await openTraceViewerApp(server.urlPrefix(), browserName, options);
+  const page = await openTraceViewerApp(server.urlPrefix('precise'), browserName, options);
   if (exitOnClose) page.on('close', () => (0, _utils.gracefullyProcessExitDoNotHang)(0));
@@ -120,3 +120,3 @@ return page;
   await installRootRedirect(server, traceUrls, options);
-  await openTraceInBrowser(server.urlPrefix());
+  await openTraceInBrowser(server.urlPrefix('human-readable'));
 }
@@ -123,0 +123,0 @@ async function openTraceViewerApp(url, browserName, options) {

lib/utils/httpServer.js

@@ -32,5 +32,6 @@ "use strict";
 class HttpServer {
-  constructor(address = '') {
+  constructor() {
     this._server = void 0;
-    this._urlPrefix = void 0;
+    this._urlPrefixPrecise = '';
+    this._urlPrefixHumanReadable = '';
     this._port = 0;
@@ -40,3 +41,2 @@ this._started = false;
     this._wsGuid = void 0;
-    this._urlPrefix = address;
     this._server = (0, _network.createHttpServer)(this._onRequest.bind(this));
@@ -128,12 +128,11 @@ }
     (0, _debug.assert)(address, 'Could not bind server socket');
-    if (!this._urlPrefix) {
-      if (typeof address === 'string') {
-        this._urlPrefix = address;
-      } else {
-        this._port = address.port;
-        const resolvedHost = address.family === 'IPv4' ? address.address : `[${address.address}]`;
-        this._urlPrefix = `http://${resolvedHost}:${address.port}`;
-      }
+    if (typeof address === 'string') {
+      this._urlPrefixPrecise = address;
+      this._urlPrefixHumanReadable = address;
+    } else {
+      this._port = address.port;
+      const resolvedHost = address.family === 'IPv4' ? address.address : `[${address.address}]`;
+      this._urlPrefixPrecise = `http://${resolvedHost}:${address.port}`;
+      this._urlPrefixHumanReadable = `http://${host}:${address.port}`;
     }
-    return this._urlPrefix;
   }
@@ -143,4 +142,4 @@ async stop() {
   }
-  urlPrefix() {
-    return this._urlPrefix;
+  urlPrefix(purpose) {
+    return purpose === 'human-readable' ? this._urlPrefixHumanReadable : this._urlPrefixPrecise;
   }
@@ -147,0 +146,0 @@ serveFile(request, response, absoluteFilePath, headers) {

package.json

 {
   "name": "playwright-core",
-  "version": "1.44.0",
+  "version": "1.44.1-beta-1716449392000",
   "description": "A high-level API to automate web browsers",
@@ -5,0 +5,0 @@ "repository": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

100011

Worsened metrics

Total package byte prevSize

7120936

decreased by-0.01%

Number of low quality alerts

3

increased by50%

No dependency changes