popsicle - npm Package Compare versions

Comparing version 3.2.0 to 3.2.1

dist/request.js

@@ -210,3 +210,3 @@ var __extends = (this && this.__extends) || function (d, b) {
         if (request.errored) {
-            return Promise.reject(request.errored);
+            return;
         }
@@ -222,28 +222,19 @@ if (timeout) {
         req.opened = true;
-        return req.transport.open(request);
+        return req.transport.open(request)
+            .then(function (options) {
+            var response = new response_1.default(options);
+            response.request = request;
+            request.response = response;
+            return chain(req._after, response);
+        });
     })
-        .then(function (options) {
+        .then(function () { return chain(req._always, request); }, function (error) { return chain(req._always, request).then(function () { return Promise.reject(error); }); })
+        .then(function () {
         if (request.errored) {
             return Promise.reject(request.errored);
         }
-        var response = new response_1.default(options);
-        response.request = request;
-        request.response = response;
-        return response;
-    })
-        .then(function (response) {
-        return chain(req._after, response);
-    })
-        .then(function () {
-        return chain(req._always, request)
-            .then(function () { return request.response; });
+        return request.response;
     }, function (error) {
-        return chain(req._always, request)
-            .then(function () { return Promise.reject(request.errored || error); });
-    })
-        .then(function (response) {
-        if (request.errored) {
-            return Promise.reject(request.errored);
-        }
-        return response;
+        request.errored = request.errored || error;
+        return Promise.reject(request.errored);
     });
@@ -250,0 +241,0 @@ }

package.json

 {
   "name": "popsicle",
-  "version": "3.2.0",
+  "version": "3.2.1",
   "description": "Simple HTTP requests for node and the browser",
@@ -5,0 +5,0 @@ "main": "dist/common.js",

README.md

@@ -336,5 +336,3 @@ # ![Popsicle](https://cdn.rawgit.com/blakeembrey/popsicle/master/logo.svg)
   return function (self) {
-    self.before(function (req) {
-      request.url = url + req.url
-    })
+    request.url = url + req.url
   }
@@ -356,3 +354,3 @@ }
 
-**Tip:** Always use the lifecycle hooks, actions directly in `use` can not be re-used (E.g. with a request clone).
+**Tip:** Use the lifecycle hooks (above) when you want re-use (E.g. re-use when the request is cloned or options re-used).
 
@@ -359,0 +357,0 @@ #### Checking The Environment

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

166422

decreased by-0.21%

Lines of code

2061

decreased by-0.43%

Number of lines in readme file

399

decreased by-0.5%

No dependency changes