postman-collection - npm Package Compare versions

Comparing version 3.4.9 to 3.5.0

lib/collection/description.js

@@ -143,2 +143,3 @@ var _ = require('../util').lodash,
      * @enum {Function}
+     * @deprecated since v3.5.0, drop support for description formatter
      */
@@ -145,0 +146,0 @@ format: {

lib/collection/request.js

@@ -191,4 +191,4 @@ var util = require('../util'),
         if (_.isObject(type) && _.isNil(options)) {
-            type = options.type;
-            options = _.omit(options, 'type');
+            options = _.omit(type, 'type');
+            type = type.type;
         }
@@ -195,0 +195,0 @@

lib/collection/url.js

@@ -202,3 +202,4 @@ var _ = require('../util').lodash,
         var rawUrl = E,
-            protocol = this.protocol;
+            protocol = this.protocol,
+            queryString;
 
@@ -230,3 +231,4 @@ forceProtocol && !protocol && (protocol = DEFAULT_PROTOCOL);
         if (this.query && this.query.count()) {
-            rawUrl += QUERY_SEPARATOR + this.getQueryString({ ignoreDisabled: true });
+            queryString = this.getQueryString({ ignoreDisabled: true });
+            queryString && (rawUrl += QUERY_SEPARATOR + queryString);
         }
@@ -233,0 +235,0 @@

lib/collection/variable-scope.js

@@ -196,9 +196,21 @@ var _ = require('../util').lodash,
      *
-     * @param {String} variableName
-     * @returns {Boolean}
+     * @param {String} key - The name of the variable to check
+     * @returns {Boolean} - Returns true if an enabled variable with given key is present in current or parent scopes,
+     *                      false otherwise
      */
-    has: function (variableName) {
-        var variable = this.values.oneNormalizedVariable(variableName);
+    has: function (key) {
+        var variable = this.values.oneNormalizedVariable(key),
+            i,
+            ii;
 
-        return Boolean(variable && !variable.disabled);
+        // if a variable is disabled or does not exist in local scope,
+        // we search all the layers and return the first occurrence.
+        if ((!variable || variable.disabled === true) && this._layers) {
+            for (i = 0, ii = this._layers.length; i < ii; i++) {
+                variable = this._layers[i].oneNormalizedVariable(key);
+                if (variable && variable.disabled !== true) { break; }
+            }
+        }
+
+        return Boolean(variable && variable.disabled !== true);
     },
@@ -218,10 +230,10 @@
         // if a variable does not exist in local scope, we search all the layers and return the first occurrence.
-        if (!(variable || !this._layers)) {
+        if ((!variable || variable.disabled === true) && this._layers) {
             for (i = 0, ii = this._layers.length; i < ii; i++) {
                 variable = this._layers[i].oneNormalizedVariable(key);
-                if (variable && !variable.disabled) { break; }
+                if (variable && variable.disabled !== true) { break; }
             }
         }
 
-        return (variable && !variable.disabled) ? variable.valueOf() : undefined;
+        return (variable && variable.disabled !== true) ? variable.valueOf() : undefined;
     },
@@ -228,0 +240,0 @@

package.json

@@ -5,3 +5,3 @@ {
   "author": "Postman Labs <[e-mail]>",
-  "version": "3.4.9",
+  "version": "3.5.0",
   "keywords": [
@@ -60,3 +60,3 @@ "postman"
     "eslint": "5.16.0",
-    "eslint-plugin-jsdoc": "5.0.2",
+    "eslint-plugin-jsdoc": "8.1.0",
     "eslint-plugin-lodash": "5.1.0",
@@ -63,0 +63,0 @@ "eslint-plugin-mocha": "5.3.0",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

504382

increased by0.28%

Lines of code

10792

increased by0.13%

No dependency changes